diff options
| author | Tom Hochstein <tom.hochstein@nxp.com> | 2022-08-02 13:06:30 -0500 |
|---|---|---|
| committer | github-actions[bot] <github-actions[bot]@users.noreply.github.com> | 2022-08-02 18:50:19 +0000 |
| commit | 42cb2e70466293a1cc9b3aea79c9f167e4fd7aeb (patch) | |
| tree | aefc11ea237372e6c3b8699276dfe21b7a721fe7 | |
| parent | 1733bf1dd19b0681122099d84cb758197c8fd898 (diff) | |
| download | meta-freescale-backport-1163-to-kirkstone.tar.gz | |
imx-base.inc: Expand comment for UBOOT_SUFFIXbackport-1163-to-kirkstone
The UBOOT_SUFFIX override is complex and makes a requirement on the
machine config that is easy to overlook, namely that it will
evaluate incorrectly to empty if the variable is not overridden
in some form by the machine config.
Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
(cherry picked from commit 526798901506f890f5682ff31a00ba1ea7b31331)
| -rw-r--r-- | conf/machine/include/imx-base.inc | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc index 2962c9e9..cc55d327 100644 --- a/conf/machine/include/imx-base.inc +++ b/conf/machine/include/imx-base.inc | |||
| @@ -60,6 +60,14 @@ UBOOT_BINARY ?= "u-boot.${UBOOT_SUFFIX}" | |||
| 60 | # | | 60 | # | |
| 61 | # | UBOOT_MACHINE = "mx53loco_config" | 61 | # | UBOOT_MACHINE = "mx53loco_config" |
| 62 | # `---- | 62 | # `---- |
| 63 | # | ||
| 64 | # Please note that UBOOT_SUFFIX must be set in the machine config even | ||
| 65 | # if the value is the same for the U-Boot flavors. If the value is not | ||
| 66 | # set, then the assignment here is the one used, the value resolves to | ||
| 67 | # empty, and the build fails: | ||
| 68 | # | cp: cannot stat '/.../tmp/work/imx8qm_mek-fsl-linux/u-boot-imx/2022.04-r0/build/imx8qm_mek_defconfig/u-boot.': No such file or directory | ||
| 69 | #| WARNING: /.../tmp/work/imx8qm_mek-fsl-linux/u-boot-imx/2022.04-r0/temp/run.do_compile.21223:186 exit 1 from 'cp /.../tmp/work/imx8qm_mek-fsl-linux/u-boot-imx/2022.04-r0/build/${config}/${binary} /.../tmp/work/imx8qm_mek-fsl-linux/u-boot-imx/2022.04-r0/build/${config}/u-boot-${type}.${UBOOT_SUFFIX:pn-u-boot-imx}' | ||
| 70 | # | ||
| 63 | IMX_DEFAULT_BOOTLOADER ??= "u-boot-fslc" | 71 | IMX_DEFAULT_BOOTLOADER ??= "u-boot-fslc" |
| 64 | UBOOT_SUFFIX ?= "${UBOOT_SUFFIX:pn-${IMX_DEFAULT_BOOTLOADER}}" | 72 | UBOOT_SUFFIX ?= "${UBOOT_SUFFIX:pn-${IMX_DEFAULT_BOOTLOADER}}" |
| 65 | 73 | ||