From 42cb2e70466293a1cc9b3aea79c9f167e4fd7aeb Mon Sep 17 00:00:00 2001 From: Tom Hochstein Date: Tue, 2 Aug 2022 13:06:30 -0500 Subject: imx-base.inc: Expand comment for UBOOT_SUFFIX The UBOOT_SUFFIX override is complex and makes a requirement on the machine config that is easy to overlook, namely that it will evaluate incorrectly to empty if the variable is not overridden in some form by the machine config. Signed-off-by: Tom Hochstein (cherry picked from commit 526798901506f890f5682ff31a00ba1ea7b31331) --- conf/machine/include/imx-base.inc | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc index 2962c9e9..cc55d327 100644 --- a/conf/machine/include/imx-base.inc +++ b/conf/machine/include/imx-base.inc @@ -60,6 +60,14 @@ UBOOT_BINARY ?= "u-boot.${UBOOT_SUFFIX}" # | # | UBOOT_MACHINE = "mx53loco_config" # `---- +# +# Please note that UBOOT_SUFFIX must be set in the machine config even +# if the value is the same for the U-Boot flavors. If the value is not +# set, then the assignment here is the one used, the value resolves to +# empty, and the build fails: +# | cp: cannot stat '/.../tmp/work/imx8qm_mek-fsl-linux/u-boot-imx/2022.04-r0/build/imx8qm_mek_defconfig/u-boot.': No such file or directory +#| WARNING: /.../tmp/work/imx8qm_mek-fsl-linux/u-boot-imx/2022.04-r0/temp/run.do_compile.21223:186 exit 1 from 'cp /.../tmp/work/imx8qm_mek-fsl-linux/u-boot-imx/2022.04-r0/build/${config}/${binary} /.../tmp/work/imx8qm_mek-fsl-linux/u-boot-imx/2022.04-r0/build/${config}/u-boot-${type}.${UBOOT_SUFFIX:pn-u-boot-imx}' +# IMX_DEFAULT_BOOTLOADER ??= "u-boot-fslc" UBOOT_SUFFIX ?= "${UBOOT_SUFFIX:pn-${IMX_DEFAULT_BOOTLOADER}}" -- cgit v1.2.3-54-g00ecf