Fix all flake8 warnings from newer flake8-bugbear and flake8-comprehensions

Address warnings introduced by flake8-bugbear 24.12.12 and
flake8-comprehensions 3.16.0:

- C408: Replace dict()/list() calls with literal {} and []
- C413: Remove unnecessary list() around sorted()
- C414: Remove unnecessary list() inside sorted()
- C419: Suppress intentional list comprehension in all() (noqa)
- B001: Replace bare except with except Exception
- B006: Replace mutable default arguments with None
- B010: Replace setattr() with direct attribute assignment
- B017: Use RuntimeError instead of Exception in tests
- B019: Suppress lru_cache on methods for long-lived objects (noqa)
- B033: Remove duplicate item in set literal

Change-Id: If4693d3e946200bbc22f689f7b94da604addcb80
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/566321
Tested-by: Carlos Fernandez <carlosfsanz@meta.com>
Commit-Queue: Carlos Fernandez <carlosfsanz@meta.com>
Reviewed-by: Mike Frysinger <vapier@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>

1 files changed, 5 insertions, 5 deletions

diff --git a/tests/test_wrapper.py b/tests/test_wrapper.py
index a38705675..36465e737 100644
--- a/tests/test_wrapper.py
+++ b/tests/test_wrapper.py
@@ -385,11 +385,11 @@ class VerifyRev(RepoWrapperTestCase):
     def test_verify_fails(self):
         """Check we fall back to signed tag when we have an unsigned commit."""
         desc_result = subprocess.CompletedProcess([], 0, "v1.0-10-g1234\n", "")
-        gpg_result = Exception
+        gpg_result = RuntimeError
         with mock.patch.object(
             self.wrapper, "run_git", side_effect=(desc_result, gpg_result)
         ):
-            with self.assertRaises(Exception):
+            with self.assertRaises(RuntimeError):
                 self.wrapper.verify_rev("/", "refs/heads/stable", "1234", True)
 
 
@@ -543,15 +543,15 @@ class CheckRepoRev(GitCheckoutTestCase):
             self.wrapper, "check_repo_verify", return_value=True
         ):
             with mock.patch.object(
-                self.wrapper, "verify_rev", side_effect=Exception
+                self.wrapper, "verify_rev", side_effect=RuntimeError
             ):
-                with self.assertRaises(Exception):
+                with self.assertRaises(RuntimeError):
                     self.wrapper.check_repo_rev(self.GIT_DIR, "stable")
 
     def test_verify_ignore(self):
         """Should pass when verification is disabled."""
         with mock.patch.object(
-            self.wrapper, "verify_rev", side_effect=Exception
+            self.wrapper, "verify_rev", side_effect=RuntimeError
         ):
             rrev, lrev = self.wrapper.check_repo_rev(
                 self.GIT_DIR, "stable", repo_verify=False