summaryrefslogtreecommitdiffstats
path: root/meta/recipes-devtools/python/python3_3.10.16.bb
diff options
context:
space:
mode:
Diffstat (limited to 'meta/recipes-devtools/python/python3_3.10.16.bb')
-rw-r--r--meta/recipes-devtools/python/python3_3.10.16.bb434
1 files changed, 434 insertions, 0 deletions
diff --git a/meta/recipes-devtools/python/python3_3.10.16.bb b/meta/recipes-devtools/python/python3_3.10.16.bb
new file mode 100644
index 0000000000..19a85a8770
--- /dev/null
+++ b/meta/recipes-devtools/python/python3_3.10.16.bb
@@ -0,0 +1,434 @@
1SUMMARY = "The Python Programming Language"
2HOMEPAGE = "http://www.python.org"
3DESCRIPTION = "Python is a programming language that lets you work more quickly and integrate your systems more effectively."
4LICENSE = "PSF-2.0"
5SECTION = "devel/python"
6
7LIC_FILES_CHKSUM = "file://LICENSE;md5=fcf6b249c2641540219a727f35d8d2c2"
8
9SRC_URI = "http://www.python.org/ftp/python/${PV}/Python-${PV}.tar.xz \
10 file://run-ptest \
11 file://create_manifest3.py \
12 file://get_module_deps3.py \
13 file://python3-manifest.json \
14 file://check_build_completeness.py \
15 file://reformat_sysconfig.py \
16 file://cgi_py.patch \
17 file://0001-Do-not-add-usr-lib-termcap-to-linker-flags-to-avoid-.patch \
18 ${@bb.utils.contains('PACKAGECONFIG', 'tk', '', 'file://avoid_warning_about_tkinter.patch', d)} \
19 file://0001-Do-not-use-the-shell-version-of-python-config-that-w.patch \
20 file://python-config.patch \
21 file://0001-Makefile.pre-use-qemu-wrapper-when-gathering-profile.patch \
22 file://0001-python3-use-cc_basename-to-replace-CC-for-checking-c.patch \
23 file://0001-bpo-36852-proper-detection-of-mips-architecture-for-.patch \
24 file://crosspythonpath.patch \
25 file://0001-Use-FLAG_REF-always-for-interned-strings.patch \
26 file://0001-test_locale.py-correct-the-test-output-format.patch \
27 file://0017-setup.py-do-not-report-missing-dependencies-for-disa.patch \
28 file://0001-Makefile-do-not-compile-.pyc-in-parallel.patch \
29 file://0020-configure.ac-setup.py-do-not-add-a-curses-include-pa.patch \
30 file://0001-Skip-failing-tests-due-to-load-variability-on-YP-AB.patch \
31 file://0001-test_ctypes.test_find-skip-without-tools-sdk.patch \
32 file://makerace.patch \
33 file://0001-sysconfig.py-use-platlibdir-also-for-purelib.patch \
34 file://0001-Lib-pty.py-handle-stdin-I-O-errors-same-way-as-maste.patch \
35 file://0001-setup.py-Do-not-detect-multiarch-paths-when-cross-co.patch \
36 file://deterministic_imports.patch \
37 file://0001-Avoid-shebang-overflow-on-python-config.py.patch \
38 file://0001-test_storlines-skip-due-to-load-variability.patch \
39 "
40
41SRC_URI:append:class-native = " \
42 file://0001-Lib-sysconfig.py-use-prefix-value-from-build-configu.patch \
43 file://0001-distutils-sysconfig-append-STAGING_LIBDIR-python-sys.patch \
44 file://12-distutils-prefix-is-inside-staging-area.patch \
45 file://0001-Don-t-search-system-for-headers-libraries.patch \
46 "
47SRC_URI[sha256sum] = "bfb249609990220491a1b92850a07135ed0831e41738cf681d63cf01b2a8fbd1"
48
49# exclude pre-releases for both python 2.x and 3.x
50UPSTREAM_CHECK_REGEX = "[Pp]ython-(?P<pver>\d+(\.\d+)+).tar"
51UPSTREAM_CHECK_URI = "https://www.python.org/downloads/source/"
52
53CVE_PRODUCT = "python"
54
55# Upstream consider this expected behaviour
56CVE_CHECK_IGNORE += "CVE-2007-4559"
57# This is not exploitable when glibc has CVE-2016-10739 fixed.
58CVE_CHECK_IGNORE += "CVE-2019-18348"
59# These are specific to Microsoft Windows
60CVE_CHECK_IGNORE += "CVE-2020-15523 CVE-2022-26488"
61# The mailcap module is insecure by design, so this can't be fixed in a meaningful way.
62# The module will be removed in the future and flaws documented.
63CVE_CHECK_IGNORE += "CVE-2015-20107"
64# Not an issue, in fact expected behaviour
65CVE_CHECK_IGNORE += "CVE-2023-36632"
66# Fixes are included in 3.10.15
67CVE_CHECK_IGNORE += "CVE-2023-27043 CVE-2024-6232 CVE-2024-7592"
68
69PYTHON_MAJMIN = "3.10"
70
71S = "${WORKDIR}/Python-${PV}"
72
73BBCLASSEXTEND = "native nativesdk"
74
75inherit autotools pkgconfig qemu ptest multilib_header update-alternatives
76
77MULTILIB_SUFFIX = "${@d.getVar('base_libdir',1).split('/')[-1]}"
78
79ALTERNATIVE:${PN}-dev = "python3-config"
80ALTERNATIVE_LINK_NAME[python3-config] = "${bindir}/python${PYTHON_MAJMIN}-config"
81ALTERNATIVE_TARGET[python3-config] = "${bindir}/python${PYTHON_MAJMIN}-config-${MULTILIB_SUFFIX}"
82
83
84DEPENDS = "bzip2-replacement-native libffi bzip2 openssl sqlite3 zlib virtual/libintl xz virtual/crypt util-linux-libuuid libtirpc libnsl2 autoconf-archive-native ncurses"
85DEPENDS:append:class-target = " python3-native"
86DEPENDS:append:class-nativesdk = " python3-native"
87
88# force to use the mutex+cond implementation (https://bugs.python.org/issue41710)
89CFLAGS += "-DHAVE_BROKEN_POSIX_SEMAPHORES"
90
91EXTRA_OECONF = " --without-ensurepip --enable-shared --with-platlibdir=${baselib}"
92EXTRA_OECONF:append:class-native = " --bindir=${bindir}/${PN}"
93
94export CROSSPYTHONPATH="${STAGING_LIBDIR_NATIVE}/python${PYTHON_MAJMIN}/lib-dynload/"
95
96EXTRANATIVEPATH += "python3-native"
97
98# LTO will be enabled via packageconfig depending upong distro features
99LTO:class-target = ""
100
101CACHED_CONFIGUREVARS = " \
102 ac_cv_file__dev_ptmx=yes \
103 ac_cv_file__dev_ptc=no \
104 ac_cv_working_tzset=yes \
105"
106
107# PGO currently causes builds to not be reproducible so disable by default, see YOCTO #13407
108PACKAGECONFIG:class-target ??= "readline gdbm ${@bb.utils.filter('DISTRO_FEATURES', 'lto', d)}"
109PACKAGECONFIG:class-native ??= "readline gdbm"
110PACKAGECONFIG:class-nativesdk ??= "readline gdbm"
111PACKAGECONFIG[readline] = "--with-readline=readline,,readline,,,editline"
112PACKAGECONFIG[editline] = "--with-readline=editline,,libedit,,,readline"
113# Use profile guided optimisation by running PyBench inside qemu-user
114PACKAGECONFIG[pgo] = "--enable-optimizations,,qemu-native"
115PACKAGECONFIG[tk] = ",,tk"
116PACKAGECONFIG[gdbm] = ",,gdbm"
117PACKAGECONFIG[lto] = "--with-lto,,"
118
119do_configure:prepend () {
120 mkdir -p ${B}/Modules
121 cat > ${B}/Modules/Setup.local << EOF
122*disabled*
123${@bb.utils.contains('PACKAGECONFIG', 'gdbm', '', '_gdbm _dbm', d)}
124${@bb.utils.contains_any('PACKAGECONFIG', 'readline editline', '', 'readline', d)}
125EOF
126}
127
128CPPFLAGS:append = " -I${STAGING_INCDIR}/ncursesw -I${STAGING_INCDIR}/uuid"
129
130EXTRA_OEMAKE = '\
131 STAGING_LIBDIR=${STAGING_LIBDIR} \
132 STAGING_INCDIR=${STAGING_INCDIR} \
133 LIB=${baselib} \
134'
135
136do_compile:prepend:class-target() {
137 if ${@bb.utils.contains('PACKAGECONFIG', 'pgo', 'true', 'false', d)}; then
138 qemu_binary="${@qemu_wrapper_cmdline(d, '${STAGING_DIR_TARGET}', ['${B}', '${STAGING_DIR_TARGET}/${base_libdir}'])}"
139 cat >pgo-wrapper <<EOF
140#!/bin/sh
141cd ${B}
142$qemu_binary "\$@"
143EOF
144 chmod +x pgo-wrapper
145 fi
146}
147
148do_install:prepend() {
149 ${WORKDIR}/check_build_completeness.py ${T}/log.do_compile
150}
151
152do_install:append:class-target() {
153 oe_multilib_header python${PYTHON_MAJMIN}/pyconfig.h
154}
155
156do_install:append:class-native() {
157 # Make sure we use /usr/bin/env python
158 for PYTHSCRIPT in `grep -rIl ${bindir}/${PN}/python ${D}${bindir}/${PN}`; do
159 sed -i -e '1s|^#!.*|#!/usr/bin/env python3|' $PYTHSCRIPT
160 done
161 # Add a symlink to the native Python so that scripts can just invoke
162 # "nativepython" and get the right one without needing absolute paths
163 # (these often end up too long for the #! parser in the kernel as the
164 # buffer is 128 bytes long).
165 ln -s python3-native/python3 ${D}${bindir}/nativepython3
166
167 # Remove the opt-1.pyc and opt-2.pyc files. There are over 3,000 of them
168 # and the overhead in each recipe-sysroot-native isn't worth it, particularly
169 # when they're only used for python called with -O or -OO.
170 #find ${D} -name *opt-*.pyc -delete
171 # Remove all pyc files. There are a ton of them and it is probably faster to let
172 # python create the ones it wants at runtime rather than manage in the sstate
173 # tarballs and sysroot creation.
174 find ${D} -name *.pyc -delete
175
176 # Nothing should be looking into ${B} for python3-native
177 sed -i -e 's:${B}:/build/path/unavailable/:g' \
178 ${D}/${libdir}/python${PYTHON_MAJMIN}/config-${PYTHON_MAJMIN}${PYTHON_ABI}*/Makefile
179}
180
181do_install:append() {
182 for c in ${D}/${libdir}/python${PYTHON_MAJMIN}/_sysconfigdata*.py; do
183 python3 ${WORKDIR}/reformat_sysconfig.py $c
184 done
185 rm -f ${D}${libdir}/python${PYTHON_MAJMIN}/__pycache__/_sysconfigdata*.cpython*
186
187 mkdir -p ${D}${libdir}/python-sysconfigdata
188 sysconfigfile=`find ${D} -name _sysconfig*.py`
189 sed -i \
190 -e "s,^ 'LIBDIR'.*, 'LIBDIR': '${STAGING_LIBDIR}'\,,g" \
191 -e "s,^ 'INCLUDEDIR'.*, 'INCLUDEDIR': '${STAGING_INCDIR}'\,,g" \
192 -e "s,^ 'CONFINCLUDEDIR'.*, 'CONFINCLUDEDIR': '${STAGING_INCDIR}'\,,g" \
193 -e "/^ 'INCLDIRSTOMAKE'/{N; s,/usr/include,${STAGING_INCDIR},g}" \
194 -e "/^ 'INCLUDEPY'/s,/usr/include,${STAGING_INCDIR},g" \
195 -e "s,${B},/build/path/unavailable/,g" \
196 $sysconfigfile
197 cp $sysconfigfile ${D}${libdir}/python-sysconfigdata/_sysconfigdata.py
198
199
200 # Unfortunately the following pyc files are non-deterministc due to 'frozenset'
201 # being written without strict ordering, even with PYTHONHASHSEED = 0
202 # Upstream is discussing ways to solve the issue properly, until then let's
203 # just not install the problematic files.
204 # More info: http://benno.id.au/blog/2013/01/15/python-determinism
205 rm -f ${D}${libdir}/python${PYTHON_MAJMIN}/test/__pycache__/test_range.cpython*
206 rm -f ${D}${libdir}/python${PYTHON_MAJMIN}/test/__pycache__/test_xml_etree.cpython*
207
208 # Similar to the above, we're getting reproducibility issues with
209 # /usr/lib/python3.10/__pycache__/traceback.cpython-310.pyc
210 # so remove it too
211 rm -f ${D}${libdir}/python${PYTHON_MAJMIN}/__pycache__/traceback.cpython*
212
213 # Remove the opt-1.pyc and opt-2.pyc files. They effectively waste space on embedded
214 # style targets as they're only used when python is called with the -O or -OO options
215 # which is rare.
216 find ${D} -name *opt-*.pyc -delete
217}
218
219do_install:append:class-nativesdk () {
220 # Make sure we use /usr/bin/env python
221 for PYTHSCRIPT in `grep -rIl ${bindir}/python ${D}${bindir}`; do
222 sed -i -e '1s|^#!.*|#!/usr/bin/env python3|' $PYTHSCRIPT
223 done
224 create_wrapper ${D}${bindir}/python${PYTHON_MAJMIN} TERMINFO_DIRS='${sysconfdir}/terminfo:/etc/terminfo:/usr/share/terminfo:/usr/share/misc/terminfo:/lib/terminfo' PYTHONNOUSERSITE='1'
225}
226
227SSTATE_SCAN_FILES += "Makefile _sysconfigdata.py"
228SSTATE_HASHEQUIV_FILEMAP = " \
229 populate_sysroot:*/lib*/python3*/_sysconfigdata*.py:${TMPDIR} \
230 populate_sysroot:*/lib*/python3*/_sysconfigdata*.py:${COREBASE} \
231 populate_sysroot:*/lib*/python3*/config-*/Makefile:${TMPDIR} \
232 populate_sysroot:*/lib*/python3*/config-*/Makefile:${COREBASE} \
233 populate_sysroot:*/lib*/python-sysconfigdata/_sysconfigdata.py:${TMPDIR} \
234 populate_sysroot:*/lib*/python-sysconfigdata/_sysconfigdata.py:${COREBASE} \
235 "
236PACKAGE_PREPROCESS_FUNCS += "py_package_preprocess"
237
238py_package_preprocess () {
239 # Remove references to buildmachine paths in target Makefile and _sysconfigdata
240 sed -i -e 's:--sysroot=${STAGING_DIR_TARGET}::g' -e s:'--with-libtool-sysroot=${STAGING_DIR_TARGET}'::g \
241 -e 's|${DEBUG_PREFIX_MAP}||g' \
242 -e 's:${HOSTTOOLS_DIR}/::g' \
243 -e 's:${RECIPE_SYSROOT_NATIVE}::g' \
244 -e 's:${RECIPE_SYSROOT}::g' \
245 -e 's:${BASE_WORKDIR}/${MULTIMACH_TARGET_SYS}::g' \
246 ${PKGD}/${libdir}/python${PYTHON_MAJMIN}/config-${PYTHON_MAJMIN}${PYTHON_ABI}*/Makefile \
247 ${PKGD}/${libdir}/python${PYTHON_MAJMIN}/_sysconfigdata*.py \
248 ${PKGD}/${bindir}/python${PYTHON_MAJMIN}-config
249
250 # Reformat _sysconfigdata after modifying it so that it remains
251 # reproducible
252 for c in ${PKGD}/${libdir}/python${PYTHON_MAJMIN}/_sysconfigdata*.py; do
253 python3 ${WORKDIR}/reformat_sysconfig.py $c
254 done
255
256 # Recompile _sysconfigdata after modifying it
257 cd ${PKGD}
258 sysconfigfile=`find . -name _sysconfigdata_*.py`
259 ${STAGING_BINDIR_NATIVE}/python3-native/python3 \
260 -c "from py_compile import compile; compile('$sysconfigfile')"
261 ${STAGING_BINDIR_NATIVE}/python3-native/python3 \
262 -c "from py_compile import compile; compile('$sysconfigfile', optimize=1)"
263 ${STAGING_BINDIR_NATIVE}/python3-native/python3 \
264 -c "from py_compile import compile; compile('$sysconfigfile', optimize=2)"
265 cd -
266
267 mv ${PKGD}/${bindir}/python${PYTHON_MAJMIN}-config ${PKGD}/${bindir}/python${PYTHON_MAJMIN}-config-${MULTILIB_SUFFIX}
268
269 #Remove the unneeded copy of target sysconfig data
270 rm -rf ${PKGD}/${libdir}/python-sysconfigdata
271}
272
273# We want bytecode precompiled .py files (.pyc's) by default
274# but the user may set it on their own conf
275INCLUDE_PYCS ?= "1"
276
277python(){
278 import collections, json
279
280 filename = os.path.join(d.getVar('THISDIR'), 'python3', 'python3-manifest.json')
281 # This python changes the datastore based on the contents of a file, so mark
282 # that dependency.
283 bb.parse.mark_dependency(d, filename)
284
285 with open(filename) as manifest_file:
286 manifest_str = manifest_file.read()
287 json_start = manifest_str.find('# EOC') + 6
288 manifest_file.seek(json_start)
289 manifest_str = manifest_file.read()
290 python_manifest = json.loads(manifest_str, object_pairs_hook=collections.OrderedDict)
291
292 # First set RPROVIDES for -native case
293 # Hardcoded since it cant be python3-native-foo, should be python3-foo-native
294 pn = 'python3'
295 rprovides = (d.getVar('RPROVIDES') or "").split()
296
297 # ${PN}-misc-native is not in the manifest
298 rprovides.append(pn + '-misc-native')
299
300 for key in python_manifest:
301 pypackage = pn + '-' + key + '-native'
302 if pypackage not in rprovides:
303 rprovides.append(pypackage)
304
305 d.setVar('RPROVIDES:class-native', ' '.join(rprovides))
306
307 # Then work on the target
308 include_pycs = d.getVar('INCLUDE_PYCS')
309
310 packages = d.getVar('PACKAGES').split()
311 pn = d.getVar('PN')
312
313 newpackages=[]
314 for key in python_manifest:
315 pypackage = pn + '-' + key
316
317 if pypackage not in packages:
318 # We need to prepend, otherwise python-misc gets everything
319 # so we use a new variable
320 newpackages.append(pypackage)
321
322 # "Build" python's manifest FILES, RDEPENDS and SUMMARY
323 d.setVar('FILES:' + pypackage, '')
324 for value in python_manifest[key]['files']:
325 d.appendVar('FILES:' + pypackage, ' ' + value)
326
327 # Add cached files
328 if include_pycs == '1':
329 for value in python_manifest[key]['cached']:
330 d.appendVar('FILES:' + pypackage, ' ' + value)
331
332 for value in python_manifest[key]['rdepends']:
333 # Make it work with or without $PN
334 if '${PN}' in value:
335 value=value.split('-', 1)[1]
336 d.appendVar('RDEPENDS:' + pypackage, ' ' + pn + '-' + value)
337
338 for value in python_manifest[key].get('rrecommends', ()):
339 if '${PN}' in value:
340 value=value.split('-', 1)[1]
341 d.appendVar('RRECOMMENDS:' + pypackage, ' ' + pn + '-' + value)
342
343 d.setVar('SUMMARY:' + pypackage, python_manifest[key]['summary'])
344
345 # Prepending so to avoid python-misc getting everything
346 packages = newpackages + packages
347 d.setVar('PACKAGES', ' '.join(packages))
348 d.setVar('ALLOW_EMPTY:${PN}-modules', '1')
349 d.setVar('ALLOW_EMPTY:${PN}-pkgutil', '1')
350
351 if "pgo" in d.getVar("PACKAGECONFIG").split() and not bb.utils.contains('MACHINE_FEATURES', 'qemu-usermode', True, False, d):
352 bb.fatal("pgo cannot be enabled as there is no qemu-usermode support for this architecture/machine")
353}
354
355# Files needed to create a new manifest
356
357do_create_manifest() {
358 # This task should be run with every new release of Python.
359 # We must ensure that PACKAGECONFIG enables everything when creating
360 # a new manifest, this is to base our new manifest on a complete
361 # native python build, containing all dependencies, otherwise the task
362 # wont be able to find the required files.
363 # e.g. BerkeleyDB is an optional build dependency so it may or may not
364 # be present, we must ensure it is.
365
366 cd ${WORKDIR}
367 # This needs to be executed by python-native and NOT by HOST's python
368 nativepython3 create_manifest3.py ${PYTHON_MAJMIN}
369 cp python3-manifest.json.new ${THISDIR}/python3/python3-manifest.json
370}
371
372# bitbake python -c create_manifest
373# Make sure we have native python ready when we create a new manifest
374addtask do_create_manifest after do_patch do_prepare_recipe_sysroot
375
376# manual dependency additions
377RRECOMMENDS:${PN}-core:append:class-nativesdk = " nativesdk-python3-modules"
378RRECOMMENDS:${PN}-crypt:append:class-target = " ${MLPREFIX}openssl ${MLPREFIX}ca-certificates"
379RRECOMMENDS:${PN}-crypt:append:class-nativesdk = " ${MLPREFIX}openssl ${MLPREFIX}ca-certificates"
380
381# For historical reasons PN is empty and provided by python3-modules
382FILES:${PN} = ""
383RPROVIDES:${PN}-modules = "${PN}"
384
385FILES:${PN}-pydoc += "${bindir}/pydoc${PYTHON_MAJMIN} ${bindir}/pydoc3"
386FILES:${PN}-idle += "${bindir}/idle3 ${bindir}/idle${PYTHON_MAJMIN}"
387
388# provide python-pyvenv from python3-venv
389RPROVIDES:${PN}-venv += "${MLPREFIX}python3-pyvenv"
390
391# package libpython3
392PACKAGES =+ "libpython3 libpython3-staticdev"
393FILES:libpython3 = "${libdir}/libpython*.so.*"
394FILES:libpython3-staticdev += "${libdir}/python${PYTHON_MAJMIN}/config-${PYTHON_MAJMIN}-*/libpython${PYTHON_MAJMIN}.a"
395INSANE_SKIP:${PN}-dev += "dev-elf"
396INSANE_SKIP:${PN}-ptest = "dev-deps"
397
398# catch all the rest (unsorted)
399PACKAGES += "${PN}-misc"
400RDEPENDS:${PN}-misc += "\
401 ${PN}-core \
402 ${PN}-email \
403 ${PN}-codecs \
404 ${PN}-pydoc \
405 ${PN}-pickle \
406 ${PN}-audio \
407 ${PN}-numbers \
408"
409RDEPENDS:${PN}-modules:append:class-target = " ${MLPREFIX}python3-misc"
410RDEPENDS:${PN}-modules:append:class-nativesdk = " ${MLPREFIX}python3-misc"
411FILES:${PN}-misc = "${libdir}/python${PYTHON_MAJMIN} ${libdir}/python${PYTHON_MAJMIN}/lib-dynload"
412
413# catch manpage
414PACKAGES += "${PN}-man"
415FILES:${PN}-man = "${datadir}/man"
416
417# See https://bugs.python.org/issue18748 and https://bugs.python.org/issue37395
418RDEPENDS:libpython3:append:libc-glibc = " libgcc"
419RDEPENDS:${PN}-ctypes:append:libc-glibc = " ${MLPREFIX}ldconfig"
420RDEPENDS:${PN}-ptest = "${PN}-modules ${PN}-tests ${PN}-dev unzip bzip2 libgcc tzdata-europe coreutils sed"
421RDEPENDS:${PN}-ptest:append:libc-glibc = " locale-base-tr-tr.iso-8859-9"
422RDEPENDS:${PN}-tkinter += "${@bb.utils.contains('PACKAGECONFIG', 'tk', '${MLPREFIX}tk ${MLPREFIX}tk-lib', '', d)}"
423RDEPENDS:${PN}-idle += "${@bb.utils.contains('PACKAGECONFIG', 'tk', '${PN}-tkinter ${MLPREFIX}tcl', '', d)}"
424RDEPENDS:${PN}-dev = ""
425RDEPENDS:${PN}-pydoc += "${PN}-io"
426
427RDEPENDS:${PN}-tests:append:class-target = " ${MLPREFIX}bash"
428RDEPENDS:${PN}-tests:append:class-nativesdk = " ${MLPREFIX}bash"
429
430# Python's tests contain large numbers of files we don't need in the recipe sysroots
431SYSROOT_PREPROCESS_FUNCS += " py3_sysroot_cleanup"
432py3_sysroot_cleanup () {
433 rm -rf ${SYSROOT_DESTDIR}${libdir}/python${PYTHON_MAJMIN}/test
434}