diff options
| -rw-r--r-- | meta/recipes-multimedia/webp/files/CVE-2023-1999.patch | 55 | ||||
| -rw-r--r-- | meta/recipes-multimedia/webp/libwebp_1.3.1.bb (renamed from meta/recipes-multimedia/webp/libwebp_1.3.0.bb) | 6 |
2 files changed, 1 insertions, 60 deletions
diff --git a/meta/recipes-multimedia/webp/files/CVE-2023-1999.patch b/meta/recipes-multimedia/webp/files/CVE-2023-1999.patch deleted file mode 100644 index d293ab93ab..0000000000 --- a/meta/recipes-multimedia/webp/files/CVE-2023-1999.patch +++ /dev/null | |||
| @@ -1,55 +0,0 @@ | |||
| 1 | From a486d800b60d0af4cc0836bf7ed8f21e12974129 Mon Sep 17 00:00:00 2001 | ||
| 2 | From: James Zern <jzern@google.com> | ||
| 3 | Date: Wed, 22 Feb 2023 22:15:47 -0800 | ||
| 4 | Subject: [PATCH] EncodeAlphaInternal: clear result->bw on error | ||
| 5 | |||
| 6 | This avoids a double free should the function fail prior to | ||
| 7 | VP8BitWriterInit() and a previous trial result's buffer carried over. | ||
| 8 | Previously in ApplyFiltersAndEncode() trial.bw (with a previous | ||
| 9 | iteration's buffer) would be freed, followed by best.bw pointing to the | ||
| 10 | same buffer. | ||
| 11 | |||
| 12 | Since: | ||
| 13 | 187d379d add a fallback to ALPHA_NO_COMPRESSION | ||
| 14 | |||
| 15 | In addition, check the return value of VP8BitWriterInit() in this | ||
| 16 | function. | ||
| 17 | |||
| 18 | Bug: webp:603 | ||
| 19 | Change-Id: Ic258381ee26c8c16bc211d157c8153831c8c6910 | ||
| 20 | |||
| 21 | CVE: CVE-2023-1999 | ||
| 22 | Upstream-Status: Backport [https://github.com/webmproject/libwebp/commit/a486d800b60d0af4cc0836bf7ed8f21e12974129] | ||
| 23 | Signed-off-by: Nikhil R <nikhil.r@kpit.com> | ||
| 24 | --- | ||
| 25 | src/enc/alpha_enc.c | 4 +++- | ||
| 26 | 1 file changed, 3 insertions(+), 1 deletion(-) | ||
| 27 | |||
| 28 | diff --git a/src/enc/alpha_enc.c b/src/enc/alpha_enc.c | ||
| 29 | index f7c02690e3..7d205586fe 100644 | ||
| 30 | --- a/src/enc/alpha_enc.c | ||
| 31 | +++ b/src/enc/alpha_enc.c | ||
| 32 | @@ -13,6 +13,7 @@ | ||
| 33 | |||
| 34 | #include <assert.h> | ||
| 35 | #include <stdlib.h> | ||
| 36 | +#include <string.h> | ||
| 37 | |||
| 38 | #include "src/enc/vp8i_enc.h" | ||
| 39 | #include "src/dsp/dsp.h" | ||
| 40 | @@ -148,6 +149,7 @@ static int EncodeAlphaInternal(const uint8_t* const data, int width, int height, | ||
| 41 | } | ||
| 42 | } else { | ||
| 43 | VP8LBitWriterWipeOut(&tmp_bw); | ||
| 44 | + memset(&result->bw, 0, sizeof(result->bw)); | ||
| 45 | return 0; | ||
| 46 | } | ||
| 47 | } | ||
| 48 | @@ -162,7 +164,7 @@ static int EncodeAlphaInternal(const uint8_t* const data, int width, int height, | ||
| 49 | header = method | (filter << 2); | ||
| 50 | if (reduce_levels) header |= ALPHA_PREPROCESSED_LEVELS << 4; | ||
| 51 | |||
| 52 | - VP8BitWriterInit(&result->bw, ALPHA_HEADER_LEN + output_size); | ||
| 53 | + if (!VP8BitWriterInit(&result->bw, ALPHA_HEADER_LEN + output_size)) ok = 0; | ||
| 54 | ok = ok && VP8BitWriterAppend(&result->bw, &header, ALPHA_HEADER_LEN); | ||
| 55 | ok = ok && VP8BitWriterAppend(&result->bw, output, output_size); | ||
diff --git a/meta/recipes-multimedia/webp/libwebp_1.3.0.bb b/meta/recipes-multimedia/webp/libwebp_1.3.1.bb index 58a91d5077..0a345498c1 100644 --- a/meta/recipes-multimedia/webp/libwebp_1.3.0.bb +++ b/meta/recipes-multimedia/webp/libwebp_1.3.1.bb | |||
| @@ -14,14 +14,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=6e8dee932c26f2dab503abf70c96d8bb \ | |||
| 14 | file://PATENTS;md5=c6926d0cb07d296f886ab6e0cc5a85b7" | 14 | file://PATENTS;md5=c6926d0cb07d296f886ab6e0cc5a85b7" |
| 15 | 15 | ||
| 16 | SRC_URI = "http://downloads.webmproject.org/releases/webp/${BP}.tar.gz" | 16 | SRC_URI = "http://downloads.webmproject.org/releases/webp/${BP}.tar.gz" |
| 17 | SRC_URI[sha256sum] = "64ac4614db292ae8c5aa26de0295bf1623dbb3985054cb656c55e67431def17c" | 17 | SRC_URI[sha256sum] = "b3779627c2dfd31e3d8c4485962c2efe17785ef975e2be5c8c0c9e6cd3c4ef66" |
| 18 | 18 | ||
| 19 | UPSTREAM_CHECK_URI = "http://downloads.webmproject.org/releases/webp/index.html" | 19 | UPSTREAM_CHECK_URI = "http://downloads.webmproject.org/releases/webp/index.html" |
| 20 | 20 | ||
| 21 | SRC_URI += " \ | ||
| 22 | file://CVE-2023-1999.patch \ | ||
| 23 | " | ||
| 24 | |||
| 25 | EXTRA_OECONF = " \ | 21 | EXTRA_OECONF = " \ |
| 26 | --disable-wic \ | 22 | --disable-wic \ |
| 27 | --enable-libwebpmux \ | 23 | --enable-libwebpmux \ |
