summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--bitbake/lib/bb/siggen.py2
-rw-r--r--bitbake/lib/bb/utils.py21
2 files changed, 22 insertions, 1 deletions
diff --git a/bitbake/lib/bb/siggen.py b/bitbake/lib/bb/siggen.py
index 9fa568f614..bd6fc204fa 100644
--- a/bitbake/lib/bb/siggen.py
+++ b/bitbake/lib/bb/siggen.py
@@ -419,7 +419,7 @@ class SignatureGeneratorBasic(SignatureGenerator):
419 bb.error("Taskhash mismatch %s versus %s for %s" % (computed_taskhash, self.taskhash[tid], tid)) 419 bb.error("Taskhash mismatch %s versus %s for %s" % (computed_taskhash, self.taskhash[tid], tid))
420 sigfile = sigfile.replace(self.taskhash[tid], computed_taskhash) 420 sigfile = sigfile.replace(self.taskhash[tid], computed_taskhash)
421 421
422 fd, tmpfile = tempfile.mkstemp(dir=os.path.dirname(sigfile), prefix="sigtask.") 422 fd, tmpfile = bb.utils.mkstemp(dir=os.path.dirname(sigfile), prefix="sigtask.")
423 try: 423 try:
424 with bb.compress.zstd.open(fd, "wt", encoding="utf-8", num_threads=1) as f: 424 with bb.compress.zstd.open(fd, "wt", encoding="utf-8", num_threads=1) as f:
425 json.dump(data, f, sort_keys=True, separators=(",", ":"), cls=SetEncoder) 425 json.dump(data, f, sort_keys=True, separators=(",", ":"), cls=SetEncoder)
diff --git a/bitbake/lib/bb/utils.py b/bitbake/lib/bb/utils.py
index 95b3c89805..92d44c5260 100644
--- a/bitbake/lib/bb/utils.py
+++ b/bitbake/lib/bb/utils.py
@@ -28,6 +28,8 @@ import signal
28import collections 28import collections
29import copy 29import copy
30import ctypes 30import ctypes
31import random
32import tempfile
31from subprocess import getstatusoutput 33from subprocess import getstatusoutput
32from contextlib import contextmanager 34from contextlib import contextmanager
33from ctypes import cdll 35from ctypes import cdll
@@ -1756,3 +1758,22 @@ def is_local_uid(uid=''):
1756 if str(uid) == line_split[2]: 1758 if str(uid) == line_split[2]:
1757 return True 1759 return True
1758 return False 1760 return False
1761
1762def mkstemp(suffix=None, prefix=None, dir=None, text=False):
1763 """
1764 Generates a unique filename, independent of time.
1765
1766 mkstemp() in glibc (at least) generates unique file names based on the
1767 current system time. When combined with highly parallel builds, and
1768 operating over NFS (e.g. shared sstate/downloads) this can result in
1769 conflicts and race conditions.
1770
1771 This function adds additional entropy to the file name so that a collision
1772 is independent of time and thus extremely unlikely.
1773 """
1774 entropy = "".join(random.choices("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890", k=20))
1775 if prefix:
1776 prefix = prefix + entropy
1777 else:
1778 prefix = tempfile.gettempprefix() + entropy
1779 return tempfile.mkstemp(suffix=suffix, prefix=prefix, dir=dir, text=text)