diff options
4 files changed, 32 insertions, 51 deletions
diff --git a/meta/recipes-graphics/vulkan/vulkan-samples/0001-framework-Include-stdint.h.patch b/meta/recipes-graphics/vulkan/vulkan-samples/0001-framework-Include-stdint.h.patch index 8d323f2cef..b30b0e0017 100644 --- a/meta/recipes-graphics/vulkan/vulkan-samples/0001-framework-Include-stdint.h.patch +++ b/meta/recipes-graphics/vulkan/vulkan-samples/0001-framework-Include-stdint.h.patch | |||
| @@ -1,4 +1,4 @@ | |||
| 1 | From 445fcfd7b9245881d769880a5942ce9faa893045 Mon Sep 17 00:00:00 2001 | 1 | From 9a187d2f54d3683636b951a10c165d949b3a1d18 Mon Sep 17 00:00:00 2001 |
| 2 | From: Khem Raj <raj.khem@gmail.com> | 2 | From: Khem Raj <raj.khem@gmail.com> |
| 3 | Date: Sun, 23 Mar 2025 20:09:35 -0700 | 3 | Date: Sun, 23 Mar 2025 20:09:35 -0700 |
| 4 | Subject: [PATCH] framework: Include stdint.h | 4 | Subject: [PATCH] framework: Include stdint.h |
diff --git a/meta/recipes-graphics/vulkan/vulkan-samples/0001-vulkan-samples-Fix-reproducibility-issue.patch b/meta/recipes-graphics/vulkan/vulkan-samples/0001-vulkan-samples-Fix-reproducibility-issue.patch deleted file mode 100644 index c16e05112f..0000000000 --- a/meta/recipes-graphics/vulkan/vulkan-samples/0001-vulkan-samples-Fix-reproducibility-issue.patch +++ /dev/null | |||
| @@ -1,43 +0,0 @@ | |||
| 1 | From d998c753254649c7cf7c64e3fed78e41c11ad7ed Mon Sep 17 00:00:00 2001 | ||
| 2 | From: Richard Purdie <richard.purdie@linuxfoundation.org> | ||
| 3 | Date: Wed, 23 Aug 2023 09:38:37 +0200 | ||
| 4 | Subject: [PATCH] vulkan-samples: Fix reproducibility issue | ||
| 5 | |||
| 6 | There is code to remove the prefix CMAKE_SOURCE_DIR from __FILENAME__ paths | ||
| 7 | used for logging with LOGE() in the code. We need to make this match the value we use | ||
| 8 | in the debug source remapping from CFLAGS | ||
| 9 | |||
| 10 | We export the right path to use in the recipe with: | ||
| 11 | |||
| 12 | EXTRA_OECMAKE = "-DCMAKE_DEBUG_SRCDIR=${TARGET_DBGSRC_DIR}/" | ||
| 13 | |||
| 14 | and we then patch this into the code instead of the broken use | ||
| 15 | of CMAKE_SOURCE_DIR since __FILENAME__ will match our path prefix | ||
| 16 | changes. | ||
| 17 | |||
| 18 | This also breaks reproducibility since the path length of the build directory | ||
| 19 | will currently change the output! | ||
| 20 | |||
| 21 | Upstream-Status: Pending [needs to be discussed upstream] | ||
| 22 | Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> | ||
| 23 | |||
| 24 | Signed-off-by: Julien Stephan <jstephan@baylibre.com> | ||
| 25 | --- | ||
| 26 | bldsys/cmake/global_options.cmake | 2 +- | ||
| 27 | 1 file changed, 1 insertion(+), 1 deletion(-) | ||
| 28 | |||
| 29 | diff --git a/bldsys/cmake/global_options.cmake b/bldsys/cmake/global_options.cmake | ||
| 30 | index b15c2da..d8952e5 100644 | ||
| 31 | --- a/bldsys/cmake/global_options.cmake | ||
| 32 | +++ b/bldsys/cmake/global_options.cmake | ||
| 33 | @@ -62,7 +62,7 @@ set(CMAKE_CXX_STANDARD 14) | ||
| 34 | set(CMAKE_DISABLE_SOURCE_CHANGES ON) | ||
| 35 | set(CMAKE_DISABLE_IN_SOURCE_BUILD ON) | ||
| 36 | |||
| 37 | -string(LENGTH "${CMAKE_SOURCE_DIR}/" ROOT_PATH_SIZE) | ||
| 38 | +string(LENGTH "${CMAKE_DEBUG_SRCDIR}/" ROOT_PATH_SIZE) | ||
| 39 | add_definitions(-DROOT_PATH_SIZE=${ROOT_PATH_SIZE}) | ||
| 40 | |||
| 41 | set(CMAKE_C_FLAGS_DEBUG "-DDEBUG=0 ${CMAKE_C_FLAGS_DEBUG}") | ||
| 42 | -- | ||
| 43 | 2.41.0 | ||
diff --git a/meta/recipes-graphics/vulkan/vulkan-samples/0003-bldsys-cmake-global_options.cmake-removed-unused-ROO.patch b/meta/recipes-graphics/vulkan/vulkan-samples/0003-bldsys-cmake-global_options.cmake-removed-unused-ROO.patch new file mode 100644 index 0000000000..ffac2d78ce --- /dev/null +++ b/meta/recipes-graphics/vulkan/vulkan-samples/0003-bldsys-cmake-global_options.cmake-removed-unused-ROO.patch | |||
| @@ -0,0 +1,30 @@ | |||
| 1 | From da4ef211810bc3b0c51ea89f02c031a170fe0cb8 Mon Sep 17 00:00:00 2001 | ||
| 2 | From: Alexander Kanavin <alex@linutronix.de> | ||
| 3 | Date: Tue, 1 Apr 2025 18:53:34 +0200 | ||
| 4 | Subject: [PATCH] bldsys/cmake/global_options.cmake: removed unused | ||
| 5 | ROOT_PATH_SIZE define | ||
| 6 | |||
| 7 | After various refactorings it is no longer used anywhere (and | ||
| 8 | is problematic for build reproducibility, as build path sizes can | ||
| 9 | differ between build hosts). | ||
| 10 | |||
| 11 | Upstream-Status: Submitted [https://github.com/KhronosGroup/Vulkan-Samples/pull/1325] | ||
| 12 | Signed-off-by: Alexander Kanavin <alex@linutronix.de> | ||
| 13 | --- | ||
| 14 | bldsys/cmake/global_options.cmake | 3 --- | ||
| 15 | 1 file changed, 3 deletions(-) | ||
| 16 | |||
| 17 | diff --git a/bldsys/cmake/global_options.cmake b/bldsys/cmake/global_options.cmake | ||
| 18 | index 96c7add..67a6c5e 100644 | ||
| 19 | --- a/bldsys/cmake/global_options.cmake | ||
| 20 | +++ b/bldsys/cmake/global_options.cmake | ||
| 21 | @@ -126,9 +126,6 @@ set(CMAKE_CXX_STANDARD 17) | ||
| 22 | set(CMAKE_DISABLE_SOURCE_CHANGES ON) | ||
| 23 | set(CMAKE_DISABLE_IN_SOURCE_BUILD ON) | ||
| 24 | |||
| 25 | -string(LENGTH "${CMAKE_SOURCE_DIR}/" ROOT_PATH_SIZE) | ||
| 26 | -add_definitions(-DROOT_PATH_SIZE=${ROOT_PATH_SIZE}) | ||
| 27 | - | ||
| 28 | set(CMAKE_C_FLAGS_DEBUG "-DDEBUG=0 ${CMAKE_C_FLAGS_DEBUG}") | ||
| 29 | set(CMAKE_CXX_FLAGS_DEBUG "-DDEBUG=0 ${CMAKE_CXX_FLAGS_DEBUG}") | ||
| 30 | |||
diff --git a/meta/recipes-graphics/vulkan/vulkan-samples_git.bb b/meta/recipes-graphics/vulkan/vulkan-samples_git.bb index 75174f6a91..554e6eb290 100644 --- a/meta/recipes-graphics/vulkan/vulkan-samples_git.bb +++ b/meta/recipes-graphics/vulkan/vulkan-samples_git.bb | |||
| @@ -6,9 +6,9 @@ LICENSE = "Apache-2.0" | |||
| 6 | LIC_FILES_CHKSUM = "file://LICENSE;md5=48aa35cefb768436223a6e7f18dc2a2a" | 6 | LIC_FILES_CHKSUM = "file://LICENSE;md5=48aa35cefb768436223a6e7f18dc2a2a" |
| 7 | 7 | ||
| 8 | SRC_URI = "gitsm://github.com/KhronosGroup/Vulkan-Samples.git;branch=main;protocol=https;lfs=0 \ | 8 | SRC_URI = "gitsm://github.com/KhronosGroup/Vulkan-Samples.git;branch=main;protocol=https;lfs=0 \ |
| 9 | file://0001-vulkan-samples-Fix-reproducibility-issue.patch \ | ||
| 10 | file://0001-SPIRV-SpvBuilder.h-add-missing-cstdint-include.patch;patchdir=third_party/glslang \ | 9 | file://0001-SPIRV-SpvBuilder.h-add-missing-cstdint-include.patch;patchdir=third_party/glslang \ |
| 11 | file://0001-framework-Include-stdint.h.patch \ | 10 | file://0001-framework-Include-stdint.h.patch \ |
| 11 | file://0003-bldsys-cmake-global_options.cmake-removed-unused-ROO.patch \ | ||
| 12 | " | 12 | " |
| 13 | 13 | ||
| 14 | UPSTREAM_CHECK_COMMITS = "1" | 14 | UPSTREAM_CHECK_COMMITS = "1" |
| @@ -25,12 +25,6 @@ inherit cmake features_check | |||
| 25 | 25 | ||
| 26 | FILES:${PN} += "${datadir}" | 26 | FILES:${PN} += "${datadir}" |
| 27 | 27 | ||
| 28 | # | ||
| 29 | # There is code to remove the prefix CMAKE_SOURCE_DIR from __FILENAME__ paths | ||
| 30 | # used for logging with LOGE in the code. We need to make this match the value we use | ||
| 31 | # in the debug source remapping from CFLAGS | ||
| 32 | # | ||
| 33 | EXTRA_OECMAKE += "-DCMAKE_DEBUG_SRCDIR=${TARGET_DBGSRC_DIR}/" | ||
| 34 | # Binaries built with PCH enabled don't appear reproducible, differing results were seen | 28 | # Binaries built with PCH enabled don't appear reproducible, differing results were seen |
| 35 | # from some builds depending on the point the PCH was compiled. Disable it to be | 29 | # from some builds depending on the point the PCH was compiled. Disable it to be |
| 36 | # deterministic | 30 | # deterministic |
