diff options
author | Trevor Gamblin <tgamblin@baylibre.com> | 2023-10-12 09:24:58 -0400 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2023-10-13 11:53:06 +0100 |
commit | 2fdabc368a52a9bf60f76f33e92b94de843688a8 (patch) | |
tree | 1a9ab2e980cc66a656692bf4b450dd0b3156d6a0 /meta/lib/patchtest/tests/test_mbox_description.py | |
parent | 575b00dca5a9ae15b0eec7c8eea3c415c2a37bc1 (diff) | |
download | poky-2fdabc368a52a9bf60f76f33e92b94de843688a8.tar.gz |
patchtest: improve test issue messages
The patchtest tests provide vague feedback to the user, and many of them
also provide redundant 'fix' strings that could easily be incorporated
into the issue messages themselves. Simplify them so that it is more
clear what the errors are and how they can be addressed. No
recommendation is given when the issue string adequately conveys the
issue, e.g. with a missing "LICENSE" entry in a newly-created recipe.
(From OE-Core rev: 0bfb3614244ec7aa79b6424bc63f9f2bccdabe98)
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/lib/patchtest/tests/test_mbox_description.py')
-rw-r--r-- | meta/lib/patchtest/tests/test_mbox_description.py | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/meta/lib/patchtest/tests/test_mbox_description.py b/meta/lib/patchtest/tests/test_mbox_description.py index 7addc6b5f7..46bedd46ce 100644 --- a/meta/lib/patchtest/tests/test_mbox_description.py +++ b/meta/lib/patchtest/tests/test_mbox_description.py | |||
@@ -11,7 +11,5 @@ class CommitMessage(base.Base): | |||
11 | def test_commit_message_presence(self): | 11 | def test_commit_message_presence(self): |
12 | for commit in CommitMessage.commits: | 12 | for commit in CommitMessage.commits: |
13 | if not commit.commit_message.strip(): | 13 | if not commit.commit_message.strip(): |
14 | self.fail('Patch is missing a descriptive commit message', | 14 | self.fail('Mbox is missing a descriptive commit message. Please include a commit message on your patch explaining the change', commit=commit) |
15 | 'Please include a commit message on your patch explaining the change (most importantly why the change is being made)', | ||
16 | commit) | ||
17 | 15 | ||