diff options
author | Trevor Gamblin <tgamblin@baylibre.com> | 2023-10-12 09:24:58 -0400 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2023-10-13 11:53:06 +0100 |
commit | 2fdabc368a52a9bf60f76f33e92b94de843688a8 (patch) | |
tree | 1a9ab2e980cc66a656692bf4b450dd0b3156d6a0 /meta/lib/patchtest/tests/test_mbox_author.py | |
parent | 575b00dca5a9ae15b0eec7c8eea3c415c2a37bc1 (diff) | |
download | poky-2fdabc368a52a9bf60f76f33e92b94de843688a8.tar.gz |
patchtest: improve test issue messages
The patchtest tests provide vague feedback to the user, and many of them
also provide redundant 'fix' strings that could easily be incorporated
into the issue messages themselves. Simplify them so that it is more
clear what the errors are and how they can be addressed. No
recommendation is given when the issue string adequately conveys the
issue, e.g. with a missing "LICENSE" entry in a newly-created recipe.
(From OE-Core rev: 0bfb3614244ec7aa79b6424bc63f9f2bccdabe98)
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/lib/patchtest/tests/test_mbox_author.py')
-rw-r--r-- | meta/lib/patchtest/tests/test_mbox_author.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/meta/lib/patchtest/tests/test_mbox_author.py b/meta/lib/patchtest/tests/test_mbox_author.py index 6c79f164d4..fb8f10e1fd 100644 --- a/meta/lib/patchtest/tests/test_mbox_author.py +++ b/meta/lib/patchtest/tests/test_mbox_author.py | |||
@@ -21,9 +21,9 @@ class Author(base.Base): | |||
21 | for commit in self.commits: | 21 | for commit in self.commits: |
22 | for invalid in self.invalids: | 22 | for invalid in self.invalids: |
23 | if invalid.search(commit.author): | 23 | if invalid.search(commit.author): |
24 | self.fail('Invalid author %s' % commit.author, 'Resend the series with a valid patch\'s author', commit) | 24 | self.fail('Invalid author %s. Resend the series with a valid patch author' % commit.author, commit=commit) |
25 | 25 | ||
26 | def test_non_auh_upgrade(self): | 26 | def test_non_auh_upgrade(self): |
27 | for commit in self.commits: | 27 | for commit in self.commits: |
28 | if self.auh_email in commit.payload: | 28 | if self.auh_email in commit.payload: |
29 | self.fail('Invalid author %s in commit message' % self.auh_email, 'Resend the series with a valid patch\'s author', commit) | 29 | self.fail('Invalid author %s. Resend the series with a valid patch author' % self.auh_email, commit=commit) |