diff options
| author | Trevor Woerner <twoerner@gmail.com> | 2025-05-02 13:21:43 -0400 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2025-05-19 15:54:10 +0100 |
| commit | e216e39c7e9e220fd81b8c506566d861c9ce5e60 (patch) | |
| tree | e86d181edbfbc2f138be7a2e105bc3a98d96f500 /documentation | |
| parent | e681870441ee85edb13f99aaf4eb22bd53c939e1 (diff) | |
| download | poky-e216e39c7e9e220fd81b8c506566d861c9ce5e60.tar.gz | |
contributor-guide/submit-changes: encourage patch version changelogs
Add a section after the 'git format-patch' information encouraging developers
to add patch version changelogs to their patch updates.
(From yocto-docs rev: 2e3a37c4607b296956993e557d1786c4876e5722)
Signed-off-by: Trevor Woerner <twoerner@gmail.com>
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Signed-off-by: Antonin Godard <antonin.godard@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'documentation')
| -rw-r--r-- | documentation/contributor-guide/submit-changes.rst | 32 |
1 files changed, 32 insertions, 0 deletions
diff --git a/documentation/contributor-guide/submit-changes.rst b/documentation/contributor-guide/submit-changes.rst index 0675aac984..6d5d69d7cf 100644 --- a/documentation/contributor-guide/submit-changes.rst +++ b/documentation/contributor-guide/submit-changes.rst | |||
| @@ -776,6 +776,38 @@ argument to ``git format-patch`` with a version number:: | |||
| 776 | 776 | ||
| 777 | git format-patch -v2 <ref-branch> | 777 | git format-patch -v2 <ref-branch> |
| 778 | 778 | ||
| 779 | |||
| 780 | After generating updated patches (v2, v3, and so on) via ``git | ||
| 781 | format-patch``, ideally developers will add a patch version changelog | ||
| 782 | to each patch that describes what has changed between each revision of | ||
| 783 | the patch. Add patch version changelogs after the ``---`` marker in the | ||
| 784 | patch, indicating that this information is part of this patch, but is not | ||
| 785 | suitable for inclusion in the commit message (i.e. the git history) itself. | ||
| 786 | Providing a patch version changelog makes it easier for maintainers and | ||
| 787 | reviewers to succinctly understand what changed in all versions of the | ||
| 788 | patch, without having to consult alternate sources of information, such as | ||
| 789 | searching through messages on a mailing list. For example:: | ||
| 790 | |||
| 791 | <patch title> | ||
| 792 | |||
| 793 | <commit message> | ||
| 794 | |||
| 795 | <Signed-off-by/other trailers> | ||
| 796 | --- | ||
| 797 | changes in v4: | ||
| 798 | - provide a clearer commit message | ||
| 799 | - fix spelling mistakes | ||
| 800 | |||
| 801 | changes in v3: | ||
| 802 | - replace func() to use other_func() instead | ||
| 803 | |||
| 804 | changes in v2: | ||
| 805 | - this patch was added in v2 | ||
| 806 | --- | ||
| 807 | <diffstat output> | ||
| 808 | |||
| 809 | <unified diff> | ||
| 810 | |||
| 779 | Lastly please ensure that you also test your revised changes. In particular | 811 | Lastly please ensure that you also test your revised changes. In particular |
| 780 | please don't just edit the patch file written out by ``git format-patch`` and | 812 | please don't just edit the patch file written out by ``git format-patch`` and |
| 781 | resend it. | 813 | resend it. |
