summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMartin Jansa <Martin.Jansa@gmail.com>2023-05-24 09:53:15 +0200
committerSteve Sakoman <steve@sakoman.com>2023-06-21 06:50:51 -1000
commitf1df897c626a4b2d8c258b71edc887e2e0a15018 (patch)
tree6934b819a75a4acd3003b1c2f8e0b76f49208ee9
parentd878b48ed869ebda4f08b15f0d7132db63707292 (diff)
downloadpoky-f1df897c626a4b2d8c258b71edc887e2e0a15018.tar.gz
libx11: remove unused patch and FILESEXTRAPATHS
* 0001-fix-a-memory-leak-in-XRegisterIMInstantiateCallback.patch was removed from SRC_URI in: https://git.openembedded.org/openembedded-core/commit/?id=e13f651f73db0f26f4645447ab5fa17e36d1903b (From OE-Core rev: b6ce931656c29e11ea65023ae6077a2870309020) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit ee37d9f05c047e1dd68e0cb47b809240d2f33835) Signed-off-by: Steve Sakoman <steve@sakoman.com>
-rw-r--r--meta/recipes-graphics/xorg-lib/libx11/0001-fix-a-memory-leak-in-XRegisterIMInstantiateCallback.patch57
-rw-r--r--meta/recipes-graphics/xorg-lib/libx11_1.8.4.bb6
2 files changed, 2 insertions, 61 deletions
diff --git a/meta/recipes-graphics/xorg-lib/libx11/0001-fix-a-memory-leak-in-XRegisterIMInstantiateCallback.patch b/meta/recipes-graphics/xorg-lib/libx11/0001-fix-a-memory-leak-in-XRegisterIMInstantiateCallback.patch
deleted file mode 100644
index 722116c07e..0000000000
--- a/meta/recipes-graphics/xorg-lib/libx11/0001-fix-a-memory-leak-in-XRegisterIMInstantiateCallback.patch
+++ /dev/null
@@ -1,57 +0,0 @@
1CVE: CVE-2022-3554
2Upstream-Status: Backport
3Signed-off-by: Ross Burton <ross.burton@arm.com>
4
5From 1d11822601fd24a396b354fa616b04ed3df8b4ef Mon Sep 17 00:00:00 2001
6From: "Thomas E. Dickey" <dickey@invisible-island.net>
7Date: Tue, 4 Oct 2022 18:26:17 -0400
8Subject: [PATCH] fix a memory leak in XRegisterIMInstantiateCallback
9
10Analysis:
11
12 _XimRegisterIMInstantiateCallback() opens an XIM and closes it using
13 the internal function pointers, but the internal close function does
14 not free the pointer to the XIM (this would be done in XCloseIM()).
15
16Report/patch:
17
18 Date: Mon, 03 Oct 2022 18:47:32 +0800
19 From: Po Lu <luangruo@yahoo.com>
20 To: xorg-devel@lists.x.org
21 Subject: Re: Yet another leak in Xlib
22
23 For reference, here's how I'm calling XRegisterIMInstantiateCallback:
24
25 XSetLocaleModifiers ("");
26 XRegisterIMInstantiateCallback (compositor.display,
27 XrmGetDatabase (compositor.display),
28 (char *) compositor.resource_name,
29 (char *) compositor.app_name,
30 IMInstantiateCallback, NULL);
31
32 and XMODIFIERS is:
33
34 @im=ibus
35
36Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
37---
38 modules/im/ximcp/imInsClbk.c | 3 +++
39 1 file changed, 3 insertions(+)
40
41diff --git a/modules/im/ximcp/imInsClbk.c b/modules/im/ximcp/imInsClbk.c
42index 95b379cb..c10e347f 100644
43--- a/modules/im/ximcp/imInsClbk.c
44+++ b/modules/im/ximcp/imInsClbk.c
45@@ -212,6 +212,9 @@ _XimRegisterIMInstantiateCallback(
46 if( xim ) {
47 lock = True;
48 xim->methods->close( (XIM)xim );
49+ /* XIMs must be freed manually after being opened; close just
50+ does the protocol to deinitialize the IM. */
51+ XFree( xim );
52 lock = False;
53 icb->call = True;
54 callback( display, client_data, NULL );
55--
562.34.1
57
diff --git a/meta/recipes-graphics/xorg-lib/libx11_1.8.4.bb b/meta/recipes-graphics/xorg-lib/libx11_1.8.4.bb
index 7831b4986a..9058c1844e 100644
--- a/meta/recipes-graphics/xorg-lib/libx11_1.8.4.bb
+++ b/meta/recipes-graphics/xorg-lib/libx11_1.8.4.bb
@@ -18,14 +18,12 @@ DEPENDS += "xorgproto \
18 18
19PROVIDES = "virtual/libx11" 19PROVIDES = "virtual/libx11"
20 20
21FILESEXTRAPATHS =. "${FILE_DIRNAME}/libx11:"
22
23PE = "1" 21PE = "1"
24 22
25XORG_PN = "libX11" 23XORG_PN = "libX11"
26 24
27SRC_URI += "file://disable_tests.patch \ 25SRC_URI += "file://disable_tests.patch"
28 " 26
29SRC_URI[sha256sum] = "c9a287a5aefa9804ce3cfafcf516fe96ed3f7e8e45c0e2ee59e84c86757df518" 27SRC_URI[sha256sum] = "c9a287a5aefa9804ce3cfafcf516fe96ed3f7e8e45c0e2ee59e84c86757df518"
30 28
31inherit gettext 29inherit gettext