summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMauro Queiros <maurofrqueiros@gmail.com>2023-02-07 22:37:04 +0000
committerRichard Purdie <richard.purdie@linuxfoundation.org>2023-02-24 16:41:46 +0000
commiteba3bebee0f7c9ad9bd68a976d8fca1b777b7a91 (patch)
tree00a542e7cf19fafe213164f8909ac838b2eff35f
parent3ad697337df9eaad9d774bdf211b6f40e1cf13e7 (diff)
downloadpoky-eba3bebee0f7c9ad9bd68a976d8fca1b777b7a91.tar.gz
image.bbclass: print all QA functions exceptions
For the QA checks in `image.bbclass`, all exceptions other than `oe.utils.ImageQAFailed` always print the following generic message: "Image QA function func_name failed" This can be very misleading, as it may hide python syntax errors and other kind of issues that are hard to detect without more explicit error messages. This change makes sure that the error message of all exceptions are displayed. Before this change: "Image QA function func_name failed" After this change: "Image QA function func_name failed: f-string: empty expression not allowed (<string>, line 13)" (From OE-Core rev: 6c53d8d8c88fb06b19fbf5bdd754960b21531074) Signed-off-by: Mauro Queiros <maurofrqueiros@gmail.com> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 3d85b30d8704d38b86f5b006748cebc74bd2a4fa) Signed-off-by: Steve Sakoman <steve@sakoman.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--meta/classes/image.bbclass2
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index aa14ea2316..00413d56d1 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -313,7 +313,7 @@ fakeroot python do_image_qa () {
313 except oe.utils.ImageQAFailed as e: 313 except oe.utils.ImageQAFailed as e:
314 qamsg = qamsg + '\tImage QA function %s failed: %s\n' % (e.name, e.description) 314 qamsg = qamsg + '\tImage QA function %s failed: %s\n' % (e.name, e.description)
315 except Exception as e: 315 except Exception as e:
316 qamsg = qamsg + '\tImage QA function %s failed\n' % cmd 316 qamsg = qamsg + '\tImage QA function %s failed: %s\n' % (cmd, e)
317 317
318 if qamsg: 318 if qamsg:
319 imgname = d.getVar('IMAGE_NAME') 319 imgname = d.getVar('IMAGE_NAME')