summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKhem Raj <raj.khem@gmail.com>2025-06-03 09:11:35 -0700
committerRichard Purdie <richard.purdie@linuxfoundation.org>2025-07-01 08:49:37 +0100
commite065efc71d5f0c6cfd9a666c019db84b12f9b16d (patch)
treedd90725dbeab6e1f70800b62656c674d420eceb3
parent58b0a65ada340fda3bc04fa9fcb648eb43246402 (diff)
downloadpoky-e065efc71d5f0c6cfd9a666c019db84b12f9b16d.tar.gz
tcf-agent: Add $@ to RANLIB
tcf-agent calls RANLIB ( if defined ) after calling AR to create the archive [1], when RANLIB is set to gcc-ranlib this goes unnoticed, since calling gcc-ranlib without any arguments silenlty does nothing and exits with return code 0, however, calling binutils ranlib or llvm-ranlib does demand library name as commandline option and since it is not there it exits with code 1 aarch64-poky-linux-musl-llvm-ranlib OVERVIEW: LLVM ranlib Generate an index for archives USAGE: aarch64-poky-linux-musl-llvm-ranlib archive... OPTIONS: -h --help - Display available options -V --version - Display the version of this program -D - Use zero for timestamps and uids/gids (default) -U - Use actual timestamps and uids/gids -X{32|64|32_64|any} - Specify which archive symbol tables should be generated if they do not already exist (AIX OS only) aarch64-poky-linux-musl-llvm-ranlib: error: an archive name must be specified make: *** [Makefile:53: obj/GNU/Linux/a64/Debug/libtcf.a] Error 1 When we add $@, to RANLIB then it becomes the make variable, $@ - An automatic Makefile variable that expands to the target name (the file being built) so the makefile target now rightly adds the .a filename to RANLIB call. Sent a patch upstream to add RANLIB for linux [2] [1] https://gitlab.eclipse.org/eclipse/tcf/tcf.agent/-/blob/master/agent/Makefile?ref_type=heads#L53 [2] https://gitlab.eclipse.org/eclipse/tcf/tcf.agent/-/merge_requests/7 (From OE-Core rev: ee2df4554804cc08906cf7b5c734b234c7913c5f) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--meta/recipes-devtools/tcf-agent/tcf-agent_1.8.0.bb6
1 files changed, 6 insertions, 0 deletions
diff --git a/meta/recipes-devtools/tcf-agent/tcf-agent_1.8.0.bb b/meta/recipes-devtools/tcf-agent/tcf-agent_1.8.0.bb
index 1639ae84e9..f008c0c6de 100644
--- a/meta/recipes-devtools/tcf-agent/tcf-agent_1.8.0.bb
+++ b/meta/recipes-devtools/tcf-agent/tcf-agent_1.8.0.bb
@@ -49,6 +49,12 @@ CFLAGS:append:riscv64 = " ${LCL_STOP_SERVICES}"
49CFLAGS:append:riscv32 = " ${LCL_STOP_SERVICES}" 49CFLAGS:append:riscv32 = " ${LCL_STOP_SERVICES}"
50CFLAGS:append:loongarch64 = " ${LCL_STOP_SERVICES}" 50CFLAGS:append:loongarch64 = " ${LCL_STOP_SERVICES}"
51 51
52# This works with gcc-ranlib wrapper only because it exists without error if nothing
53# is passed as argument but binutils ranlib and llvm ranlib do not and expect an input
54# passing $@ ensures that Makefile default target which is the archive name in tcf makefiles
55# is passed to RANLIB, ensures that whichever ranlib is used, the behavior is identical
56RANLIB:append = " $@"
57
52do_install() { 58do_install() {
53 oe_runmake install INSTALLROOT=${D} 59 oe_runmake install INSTALLROOT=${D}
54 install -d ${D}${sysconfdir}/init.d/ 60 install -d ${D}${sysconfdir}/init.d/