diff options
| author | Robert Yang <liezhi.yang@windriver.com> | 2011-11-30 17:23:50 +0800 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2011-12-05 16:15:46 +0000 |
| commit | dccb9b9fe826948e2d90a97b31998c31b114bed2 (patch) | |
| tree | 72b6a5a1a26474ad6d79678f08cba26c40936a77 | |
| parent | 9be6d59b78510443d0944513503d515df13caa45 (diff) | |
| download | poky-dccb9b9fe826948e2d90a97b31998c31b114bed2.tar.gz | |
Remove the duplicated assignments of self.configuration.cmd
The assignments of self.configuration.cmd in BBCooker seems duplicated,
have the followings in both BBCooker::__init__ and
BBCooker::loadConfigurationData:
if not self.configuration.cmd:
self.configuration.cmd = self.configuration.data.getVar("BB_DEFAULT_TASK", True) or "build"
The __init__ invokes the loadConfigurationData, and it would make sure
that self.configuration.cmd has been assigned a proper value, so we can
remove the one in __init__.
[YOCTO #1791]
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | bitbake/lib/bb/cooker.py | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py index d1198d4496..15243f2194 100644 --- a/bitbake/lib/bb/cooker.py +++ b/bitbake/lib/bb/cooker.py | |||
| @@ -135,9 +135,6 @@ class BBCooker: | |||
| 135 | self.configuration.data = None | 135 | self.configuration.data = None |
| 136 | self.loadConfigurationData() | 136 | self.loadConfigurationData() |
| 137 | 137 | ||
| 138 | if not self.configuration.cmd: | ||
| 139 | self.configuration.cmd = self.configuration.data.getVar("BB_DEFAULT_TASK", True) or "build" | ||
| 140 | |||
| 141 | # Take a lock so only one copy of bitbake can run against a given build | 138 | # Take a lock so only one copy of bitbake can run against a given build |
| 142 | # directory at a time | 139 | # directory at a time |
| 143 | lockfile = self.configuration.data.expand("${TOPDIR}/bitbake.lock") | 140 | lockfile = self.configuration.data.expand("${TOPDIR}/bitbake.lock") |
