summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRichard Purdie <richard.purdie@linuxfoundation.org>2024-10-17 23:22:33 +0100
committerRichard Purdie <richard.purdie@linuxfoundation.org>2024-10-24 11:24:03 +0100
commitd230085ed9260d5968b680d7cf91a0c1c06043ed (patch)
treef16a3fd8f894292e7f8162a7228a7f4b52e7b989
parentd67b698be2da583441eed0e20b8e7a99d415c2ec (diff)
downloadpoky-d230085ed9260d5968b680d7cf91a0c1c06043ed.tar.gz
bitbake: toaster/tests/browser: Drop unneeded poll parameters
In my testing I wasn't able to see issues needing the poll parameter in the browser tests. Drop those. (Bitbake rev: 3be5e7c78129abf059476416279718156fc666b5) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--bitbake/lib/toaster/tests/browser/test_all_builds_page.py6
-rw-r--r--bitbake/lib/toaster/tests/browser/test_all_projects_page.py12
-rw-r--r--bitbake/lib/toaster/tests/browser/test_builddashboard_page.py2
-rw-r--r--bitbake/lib/toaster/tests/browser/test_landing_page.py2
-rw-r--r--bitbake/lib/toaster/tests/browser/test_layerdetails_page.py8
-rw-r--r--bitbake/lib/toaster/tests/browser/test_new_custom_image_page.py2
-rw-r--r--bitbake/lib/toaster/tests/browser/test_new_project_page.py8
7 files changed, 20 insertions, 20 deletions
diff --git a/bitbake/lib/toaster/tests/browser/test_all_builds_page.py b/bitbake/lib/toaster/tests/browser/test_all_builds_page.py
index b9356a0344..a1f8057113 100644
--- a/bitbake/lib/toaster/tests/browser/test_all_builds_page.py
+++ b/bitbake/lib/toaster/tests/browser/test_all_builds_page.py
@@ -224,7 +224,7 @@ class TestAllBuildsPage(SeleniumTestCase):
224 224
225 url = reverse('all-builds') 225 url = reverse('all-builds')
226 self.get(url) 226 self.get(url)
227 self.wait_until_visible('#allbuildstable', poll=3) 227 self.wait_until_visible('#allbuildstable')
228 228
229 # get the project name cells from the table 229 # get the project name cells from the table
230 cells = self.find_all('#allbuildstable td[class="project"]') 230 cells = self.find_all('#allbuildstable td[class="project"]')
@@ -257,7 +257,7 @@ class TestAllBuildsPage(SeleniumTestCase):
257 257
258 url = reverse('all-builds') 258 url = reverse('all-builds')
259 self.get(url) 259 self.get(url)
260 self.wait_until_visible('#allbuildstable', poll=3) 260 self.wait_until_visible('#allbuildstable')
261 261
262 # test recent builds area for successful build 262 # test recent builds area for successful build
263 element = self._get_build_time_element(build1) 263 element = self._get_build_time_element(build1)
@@ -452,7 +452,7 @@ class TestAllBuildsPage(SeleniumTestCase):
452 def test_show_rows(row_to_show, show_row_link): 452 def test_show_rows(row_to_show, show_row_link):
453 # Check that we can show rows == row_to_show 453 # Check that we can show rows == row_to_show
454 show_row_link.select_by_value(str(row_to_show)) 454 show_row_link.select_by_value(str(row_to_show))
455 self.wait_until_visible('#allbuildstable tbody tr', poll=3) 455 self.wait_until_visible('#allbuildstable tbody tr')
456 # check at least some rows are visible 456 # check at least some rows are visible
457 self.assertTrue( 457 self.assertTrue(
458 len(self.find_all('#allbuildstable tbody tr')) > 0 458 len(self.find_all('#allbuildstable tbody tr')) > 0
diff --git a/bitbake/lib/toaster/tests/browser/test_all_projects_page.py b/bitbake/lib/toaster/tests/browser/test_all_projects_page.py
index 9ed1901cc9..05e12892be 100644
--- a/bitbake/lib/toaster/tests/browser/test_all_projects_page.py
+++ b/bitbake/lib/toaster/tests/browser/test_all_projects_page.py
@@ -81,7 +81,7 @@ class TestAllProjectsPage(SeleniumTestCase):
81 81
82 def _get_row_for_project(self, project_name): 82 def _get_row_for_project(self, project_name):
83 """ Get the HTML row for a project, or None if not found """ 83 """ Get the HTML row for a project, or None if not found """
84 self.wait_until_visible('#projectstable tbody tr', poll=3) 84 self.wait_until_visible('#projectstable tbody tr')
85 rows = self.find_all('#projectstable tbody tr') 85 rows = self.find_all('#projectstable tbody tr')
86 86
87 # find the row with a project name matching the one supplied 87 # find the row with a project name matching the one supplied
@@ -236,7 +236,7 @@ class TestAllProjectsPage(SeleniumTestCase):
236 self.get(url) 236 self.get(url)
237 237
238 # Chseck search box is present and works 238 # Chseck search box is present and works
239 self.wait_until_visible('#projectstable tbody tr', poll=3) 239 self.wait_until_visible('#projectstable tbody tr')
240 search_box = self.find('#search-input-projectstable') 240 search_box = self.find('#search-input-projectstable')
241 self.assertTrue(search_box.is_displayed()) 241 self.assertTrue(search_box.is_displayed())
242 242
@@ -244,7 +244,7 @@ class TestAllProjectsPage(SeleniumTestCase):
244 search_box.send_keys('test project 10') 244 search_box.send_keys('test project 10')
245 search_btn = self.find('#search-submit-projectstable') 245 search_btn = self.find('#search-submit-projectstable')
246 search_btn.click() 246 search_btn.click()
247 self.wait_until_visible('#projectstable tbody tr', poll=3) 247 self.wait_until_visible('#projectstable tbody tr')
248 rows = self.find_all('#projectstable tbody tr') 248 rows = self.find_all('#projectstable tbody tr')
249 self.assertTrue(len(rows) == 1) 249 self.assertTrue(len(rows) == 1)
250 250
@@ -290,7 +290,7 @@ class TestAllProjectsPage(SeleniumTestCase):
290 ) 290 )
291 url = reverse('all-projects') 291 url = reverse('all-projects')
292 self.get(url) 292 self.get(url)
293 self.wait_until_visible('#projectstable tbody tr', poll=3) 293 self.wait_until_visible('#projectstable tbody tr')
294 294
295 # Check edit column 295 # Check edit column
296 edit_column = self.find('#edit-columns-button') 296 edit_column = self.find('#edit-columns-button')
@@ -313,7 +313,7 @@ class TestAllProjectsPage(SeleniumTestCase):
313 def test_show_rows(row_to_show, show_row_link): 313 def test_show_rows(row_to_show, show_row_link):
314 # Check that we can show rows == row_to_show 314 # Check that we can show rows == row_to_show
315 show_row_link.select_by_value(str(row_to_show)) 315 show_row_link.select_by_value(str(row_to_show))
316 self.wait_until_visible('#projectstable tbody tr', poll=3) 316 self.wait_until_visible('#projectstable tbody tr')
317 # check at least some rows are visible 317 # check at least some rows are visible
318 self.assertTrue( 318 self.assertTrue(
319 len(self.find_all('#projectstable tbody tr')) > 0 319 len(self.find_all('#projectstable tbody tr')) > 0
@@ -321,7 +321,7 @@ class TestAllProjectsPage(SeleniumTestCase):
321 321
322 url = reverse('all-projects') 322 url = reverse('all-projects')
323 self.get(url) 323 self.get(url)
324 self.wait_until_visible('#projectstable tbody tr', poll=3) 324 self.wait_until_visible('#projectstable tbody tr')
325 325
326 show_rows = self.driver.find_elements( 326 show_rows = self.driver.find_elements(
327 By.XPATH, 327 By.XPATH,
diff --git a/bitbake/lib/toaster/tests/browser/test_builddashboard_page.py b/bitbake/lib/toaster/tests/browser/test_builddashboard_page.py
index d838ce363a..82367108e2 100644
--- a/bitbake/lib/toaster/tests/browser/test_builddashboard_page.py
+++ b/bitbake/lib/toaster/tests/browser/test_builddashboard_page.py
@@ -162,7 +162,7 @@ class TestBuildDashboardPage(SeleniumTestCase):
162 """ 162 """
163 url = reverse('builddashboard', args=(build.id,)) 163 url = reverse('builddashboard', args=(build.id,))
164 self.get(url) 164 self.get(url)
165 self.wait_until_visible('#global-nav', poll=3) 165 self.wait_until_visible('#global-nav')
166 166
167 def _get_build_dashboard_errors(self, build): 167 def _get_build_dashboard_errors(self, build):
168 """ 168 """
diff --git a/bitbake/lib/toaster/tests/browser/test_landing_page.py b/bitbake/lib/toaster/tests/browser/test_landing_page.py
index 62fdf83c91..f3300430ba 100644
--- a/bitbake/lib/toaster/tests/browser/test_landing_page.py
+++ b/bitbake/lib/toaster/tests/browser/test_landing_page.py
@@ -224,7 +224,7 @@ class TestLandingPage(SeleniumTestCase):
224 224
225 self.get(reverse('landing')) 225 self.get(reverse('landing'))
226 226
227 self.wait_until_visible("#latest-builds", poll=3) 227 self.wait_until_visible("#latest-builds")
228 elements = self.find_all('#allbuildstable') 228 elements = self.find_all('#allbuildstable')
229 self.assertEqual(len(elements), 1, 'should redirect to builds') 229 self.assertEqual(len(elements), 1, 'should redirect to builds')
230 content = self.get_page_source() 230 content = self.get_page_source()
diff --git a/bitbake/lib/toaster/tests/browser/test_layerdetails_page.py b/bitbake/lib/toaster/tests/browser/test_layerdetails_page.py
index 5c29548b78..c4f3f79d34 100644
--- a/bitbake/lib/toaster/tests/browser/test_layerdetails_page.py
+++ b/bitbake/lib/toaster/tests/browser/test_layerdetails_page.py
@@ -108,9 +108,9 @@ class TestLayerDetailsPage(SeleniumTestCase):
108 save_btn.click() 108 save_btn.click()
109 109
110 try: 110 try:
111 self.wait_until_visible("#save-changes-for-switch", poll=3) 111 self.wait_until_visible("#save-changes-for-switch")
112 btn_save_chg_for_switch = self.wait_until_clickable( 112 btn_save_chg_for_switch = self.wait_until_clickable(
113 "#save-changes-for-switch", poll=3) 113 "#save-changes-for-switch")
114 btn_save_chg_for_switch.click() 114 btn_save_chg_for_switch.click()
115 except ElementClickInterceptedException: 115 except ElementClickInterceptedException:
116 self.skipTest( 116 self.skipTest(
@@ -148,9 +148,9 @@ class TestLayerDetailsPage(SeleniumTestCase):
148 dir_input.send_keys(new_dir) 148 dir_input.send_keys(new_dir)
149 149
150 try: 150 try:
151 self.wait_until_visible("#save-changes-for-switch", poll=3) 151 self.wait_until_visible("#save-changes-for-switch")
152 btn_save_chg_for_switch = self.wait_until_clickable( 152 btn_save_chg_for_switch = self.wait_until_clickable(
153 "#save-changes-for-switch", poll=3) 153 "#save-changes-for-switch")
154 btn_save_chg_for_switch.click() 154 btn_save_chg_for_switch.click()
155 except ElementClickInterceptedException: 155 except ElementClickInterceptedException:
156 self.skipTest( 156 self.skipTest(
diff --git a/bitbake/lib/toaster/tests/browser/test_new_custom_image_page.py b/bitbake/lib/toaster/tests/browser/test_new_custom_image_page.py
index 9f0b6397fe..bf0304dbec 100644
--- a/bitbake/lib/toaster/tests/browser/test_new_custom_image_page.py
+++ b/bitbake/lib/toaster/tests/browser/test_new_custom_image_page.py
@@ -90,7 +90,7 @@ class TestNewCustomImagePage(SeleniumTestCase):
90 """ 90 """
91 url = reverse('newcustomimage', args=(self.project.id,)) 91 url = reverse('newcustomimage', args=(self.project.id,))
92 self.get(url) 92 self.get(url)
93 self.wait_until_visible('#global-nav', poll=3) 93 self.wait_until_visible('#global-nav')
94 94
95 self.click('button[data-recipe="%s"]' % self.recipe.id) 95 self.click('button[data-recipe="%s"]' % self.recipe.id)
96 96
diff --git a/bitbake/lib/toaster/tests/browser/test_new_project_page.py b/bitbake/lib/toaster/tests/browser/test_new_project_page.py
index 458bb6538d..b6187db105 100644
--- a/bitbake/lib/toaster/tests/browser/test_new_project_page.py
+++ b/bitbake/lib/toaster/tests/browser/test_new_project_page.py
@@ -47,7 +47,7 @@ class TestNewProjectPage(SeleniumTestCase):
47 47
48 url = reverse('newproject') 48 url = reverse('newproject')
49 self.get(url) 49 self.get(url)
50 self.wait_until_visible('#new-project-name', poll=3) 50 self.wait_until_visible('#new-project-name')
51 self.enter_text('#new-project-name', project_name) 51 self.enter_text('#new-project-name', project_name)
52 52
53 select = Select(self.find('#projectversion')) 53 select = Select(self.find('#projectversion'))
@@ -58,7 +58,7 @@ class TestNewProjectPage(SeleniumTestCase):
58 # We should get redirected to the new project's page with the 58 # We should get redirected to the new project's page with the
59 # notification at the top 59 # notification at the top
60 element = self.wait_until_visible( 60 element = self.wait_until_visible(
61 '#project-created-notification', poll=3) 61 '#project-created-notification')
62 62
63 self.assertTrue(project_name in element.text, 63 self.assertTrue(project_name in element.text,
64 "New project name not in new project notification") 64 "New project name not in new project notification")
@@ -79,7 +79,7 @@ class TestNewProjectPage(SeleniumTestCase):
79 79
80 url = reverse('newproject') 80 url = reverse('newproject')
81 self.get(url) 81 self.get(url)
82 self.wait_until_visible('#new-project-name', poll=3) 82 self.wait_until_visible('#new-project-name')
83 83
84 self.enter_text('#new-project-name', project_name) 84 self.enter_text('#new-project-name', project_name)
85 85
@@ -91,7 +91,7 @@ class TestNewProjectPage(SeleniumTestCase):
91 91
92 self.click("#create-project-button") 92 self.click("#create-project-button")
93 93
94 self.wait_until_present('#hint-error-project-name', poll=3) 94 self.wait_until_present('#hint-error-project-name')
95 element = self.find('#hint-error-project-name') 95 element = self.find('#hint-error-project-name')
96 96
97 self.assertTrue(("Project names must be unique" in element.text), 97 self.assertTrue(("Project names must be unique" in element.text),