summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJaeyoon Jung <jaeyoon.jung@lge.com>2023-09-20 19:51:37 +0200
committerSteve Sakoman <steve@sakoman.com>2023-09-29 04:33:44 -1000
commitcd0c6173a375e5c7b617985ca2efcf167c92c827 (patch)
tree45728c9ac90c2851e09ede1422a75895999193b1
parent6e379bfb8e94425ebdd8bdb6a47025389fddab3c (diff)
downloadpoky-cd0c6173a375e5c7b617985ca2efcf167c92c827.tar.gz
cml1: Fix KCONFIG_CONFIG_COMMAND not conveyed fully in do_menuconfig
Variable overrides in KCONFIG_CONFIG_COMMAND do not work as expected due to double quote mismatches. The issue is reproducible in an environment where gold is the default linker. Below is an example snippet of run.do_terminal generated by do_menuconfig. do_terminal() { exec sh -c "make menuconfig CC="aarch64-webos-linux-gcc ..." LD="aarch64-webos-linux-ld.bfd ..." ... } Although LD override is set to bfd correctly, it is not passed to make and make menuconfig ends up with messages like: | gold linker is not supported as it is not capable of linking the kernel proper. | scripts/Kconfig.include:56: Sorry, this linker is not supported. (From OE-Core rev: 9c483765db762dbe8020423c8778518612b7e5f7) (From OE-Core rev: 75f8485d7862b08e2f96f919e992d203df6c8d9c) Signed-off-by: Jaeyoon Jung <jaeyoon.jung@lge.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit d4664d2b7974354e73d891762ebb2c8a12d62438) Signed-off-by: Yoann Congal <yoann.congal@smile.fr> Signed-off-by: Steve Sakoman <steve@sakoman.com>
-rw-r--r--meta/classes-recipe/cml1.bbclass2
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/classes-recipe/cml1.bbclass b/meta/classes-recipe/cml1.bbclass
index a09a042c3f..73c22f81d6 100644
--- a/meta/classes-recipe/cml1.bbclass
+++ b/meta/classes-recipe/cml1.bbclass
@@ -53,7 +53,7 @@ python do_menuconfig() {
53 # ensure that environment variables are overwritten with this tasks 'd' values 53 # ensure that environment variables are overwritten with this tasks 'd' values
54 d.appendVar("OE_TERMINAL_EXPORTS", " PKG_CONFIG_DIR PKG_CONFIG_PATH PKG_CONFIG_LIBDIR PKG_CONFIG_SYSROOT_DIR") 54 d.appendVar("OE_TERMINAL_EXPORTS", " PKG_CONFIG_DIR PKG_CONFIG_PATH PKG_CONFIG_LIBDIR PKG_CONFIG_SYSROOT_DIR")
55 55
56 oe_terminal("sh -c \"make %s; if [ \\$? -ne 0 ]; then echo 'Command failed.'; printf 'Press any key to continue... '; read r; fi\"" % d.getVar('KCONFIG_CONFIG_COMMAND'), 56 oe_terminal("sh -c 'make %s; if [ \\$? -ne 0 ]; then echo \"Command failed.\"; printf \"Press any key to continue... \"; read r; fi'" % d.getVar('KCONFIG_CONFIG_COMMAND'),
57 d.getVar('PN') + ' Configuration', d) 57 d.getVar('PN') + ' Configuration', d)
58 58
59 # FIXME this check can be removed when the minimum bitbake version has been bumped 59 # FIXME this check can be removed when the minimum bitbake version has been bumped