summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChangqing Li <changqing.li@windriver.com>2025-06-06 14:50:00 +0800
committerSteve Sakoman <steve@sakoman.com>2025-06-13 08:58:01 -0700
commit859504c47569c578338726e84bbb4898784a2793 (patch)
tree79d7cfff5c4ef434f8a872260c611908e6f31ef3
parente21b12252303145fd5b5ed3666a32b1fdc83300a (diff)
downloadpoky-859504c47569c578338726e84bbb4898784a2793.tar.gz
libsoup: fix CVE-2025-4948
Refer: https://gitlab.gnome.org/GNOME/libsoup/-/issues/449 (From OE-Core rev: 737d50288a37f51f17cf3fef0422e27dbd115cce) Signed-off-by: Changqing Li <changqing.li@windriver.com> Signed-off-by: Steve Sakoman <steve@sakoman.com>
-rw-r--r--meta/recipes-support/libsoup/libsoup-3.4.4/CVE-2025-4948.patch97
-rw-r--r--meta/recipes-support/libsoup/libsoup_3.4.4.bb1
2 files changed, 98 insertions, 0 deletions
diff --git a/meta/recipes-support/libsoup/libsoup-3.4.4/CVE-2025-4948.patch b/meta/recipes-support/libsoup/libsoup-3.4.4/CVE-2025-4948.patch
new file mode 100644
index 0000000000..07c85f5381
--- /dev/null
+++ b/meta/recipes-support/libsoup/libsoup-3.4.4/CVE-2025-4948.patch
@@ -0,0 +1,97 @@
1From a23ce8f8e60e79990e26376c8b0d40841aed4b81 Mon Sep 17 00:00:00 2001
2From: Milan Crha <mcrha@redhat.com>
3Date: Thu, 15 May 2025 17:49:11 +0200
4Subject: [PATCH] soup-multipart: Verify boundary limits for multipart body
5
6It could happen that the boundary started at a place which resulted into
7a negative number, which in an unsigned integer is a very large value.
8Check the body size is not a negative value before setting it.
9
10Closes https://gitlab.gnome.org/GNOME/libsoup/-/issues/449
11
12Part-of: <https://gitlab.gnome.org/GNOME/libsoup/-/merge_requests/463>
13
14CVE: CVE-2025-4948
15Upstream-Status: Backport
16[https://gitlab.gnome.org/GNOME/libsoup/-/merge_requests/463/diffs?commit_id=f2f28afe0b3b2b3009ab67d6874457ec6bac70c0]
17
18Signed-off-by: Changqing Li <changqing.li@windriver.com>
19---
20 libsoup/soup-multipart.c | 2 +-
21 tests/multipart-test.c | 40 ++++++++++++++++++++++++++++++++++++++++
22 2 files changed, 41 insertions(+), 1 deletion(-)
23
24diff --git a/libsoup/soup-multipart.c b/libsoup/soup-multipart.c
25index e1c442e..27257e4 100644
26--- a/libsoup/soup-multipart.c
27+++ b/libsoup/soup-multipart.c
28@@ -204,7 +204,7 @@ soup_multipart_new_from_message (SoupMessageHeaders *headers,
29 */
30 part_body = g_bytes_new_from_bytes (body, // FIXME
31 split - body_data,
32- end - 2 - split);
33+ end - 2 >= split ? end - 2 - split : 0);
34 g_ptr_array_add (multipart->bodies, part_body);
35
36 start = end;
37diff --git a/tests/multipart-test.c b/tests/multipart-test.c
38index 84852e2..2ae888c 100644
39--- a/tests/multipart-test.c
40+++ b/tests/multipart-test.c
41@@ -548,6 +548,45 @@ test_multipart_bounds_bad_2 (void)
42 g_bytes_unref (bytes);
43 }
44
45+static void
46+test_multipart_too_large (void)
47+{
48+ const char *raw_body =
49+ "-------------------\r\n"
50+ "-\n"
51+ "Cont\"\r\n"
52+ "Content-Tynt----e:n\x8erQK\r\n"
53+ "Content-Disposition: name= form-; name=\"file\"; filename=\"ype:i/ -d; ----\xae\r\n"
54+ "Content-Typimag\x01/png--\\\n"
55+ "\r\n"
56+ "---:\n\r\n"
57+ "\r\n"
58+ "-------------------------------------\r\n"
59+ "---------\r\n"
60+ "----------------------";
61+ GBytes *body;
62+ GHashTable *params;
63+ SoupMessageHeaders *headers;
64+ SoupMultipart *multipart;
65+
66+ params = g_hash_table_new (g_str_hash, g_str_equal);
67+ g_hash_table_insert (params, (gpointer) "boundary", (gpointer) "-----------------");
68+ headers = soup_message_headers_new (SOUP_MESSAGE_HEADERS_MULTIPART);
69+ soup_message_headers_set_content_type (headers, "multipart/form-data", params);
70+ g_hash_table_unref (params);
71+
72+ body = g_bytes_new_static (raw_body, strlen (raw_body));
73+ multipart = soup_multipart_new_from_message (headers, body);
74+ soup_message_headers_unref (headers);
75+ g_bytes_unref (body);
76+
77+ g_assert_nonnull (multipart);
78+ g_assert_cmpint (soup_multipart_get_length (multipart), ==, 1);
79+ g_assert_true (soup_multipart_get_part (multipart, 0, &headers, &body));
80+ g_assert_cmpint (g_bytes_get_size (body), ==, 0);
81+ soup_multipart_free (multipart);
82+}
83+
84 int
85 main (int argc, char **argv)
86 {
87@@ -578,6 +617,7 @@ main (int argc, char **argv)
88 g_test_add_func ("/multipart/bounds-good", test_multipart_bounds_good);
89 g_test_add_func ("/multipart/bounds-bad", test_multipart_bounds_bad);
90 g_test_add_func ("/multipart/bounds-bad-2", test_multipart_bounds_bad_2);
91+ g_test_add_func ("/multipart/too-large", test_multipart_too_large);
92
93 ret = g_test_run ();
94
95--
962.34.1
97
diff --git a/meta/recipes-support/libsoup/libsoup_3.4.4.bb b/meta/recipes-support/libsoup/libsoup_3.4.4.bb
index 473a980b1a..9b8bf5b9a2 100644
--- a/meta/recipes-support/libsoup/libsoup_3.4.4.bb
+++ b/meta/recipes-support/libsoup/libsoup_3.4.4.bb
@@ -42,6 +42,7 @@ SRC_URI = "${GNOME_MIRROR}/libsoup/${SHRT_VER}/libsoup-${PV}.tar.xz \
42 file://CVE-2025-32051-2.patch \ 42 file://CVE-2025-32051-2.patch \
43 file://CVE-2025-32050.patch \ 43 file://CVE-2025-32050.patch \
44 file://CVE-2025-46421.patch \ 44 file://CVE-2025-46421.patch \
45 file://CVE-2025-4948.patch \
45" 46"
46SRC_URI[sha256sum] = "291c67725f36ed90ea43efff25064b69c5a2d1981488477c05c481a3b4b0c5aa" 47SRC_URI[sha256sum] = "291c67725f36ed90ea43efff25064b69c5a2d1981488477c05c481a3b4b0c5aa"
47 48