diff options
| author | Changqing Li <changqing.li@windriver.com> | 2025-06-03 14:13:54 +0800 |
|---|---|---|
| committer | Steve Sakoman <steve@sakoman.com> | 2025-06-13 09:01:26 -0700 |
| commit | 41d7ce9502ad5061a7dd95abf34e3d26d01a63d6 (patch) | |
| tree | 0b829085adf248d3cf685f1e140e794c79b19b1d | |
| parent | 974a6ab51e45e1806e680d8919bef80cdec75986 (diff) | |
| download | poky-41d7ce9502ad5061a7dd95abf34e3d26d01a63d6.tar.gz | |
libsoup: fix CVE-2025-4948
Refer:
https://gitlab.gnome.org/GNOME/libsoup/-/issues/449
(From OE-Core rev: c6a014352ae480d90b84ca26653654814a7bda52)
Signed-off-by: Changqing Li <changqing.li@windriver.com>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
| -rw-r--r-- | meta/recipes-support/libsoup/libsoup/CVE-2025-4948.patch | 97 | ||||
| -rw-r--r-- | meta/recipes-support/libsoup/libsoup_3.6.5.bb | 4 |
2 files changed, 100 insertions, 1 deletions
diff --git a/meta/recipes-support/libsoup/libsoup/CVE-2025-4948.patch b/meta/recipes-support/libsoup/libsoup/CVE-2025-4948.patch new file mode 100644 index 0000000000..e0e7b7a44f --- /dev/null +++ b/meta/recipes-support/libsoup/libsoup/CVE-2025-4948.patch | |||
| @@ -0,0 +1,97 @@ | |||
| 1 | From 0076a5ef3f2a3d11805438e7fd90775f8c40569e Mon Sep 17 00:00:00 2001 | ||
| 2 | From: Milan Crha <mcrha@redhat.com> | ||
| 3 | Date: Thu, 15 May 2025 17:49:11 +0200 | ||
| 4 | Subject: [PATCH] soup-multipart: Verify boundary limits for multipart body | ||
| 5 | |||
| 6 | It could happen that the boundary started at a place which resulted into | ||
| 7 | a negative number, which in an unsigned integer is a very large value. | ||
| 8 | Check the body size is not a negative value before setting it. | ||
| 9 | |||
| 10 | Closes https://gitlab.gnome.org/GNOME/libsoup/-/issues/449 | ||
| 11 | |||
| 12 | Part-of: <https://gitlab.gnome.org/GNOME/libsoup/-/merge_requests/463> | ||
| 13 | |||
| 14 | CVE: CVE-2025-4948 | ||
| 15 | Upstream-Status: Backport | ||
| 16 | [https://gitlab.gnome.org/GNOME/libsoup/-/merge_requests/463/diffs?commit_id=f2f28afe0b3b2b3009ab67d6874457ec6bac70c0] | ||
| 17 | |||
| 18 | Signed-off-by: Changqing Li <changqing.li@windriver.com> | ||
| 19 | --- | ||
| 20 | libsoup/soup-multipart.c | 2 +- | ||
| 21 | tests/multipart-test.c | 40 ++++++++++++++++++++++++++++++++++++++++ | ||
| 22 | 2 files changed, 41 insertions(+), 1 deletion(-) | ||
| 23 | |||
| 24 | diff --git a/libsoup/soup-multipart.c b/libsoup/soup-multipart.c | ||
| 25 | index 102ce37..a587fe7 100644 | ||
| 26 | --- a/libsoup/soup-multipart.c | ||
| 27 | +++ b/libsoup/soup-multipart.c | ||
| 28 | @@ -204,7 +204,7 @@ soup_multipart_new_from_message (SoupMessageHeaders *headers, | ||
| 29 | */ | ||
| 30 | part_body = g_bytes_new_from_bytes (body, // FIXME | ||
| 31 | split - body_data, | ||
| 32 | - end - 2 - split); | ||
| 33 | + end - 2 >= split ? end - 2 - split : 0); | ||
| 34 | g_ptr_array_add (multipart->bodies, part_body); | ||
| 35 | |||
| 36 | start = end; | ||
| 37 | diff --git a/tests/multipart-test.c b/tests/multipart-test.c | ||
| 38 | index f5b9868..92b673e 100644 | ||
| 39 | --- a/tests/multipart-test.c | ||
| 40 | +++ b/tests/multipart-test.c | ||
| 41 | @@ -527,6 +527,45 @@ test_multipart_bounds_bad (void) | ||
| 42 | g_bytes_unref (bytes); | ||
| 43 | } | ||
| 44 | |||
| 45 | +static void | ||
| 46 | +test_multipart_too_large (void) | ||
| 47 | +{ | ||
| 48 | + const char *raw_body = | ||
| 49 | + "-------------------\r\n" | ||
| 50 | + "-\n" | ||
| 51 | + "Cont\"\r\n" | ||
| 52 | + "Content-Tynt----e:n\x8erQK\r\n" | ||
| 53 | + "Content-Disposition: name= form-; name=\"file\"; filename=\"ype:i/ -d; ----\xae\r\n" | ||
| 54 | + "Content-Typimag\x01/png--\\\n" | ||
| 55 | + "\r\n" | ||
| 56 | + "---:\n\r\n" | ||
| 57 | + "\r\n" | ||
| 58 | + "-------------------------------------\r\n" | ||
| 59 | + "---------\r\n" | ||
| 60 | + "----------------------"; | ||
| 61 | + GBytes *body; | ||
| 62 | + GHashTable *params; | ||
| 63 | + SoupMessageHeaders *headers; | ||
| 64 | + SoupMultipart *multipart; | ||
| 65 | + | ||
| 66 | + params = g_hash_table_new (g_str_hash, g_str_equal); | ||
| 67 | + g_hash_table_insert (params, (gpointer) "boundary", (gpointer) "-----------------"); | ||
| 68 | + headers = soup_message_headers_new (SOUP_MESSAGE_HEADERS_MULTIPART); | ||
| 69 | + soup_message_headers_set_content_type (headers, "multipart/form-data", params); | ||
| 70 | + g_hash_table_unref (params); | ||
| 71 | + | ||
| 72 | + body = g_bytes_new_static (raw_body, strlen (raw_body)); | ||
| 73 | + multipart = soup_multipart_new_from_message (headers, body); | ||
| 74 | + soup_message_headers_unref (headers); | ||
| 75 | + g_bytes_unref (body); | ||
| 76 | + | ||
| 77 | + g_assert_nonnull (multipart); | ||
| 78 | + g_assert_cmpint (soup_multipart_get_length (multipart), ==, 1); | ||
| 79 | + g_assert_true (soup_multipart_get_part (multipart, 0, &headers, &body)); | ||
| 80 | + g_assert_cmpint (g_bytes_get_size (body), ==, 0); | ||
| 81 | + soup_multipart_free (multipart); | ||
| 82 | +} | ||
| 83 | + | ||
| 84 | int | ||
| 85 | main (int argc, char **argv) | ||
| 86 | { | ||
| 87 | @@ -556,6 +595,7 @@ main (int argc, char **argv) | ||
| 88 | g_test_add_data_func ("/multipart/async-small-reads", GINT_TO_POINTER (ASYNC_MULTIPART_SMALL_READS), test_multipart); | ||
| 89 | g_test_add_func ("/multipart/bounds-good", test_multipart_bounds_good); | ||
| 90 | g_test_add_func ("/multipart/bounds-bad", test_multipart_bounds_bad); | ||
| 91 | + g_test_add_func ("/multipart/too-large", test_multipart_too_large); | ||
| 92 | |||
| 93 | ret = g_test_run (); | ||
| 94 | |||
| 95 | -- | ||
| 96 | 2.34.1 | ||
| 97 | |||
diff --git a/meta/recipes-support/libsoup/libsoup_3.6.5.bb b/meta/recipes-support/libsoup/libsoup_3.6.5.bb index a8c0546677..772e21e09b 100644 --- a/meta/recipes-support/libsoup/libsoup_3.6.5.bb +++ b/meta/recipes-support/libsoup/libsoup_3.6.5.bb | |||
| @@ -17,7 +17,9 @@ SRC_URI = "${GNOME_MIRROR}/libsoup/${SHRT_VER}/libsoup-${PV}.tar.xz \ | |||
| 17 | file://CVE-2025-32907-1.patch \ | 17 | file://CVE-2025-32907-1.patch \ |
| 18 | file://CVE-2025-32907-2.patch \ | 18 | file://CVE-2025-32907-2.patch \ |
| 19 | file://CVE-2025-32908-1.patch \ | 19 | file://CVE-2025-32908-1.patch \ |
| 20 | file://CVE-2025-32908-2.patch" | 20 | file://CVE-2025-32908-2.patch \ |
| 21 | file://CVE-2025-4948.patch \ | ||
| 22 | " | ||
| 21 | SRC_URI[sha256sum] = "6891765aac3e949017945c3eaebd8cc8216df772456dc9f460976fbdb7ada234" | 23 | SRC_URI[sha256sum] = "6891765aac3e949017945c3eaebd8cc8216df772456dc9f460976fbdb7ada234" |
| 22 | 24 | ||
| 23 | PROVIDES = "libsoup-3.0" | 25 | PROVIDES = "libsoup-3.0" |
