diff options
| author | Ross Burton <ross.burton@arm.com> | 2022-09-05 11:19:53 +0100 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2022-09-08 14:59:39 +0100 |
| commit | 1e73562ea7472604094cd084ae8f208a38dab545 (patch) | |
| tree | 80e75d88070c630d4ebd7659b0dc82f6fe69976c | |
| parent | bdd91aa3886fb9c1115e69bd4bf7d03bfaf0720b (diff) | |
| download | poky-1e73562ea7472604094cd084ae8f208a38dab545.tar.gz | |
xmlto: remove redundant patches
0001-Skip-validating-xmlto-output isn't needed as xmllint will use the
local catalogues correctly now[1].
configure.in-drop-the-test-of-xmllint-and-xsltproc can be dropped if we
pre-load the result of AC_PATH_PROG with ac_cv_path_XMLLINT.
[1] oe-core 8159b47e7ddddaca57ade2ecf24d8ff9a0abf26a
(From OE-Core rev: 0fecb0c86303cb0b54c0f3986176b27f0647d6a3)
Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
3 files changed, 3 insertions, 65 deletions
diff --git a/meta/recipes-devtools/xmlto/xmlto/0001-Skip-validating-xmlto-output.patch b/meta/recipes-devtools/xmlto/xmlto/0001-Skip-validating-xmlto-output.patch deleted file mode 100644 index c6857a9da5..0000000000 --- a/meta/recipes-devtools/xmlto/xmlto/0001-Skip-validating-xmlto-output.patch +++ /dev/null | |||
| @@ -1,29 +0,0 @@ | |||
| 1 | From 3deb7a0eded04ab08a9cb2d88526cb1c7b440061 Mon Sep 17 00:00:00 2001 | ||
| 2 | From: Khem Raj <raj.khem@gmail.com> | ||
| 3 | Date: Sun, 14 Aug 2022 00:23:29 -0700 | ||
| 4 | Subject: [PATCH] Skip validating xmlto output | ||
| 5 | |||
| 6 | Avoids network access | ||
| 7 | |||
| 8 | Upstream-Status: Submitted [https://pagure.io/xmlto/pull-request/11] | ||
| 9 | Signed-off-by: Khem Raj <raj.khem@gmail.com> | ||
| 10 | --- | ||
| 11 | Makefile.am | 2 +- | ||
| 12 | 1 file changed, 1 insertion(+), 1 deletion(-) | ||
| 13 | |||
| 14 | diff --git a/Makefile.am b/Makefile.am | ||
| 15 | index 50fa279..6a2da62 100644 | ||
| 16 | --- a/Makefile.am | ||
| 17 | +++ b/Makefile.am | ||
| 18 | @@ -68,7 +68,7 @@ EXTRA_DIST = xmlto.spec \ | ||
| 19 | doc/xmlif.xml \ | ||
| 20 | xmlto.mak | ||
| 21 | |||
| 22 | -GEN_MANPAGE = FORMAT_DIR=$(top_srcdir)/format $(BASH) ./xmlto -o $(@D) man $< | ||
| 23 | +GEN_MANPAGE = FORMAT_DIR=$(top_srcdir)/format $(BASH) ./xmlto --skip-validation -o $(@D) man $< | ||
| 24 | man/man1/xmlto.1: doc/xmlto.xml ; $(GEN_MANPAGE) | ||
| 25 | man/man1/xmlif.1: doc/xmlif.xml ; $(GEN_MANPAGE) | ||
| 26 | |||
| 27 | -- | ||
| 28 | 2.37.2 | ||
| 29 | |||
diff --git a/meta/recipes-devtools/xmlto/xmlto/configure.in-drop-the-test-of-xmllint-and-xsltproc.patch b/meta/recipes-devtools/xmlto/xmlto/configure.in-drop-the-test-of-xmllint-and-xsltproc.patch deleted file mode 100644 index 7cc3cbe0fb..0000000000 --- a/meta/recipes-devtools/xmlto/xmlto/configure.in-drop-the-test-of-xmllint-and-xsltproc.patch +++ /dev/null | |||
| @@ -1,30 +0,0 @@ | |||
| 1 | configure.in: drop the test of xmllint and xsltproc | ||
| 2 | |||
| 3 | The test is unnecessary, the xmllint and xsltproc were explicitly | ||
| 4 | added to RDEPENDS. | ||
| 5 | |||
| 6 | Upstream-Status: Inappropriate | ||
| 7 | Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> | ||
| 8 | --- | ||
| 9 | configure.in | 4 ++-- | ||
| 10 | 1 file changed, 2 insertions(+), 2 deletions(-) | ||
| 11 | |||
| 12 | diff --git a/configure.ac b/configure.ac | ||
| 13 | --- a/configure.ac | ||
| 14 | +++ b/configure.ac | ||
| 15 | @@ -42,10 +42,10 @@ AC_ARG_VAR([LOCALE], [Name and path of the `locale' program.]) | ||
| 16 | AC_PATH_PROG([LOCALE], [locale], [locale]) | ||
| 17 | |||
| 18 | AC_ARG_VAR([XMLLINT], [Name and path of the `xmllint' program.]) | ||
| 19 | -AC_PATH_PROG([XMLLINT], [xmllint], [xmllint]) | ||
| 20 | +dnl AC_PATH_PROG([XMLLINT], [xmllint], [xmllint]) | ||
| 21 | |||
| 22 | AC_ARG_VAR([XSLTPROC], [Name and path of the `xsltproc' program.]) | ||
| 23 | -AC_PATH_PROG([XSLTPROC], [xsltproc], [xsltproc]) | ||
| 24 | +dnl AC_PATH_PROG([XSLTPROC], [xsltproc], [xsltproc]) | ||
| 25 | |||
| 26 | dnl | ||
| 27 | dnl toolchains | ||
| 28 | -- | ||
| 29 | 1.8.1.2 | ||
| 30 | |||
diff --git a/meta/recipes-devtools/xmlto/xmlto_0.0.28.bb b/meta/recipes-devtools/xmlto/xmlto_0.0.28.bb index 373eca2454..5e3fac7a60 100644 --- a/meta/recipes-devtools/xmlto/xmlto_0.0.28.bb +++ b/meta/recipes-devtools/xmlto/xmlto_0.0.28.bb | |||
| @@ -8,10 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552" | |||
| 8 | 8 | ||
| 9 | SRCREV = "6fa6a0e07644f20abf2596f78a60112713e11cbe" | 9 | SRCREV = "6fa6a0e07644f20abf2596f78a60112713e11cbe" |
| 10 | UPSTREAM_CHECK_COMMITS = "1" | 10 | UPSTREAM_CHECK_COMMITS = "1" |
| 11 | SRC_URI = "git://pagure.io/xmlto.git;protocol=https;branch=master \ | 11 | SRC_URI = "git://pagure.io/xmlto.git;protocol=https;branch=master" |
| 12 | file://configure.in-drop-the-test-of-xmllint-and-xsltproc.patch \ | ||
| 13 | file://0001-Skip-validating-xmlto-output.patch \ | ||
| 14 | " | ||
| 15 | S = "${WORKDIR}/git" | 12 | S = "${WORKDIR}/git" |
| 16 | 13 | ||
| 17 | PV .= "+0.0.29+git${SRCPV}" | 14 | PV .= "+0.0.29+git${SRCPV}" |
| @@ -34,11 +31,11 @@ RDEPENDS:${PN}:append:class-target = " \ | |||
| 34 | libxslt-bin \ | 31 | libxslt-bin \ |
| 35 | coreutils \ | 32 | coreutils \ |
| 36 | " | 33 | " |
| 37 | CACHED_CONFIGUREVARS += "ac_cv_path_TAIL=tail ac_cv_path_GREP=grep" | 34 | CACHED_CONFIGUREVARS += "ac_cv_path_TAIL=tail ac_cv_path_GREP=grep ac_cv_path_XMLLINT=xmllint ac_cv_path_XSLTPROC=xsltproc" |
| 38 | 35 | ||
| 39 | BBCLASSEXTEND = "native" | 36 | BBCLASSEXTEND = "native" |
| 40 | 37 | ||
| 41 | EXTRA_OECONF:append = " BASH=/bin/bash GCP=/bin/cp XMLLINT=xmllint XSLTPROC=xsltproc" | 38 | EXTRA_OECONF:append = " BASH=/bin/bash GCP=/bin/cp" |
| 42 | 39 | ||
| 43 | do_configure:prepend() { | 40 | do_configure:prepend() { |
| 44 | (cd ${S} && flex -o xmlif/xmlif.c xmlif/xmlif.l) | 41 | (cd ${S} && flex -o xmlif/xmlif.c xmlif/xmlif.l) |
