diff options
| author | Chen Qi <Qi.Chen@windriver.com> | 2019-08-22 15:52:51 +0800 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2019-08-28 16:44:09 +0100 |
| commit | 1af3e4bea666e944a610025ca8979098b59b1174 (patch) | |
| tree | 3b723d83e7d31e024d7fd95898dd06f5e05cf7e6 | |
| parent | 46a71949de40a1b1a5353aa7ba01fecb22cf452a (diff) | |
| download | poky-1af3e4bea666e944a610025ca8979098b59b1174.tar.gz | |
bitbake: cooker.py: remove generation of recipe-depends.dot
The information of recipe-depends.dot is misleading.
e.g.
$ grep xz recipe-depends.dot | grep bzip2
"bzip2" -> "xz"
"xz" -> "bzip2"
Users would wonder why they get some circular dependency.
The information is derived from removing the task names
of task-depends.dot. It's not giving people any additonal
information, and it's misleading.
So we remove the generation of this file.
(Bitbake rev: 4c484cc01e3eee7ab2ab0359fd680b4dbd31dc30)
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | bitbake/lib/bb/cooker.py | 25 |
1 files changed, 4 insertions, 21 deletions
diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py index 0607fcc708..e46868ddd0 100644 --- a/bitbake/lib/bb/cooker.py +++ b/bitbake/lib/bb/cooker.py | |||
| @@ -919,6 +919,10 @@ class BBCooker: | |||
| 919 | os.unlink('package-depends.dot') | 919 | os.unlink('package-depends.dot') |
| 920 | except FileNotFoundError: | 920 | except FileNotFoundError: |
| 921 | pass | 921 | pass |
| 922 | try: | ||
| 923 | os.unlink('recipe-depends.dot') | ||
| 924 | except FileNotFoundError: | ||
| 925 | pass | ||
| 922 | 926 | ||
| 923 | with open('task-depends.dot', 'w') as f: | 927 | with open('task-depends.dot', 'w') as f: |
| 924 | f.write("digraph depends {\n") | 928 | f.write("digraph depends {\n") |
| @@ -932,27 +936,6 @@ class BBCooker: | |||
| 932 | f.write("}\n") | 936 | f.write("}\n") |
| 933 | logger.info("Task dependencies saved to 'task-depends.dot'") | 937 | logger.info("Task dependencies saved to 'task-depends.dot'") |
| 934 | 938 | ||
| 935 | with open('recipe-depends.dot', 'w') as f: | ||
| 936 | f.write("digraph depends {\n") | ||
| 937 | pndeps = {} | ||
| 938 | for task in sorted(depgraph["tdepends"]): | ||
| 939 | (pn, taskname) = task.rsplit(".", 1) | ||
| 940 | if pn not in pndeps: | ||
| 941 | pndeps[pn] = set() | ||
| 942 | for dep in sorted(depgraph["tdepends"][task]): | ||
| 943 | (deppn, deptaskname) = dep.rsplit(".", 1) | ||
| 944 | pndeps[pn].add(deppn) | ||
| 945 | for pn in sorted(pndeps): | ||
| 946 | fn = depgraph["pn"][pn]["filename"] | ||
| 947 | version = depgraph["pn"][pn]["version"] | ||
| 948 | f.write('"%s" [label="%s\\n%s\\n%s"]\n' % (pn, pn, version, fn)) | ||
| 949 | for dep in sorted(pndeps[pn]): | ||
| 950 | if dep == pn: | ||
| 951 | continue | ||
| 952 | f.write('"%s" -> "%s"\n' % (pn, dep)) | ||
| 953 | f.write("}\n") | ||
| 954 | logger.info("Flattened recipe dependencies saved to 'recipe-depends.dot'") | ||
| 955 | |||
| 956 | def show_appends_with_no_recipes(self): | 939 | def show_appends_with_no_recipes(self): |
| 957 | # Determine which bbappends haven't been applied | 940 | # Determine which bbappends haven't been applied |
| 958 | 941 | ||
