summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRoss Burton <ross.burton@arm.com>2024-11-05 19:48:54 +0000
committerRichard Purdie <richard.purdie@linuxfoundation.org>2024-11-06 12:18:05 +0000
commit109fe2eade73b81ef43524e48a8bcfe0695b1ce3 (patch)
tree4d44d79c90e765ca1e623ee6a5895cb7f3c83d59
parentf3f838a6d3e7e4129e46babe595ecb0c1ae9e5aa (diff)
downloadpoky-109fe2eade73b81ef43524e48a8bcfe0695b1ce3.tar.gz
selftest/container: fix IMAGE_FEATURES assignment
Assigning IMAGE_FEATURES="" in local.conf doesn't actually do anything useful, as bitbake.conf has IMAGE_FEATURES += EXTRA_IMAGE_FEATURES after the include of local.conf. In this test case, this results in IMAGE_FEATURES still using EXTRA_IMAGE_FEATURES, so the image contains the files installed by the post-install-logging feature. As the intention here is that container-test-image is as minimal as possible, move the IMAGE_FEATURES assignment into the image itself so it actually works, and update the expected file list to remove the post-install-logging files. (From OE-Core rev: c65349e1238ddc6634dfa4759c57e6168a355200) Signed-off-by: Ross Burton <ross.burton@arm.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--meta-selftest/recipes-test/container-image/container-test-image.bb1
-rw-r--r--meta/lib/oeqa/selftest/cases/containerimage.py3
2 files changed, 1 insertions, 3 deletions
diff --git a/meta-selftest/recipes-test/container-image/container-test-image.bb b/meta-selftest/recipes-test/container-image/container-test-image.bb
index d5f939c6e9..26b6409d1d 100644
--- a/meta-selftest/recipes-test/container-image/container-test-image.bb
+++ b/meta-selftest/recipes-test/container-image/container-test-image.bb
@@ -4,5 +4,6 @@ LICENSE = "MIT"
4 4
5IMAGE_FSTYPES = "container" 5IMAGE_FSTYPES = "container"
6IMAGE_LINGUAS = "" 6IMAGE_LINGUAS = ""
7IMAGE_FEATURES = ""
7 8
8inherit core-image 9inherit core-image
diff --git a/meta/lib/oeqa/selftest/cases/containerimage.py b/meta/lib/oeqa/selftest/cases/containerimage.py
index 23c0a1408a..d1ac305a84 100644
--- a/meta/lib/oeqa/selftest/cases/containerimage.py
+++ b/meta/lib/oeqa/selftest/cases/containerimage.py
@@ -42,7 +42,6 @@ class ContainerImageTests(OESelftestTestCase):
42 self.write_config("""PREFERRED_PROVIDER_virtual/kernel = "linux-dummy" 42 self.write_config("""PREFERRED_PROVIDER_virtual/kernel = "linux-dummy"
43IMAGE_FSTYPES = "container" 43IMAGE_FSTYPES = "container"
44PACKAGE_CLASSES = "package_ipk" 44PACKAGE_CLASSES = "package_ipk"
45IMAGE_FEATURES = ""
46IMAGE_BUILDINFO_FILE = "" 45IMAGE_BUILDINFO_FILE = ""
47INIT_MANAGER = "sysvinit" 46INIT_MANAGER = "sysvinit"
48IMAGE_INSTALL:remove = "ssh-pregen-hostkeys" 47IMAGE_INSTALL:remove = "ssh-pregen-hostkeys"
@@ -55,8 +54,6 @@ IMAGE_INSTALL:remove = "ssh-pregen-hostkeys"
55 expected_files = [ 54 expected_files = [
56 './', 55 './',
57 '.{bindir}/theapp', 56 '.{bindir}/theapp',
58 '.{sysconfdir}/default/',
59 '.{sysconfdir}/default/postinst',
60 '.{sysconfdir}/ld.so.cache', 57 '.{sysconfdir}/ld.so.cache',
61 '.{sysconfdir}/timestamp', 58 '.{sysconfdir}/timestamp',
62 '.{sysconfdir}/version', 59 '.{sysconfdir}/version',