diff options
| author | Richard Purdie <richard.purdie@linuxfoundation.org> | 2021-02-27 15:17:16 +0000 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2021-03-18 21:20:24 +0000 |
| commit | 00833c52d6459758f1da8e9f88710fa14bd1bc5e (patch) | |
| tree | 31bba435cce766df41c15cf1f3d8f0709c31c9dc | |
| parent | 5c3020b81024e710c66eedf71cc1a1326da9b3c7 (diff) | |
| download | poky-00833c52d6459758f1da8e9f88710fa14bd1bc5e.tar.gz | |
libid3tag: Fix reproducibility issue
Configure was swallowing our cflags meaning the resulting binaries were
not reproducible. Tweak configure not to do that and fix reproducibility.
(From OE-Core rev: d55f1632bbc6f9b7dadc874d68006d4ceb13937c)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 1395269a6fae5cec01d721e2ad52bd7cb8fc38ce)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | meta/recipes-multimedia/libid3tag/libid3tag/cflags_filter.patch | 21 | ||||
| -rw-r--r-- | meta/recipes-multimedia/libid3tag/libid3tag_0.15.1b.bb | 1 |
2 files changed, 22 insertions, 0 deletions
diff --git a/meta/recipes-multimedia/libid3tag/libid3tag/cflags_filter.patch b/meta/recipes-multimedia/libid3tag/libid3tag/cflags_filter.patch new file mode 100644 index 0000000000..0d1d0dc381 --- /dev/null +++ b/meta/recipes-multimedia/libid3tag/libid3tag/cflags_filter.patch | |||
| @@ -0,0 +1,21 @@ | |||
| 1 | configure contains CFLAGS filtering code which was removing our prefix-map | ||
| 2 | flags. We need those to generate reproducible binaries. Allow them through. | ||
| 3 | |||
| 4 | Upstream-Status: Pending | ||
| 5 | Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> | ||
| 6 | |||
| 7 | Index: libid3tag-0.15.1b/configure.ac | ||
| 8 | =================================================================== | ||
| 9 | --- libid3tag-0.15.1b.orig/configure.ac | ||
| 10 | +++ libid3tag-0.15.1b/configure.ac | ||
| 11 | @@ -99,6 +99,10 @@ do | ||
| 12 | -mno-cygwin) | ||
| 13 | shift | ||
| 14 | ;; | ||
| 15 | + -fmacro-prefix-map*|-fdebug-prefix-map*) | ||
| 16 | + CFLAGS="$CFLAGS $1" | ||
| 17 | + shift | ||
| 18 | + ;; | ||
| 19 | -m*) | ||
| 20 | arch="$arch $1" | ||
| 21 | shift | ||
diff --git a/meta/recipes-multimedia/libid3tag/libid3tag_0.15.1b.bb b/meta/recipes-multimedia/libid3tag/libid3tag_0.15.1b.bb index 0312a610c0..80581765ac 100644 --- a/meta/recipes-multimedia/libid3tag/libid3tag_0.15.1b.bb +++ b/meta/recipes-multimedia/libid3tag/libid3tag_0.15.1b.bb | |||
| @@ -15,6 +15,7 @@ SRC_URI = "${SOURCEFORGE_MIRROR}/mad/libid3tag-${PV}.tar.gz \ | |||
| 15 | file://0001-Fix-gperf-3.1-incompatibility.patch \ | 15 | file://0001-Fix-gperf-3.1-incompatibility.patch \ |
| 16 | file://10_utf16.patch \ | 16 | file://10_utf16.patch \ |
| 17 | file://unknown-encoding.patch \ | 17 | file://unknown-encoding.patch \ |
| 18 | file://cflags_filter.patch \ | ||
| 18 | " | 19 | " |
| 19 | UPSTREAM_CHECK_URI = "https://sourceforge.net/projects/mad/files/libid3tag/" | 20 | UPSTREAM_CHECK_URI = "https://sourceforge.net/projects/mad/files/libid3tag/" |
| 20 | UPSTREAM_CHECK_REGEX = "/projects/mad/files/libid3tag/(?P<pver>.*)/$" | 21 | UPSTREAM_CHECK_REGEX = "/projects/mad/files/libid3tag/(?P<pver>.*)/$" |
