diff options
| -rw-r--r-- | meta-oe/recipes-extended/mozjs/mozjs/Manually_mmap_heap_memory_esr17.patch | 115 | ||||
| -rw-r--r-- | meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb | 1 |
2 files changed, 116 insertions, 0 deletions
diff --git a/meta-oe/recipes-extended/mozjs/mozjs/Manually_mmap_heap_memory_esr17.patch b/meta-oe/recipes-extended/mozjs/mozjs/Manually_mmap_heap_memory_esr17.patch new file mode 100644 index 0000000000..15ad03f712 --- /dev/null +++ b/meta-oe/recipes-extended/mozjs/mozjs/Manually_mmap_heap_memory_esr17.patch | |||
| @@ -0,0 +1,115 @@ | |||
| 1 | From a0c0f32299419359b44ac0f880c1ea9073ae51e1 Mon Sep 17 00:00:00 2001 | ||
| 2 | From: Zheng Xu <zheng.xu@linaro.org> | ||
| 3 | Date: Fri, 2 Sep 2016 17:40:05 +0800 | ||
| 4 | Subject: [PATCH] Bug 1143022 - Manually mmap on arm64 to ensure high 17 bits | ||
| 5 | are clear. r=ehoogeveen | ||
| 6 | |||
| 7 | There might be 48-bit VA on arm64 depending on kernel configuration. | ||
| 8 | Manually mmap heap memory to align with the assumption made by JS engine. | ||
| 9 | |||
| 10 | Change-Id: Ic5d2b2fe4b758b3c87cc0688348af7e71a991146 | ||
| 11 | |||
| 12 | Upstream-status: Backport | ||
| 13 | |||
| 14 | --- | ||
| 15 | js/src/gc/Memory.cpp | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++-- | ||
| 16 | 1 file changed, 71 insertions(+), 2 deletions(-) | ||
| 17 | |||
| 18 | diff --git a/js/src/gc/Memory.cpp b/js/src/gc/Memory.cpp | ||
| 19 | index 5b386a2..38101cf 100644 | ||
| 20 | --- a/js/src/gc/Memory.cpp | ||
| 21 | +++ b/js/src/gc/Memory.cpp | ||
| 22 | @@ -306,6 +306,75 @@ InitMemorySubsystem() | ||
| 23 | MOZ_CRASH(); | ||
| 24 | } | ||
| 25 | |||
| 26 | +static inline void * | ||
| 27 | +MapMemory(size_t length, int prot, int flags, int fd, off_t offset) | ||
| 28 | +{ | ||
| 29 | +#if defined(__ia64__) | ||
| 30 | + /* | ||
| 31 | + * The JS engine assumes that all allocated pointers have their high 17 bits clear, | ||
| 32 | + * which ia64's mmap doesn't support directly. However, we can emulate it by passing | ||
| 33 | + * mmap an "addr" parameter with those bits clear. The mmap will return that address, | ||
| 34 | + * or the nearest available memory above that address, providing a near-guarantee | ||
| 35 | + * that those bits are clear. If they are not, we return NULL below to indicate | ||
| 36 | + * out-of-memory. | ||
| 37 | + * | ||
| 38 | + * The addr is chosen as 0x0000070000000000, which still allows about 120TB of virtual | ||
| 39 | + * address space. | ||
| 40 | + * | ||
| 41 | + * See Bug 589735 for more information. | ||
| 42 | + */ | ||
| 43 | + void *region = mmap((void*)0x0000070000000000, length, prot, flags, fd, offset); | ||
| 44 | + if (region == MAP_FAILED) | ||
| 45 | + return MAP_FAILED; | ||
| 46 | + /* | ||
| 47 | + * If the allocated memory doesn't have its upper 17 bits clear, consider it | ||
| 48 | + * as out of memory. | ||
| 49 | + */ | ||
| 50 | + if ((uintptr_t(region) + (length - 1)) & 0xffff800000000000) { | ||
| 51 | + JS_ALWAYS_TRUE(0 == munmap(region, length)); | ||
| 52 | + return MAP_FAILED; | ||
| 53 | + } | ||
| 54 | + return region; | ||
| 55 | +#elif defined(__aarch64__) | ||
| 56 | + /* | ||
| 57 | + * There might be similar virtual address issue on arm64 which depends on | ||
| 58 | + * hardware and kernel configurations. But the work around is slightly | ||
| 59 | + * different due to the different mmap behavior. | ||
| 60 | + * | ||
| 61 | + * TODO: Merge with the above code block if this implementation works for | ||
| 62 | + * ia64 and sparc64. | ||
| 63 | + */ | ||
| 64 | + const uintptr_t start = UINT64_C(0x0000070000000000); | ||
| 65 | + const uintptr_t end = UINT64_C(0x0000800000000000); | ||
| 66 | + const uintptr_t step = ChunkSize; | ||
| 67 | + /* | ||
| 68 | + * Optimization options if there are too many retries in practice: | ||
| 69 | + * 1. Examine /proc/self/maps to find an available address. This file is | ||
| 70 | + * not always available, however. In addition, even if we examine | ||
| 71 | + * /proc/self/maps, we may still need to retry several times due to | ||
| 72 | + * racing with other threads. | ||
| 73 | + * 2. Use a global/static variable with lock to track the addresses we have | ||
| 74 | + * allocated or tried. | ||
| 75 | + */ | ||
| 76 | + uintptr_t hint; | ||
| 77 | + void* region = MAP_FAILED; | ||
| 78 | + for (hint = start; region == MAP_FAILED && hint + length <= end; hint += step) { | ||
| 79 | + region = mmap((void*)hint, length, prot, flags, fd, offset); | ||
| 80 | + if (region != MAP_FAILED) { | ||
| 81 | + if ((uintptr_t(region) + (length - 1)) & 0xffff800000000000) { | ||
| 82 | + if (munmap(region, length)) { | ||
| 83 | + MOZ_ASSERT(errno == ENOMEM); | ||
| 84 | + } | ||
| 85 | + region = MAP_FAILED; | ||
| 86 | + } | ||
| 87 | + } | ||
| 88 | + } | ||
| 89 | + return region == MAP_FAILED ? NULL : region; | ||
| 90 | +#else | ||
| 91 | + return mmap(NULL, length, prot, flags, fd, offset); | ||
| 92 | +#endif | ||
| 93 | +} | ||
| 94 | + | ||
| 95 | void * | ||
| 96 | MapAlignedPages(size_t size, size_t alignment) | ||
| 97 | { | ||
| 98 | @@ -319,12 +388,12 @@ MapAlignedPages(size_t size, size_t alignment) | ||
| 99 | |||
| 100 | /* Special case: If we want page alignment, no further work is needed. */ | ||
| 101 | if (alignment == PageSize) { | ||
| 102 | - return mmap(NULL, size, prot, flags, -1, 0); | ||
| 103 | + return MapMemory(size, prot, flags, -1, 0); | ||
| 104 | } | ||
| 105 | |||
| 106 | /* Overallocate and unmap the region's edges. */ | ||
| 107 | size_t reqSize = Min(size + 2 * alignment, 2 * size); | ||
| 108 | - void *region = mmap(NULL, reqSize, prot, flags, -1, 0); | ||
| 109 | + void *region = MapMemory(reqSize, prot, flags, -1, 0); | ||
| 110 | if (region == MAP_FAILED) | ||
| 111 | return NULL; | ||
| 112 | |||
| 113 | -- | ||
| 114 | 1.9.1 | ||
| 115 | |||
diff --git a/meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb b/meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb index d477f4bb05..24631e4eac 100644 --- a/meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb +++ b/meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb | |||
| @@ -15,6 +15,7 @@ SRC_URI = " \ | |||
| 15 | file://fix_milestone_compile_issue.patch \ | 15 | file://fix_milestone_compile_issue.patch \ |
| 16 | file://0010-fix-cross-compilation-on-i586-targets.patch;patchdir=../../ \ | 16 | file://0010-fix-cross-compilation-on-i586-targets.patch;patchdir=../../ \ |
| 17 | file://0001-add-support-for-big-endian-32bit-ARM.patch;patchdir=../../ \ | 17 | file://0001-add-support-for-big-endian-32bit-ARM.patch;patchdir=../../ \ |
| 18 | file://Manually_mmap_heap_memory_esr17.patch;patchdir=../../ \ | ||
| 18 | " | 19 | " |
| 19 | 20 | ||
| 20 | SRC_URI[md5sum] = "20b6f8f1140ef6e47daa3b16965c9202" | 21 | SRC_URI[md5sum] = "20b6f8f1140ef6e47daa3b16965c9202" |
