diff options
| -rw-r--r-- | meta-xfce/recipes-xfce/tumbler/files/0001-Handle-cases-where-there-are-no-plugins-gracefully.patch | 57 | ||||
| -rw-r--r-- | meta-xfce/recipes-xfce/tumbler/tumbler_4.21.1.bb (renamed from meta-xfce/recipes-xfce/tumbler/tumbler_4.20.1.bb) | 25 |
2 files changed, 71 insertions, 11 deletions
diff --git a/meta-xfce/recipes-xfce/tumbler/files/0001-Handle-cases-where-there-are-no-plugins-gracefully.patch b/meta-xfce/recipes-xfce/tumbler/files/0001-Handle-cases-where-there-are-no-plugins-gracefully.patch new file mode 100644 index 0000000000..3a3eb2fd64 --- /dev/null +++ b/meta-xfce/recipes-xfce/tumbler/files/0001-Handle-cases-where-there-are-no-plugins-gracefully.patch | |||
| @@ -0,0 +1,57 @@ | |||
| 1 | From 95244ee0d1f3184e2c2cae9d33095dc03829b10e Mon Sep 17 00:00:00 2001 | ||
| 2 | From: =?UTF-8?q?Ga=C3=ABl=20Bonithon?= <gael@xfce.org> | ||
| 3 | Date: Fri, 20 Feb 2026 17:07:56 +0100 | ||
| 4 | Subject: [PATCH] Handle cases where there are no plugins gracefully | ||
| 5 | |||
| 6 | Not sure it makes much sense to allow the cache plugin not to be built, | ||
| 7 | but then again, why not? It could be replaced by a customized | ||
| 8 | implementation, and it has always been possible not to build it, so we | ||
| 9 | might as well leave it as it is. | ||
| 10 | |||
| 11 | Fixes: #109 | ||
| 12 | (cherry picked from commit b4f4db4bfc1a45f0a405c4516e38394a44c90fcf) | ||
| 13 | |||
| 14 | Upstream-Status: Backport [https://gitlab.xfce.org/xfce/tumbler/-/commit/95244ee0d1f3184e2c2cae9d33095dc03829b10e] | ||
| 15 | |||
| 16 | Signed-off-by: Zhang Peng <peng.zhang1.cn@windriver.com> | ||
| 17 | --- | ||
| 18 | tumbler/tumbler-cache-plugin.c | 5 ++++- | ||
| 19 | tumblerd/tumbler-registry.c | 7 ++++++- | ||
| 20 | 2 files changed, 10 insertions(+), 2 deletions(-) | ||
| 21 | |||
| 22 | diff --git a/tumbler/tumbler-cache-plugin.c b/tumbler/tumbler-cache-plugin.c | ||
| 23 | index 50700a3..e308638 100644 | ||
| 24 | --- a/tumbler/tumbler-cache-plugin.c | ||
| 25 | +++ b/tumbler/tumbler-cache-plugin.c | ||
| 26 | @@ -188,7 +188,10 @@ tumbler_cache_plugin_get_default (void) | ||
| 27 | g_object_add_weak_pointer (G_OBJECT (plugin), (gpointer) &plugin); | ||
| 28 | |||
| 29 | if (!g_type_module_use (G_TYPE_MODULE (plugin))) | ||
| 30 | - return NULL; | ||
| 31 | + { | ||
| 32 | + g_object_unref (plugin); | ||
| 33 | + return NULL; | ||
| 34 | + } | ||
| 35 | } | ||
| 36 | |||
| 37 | return G_TYPE_MODULE (plugin); | ||
| 38 | diff --git a/tumblerd/tumbler-registry.c b/tumblerd/tumbler-registry.c | ||
| 39 | index 705dbc9..b58e831 100644 | ||
| 40 | --- a/tumblerd/tumbler-registry.c | ||
| 41 | +++ b/tumblerd/tumbler-registry.c | ||
| 42 | @@ -534,7 +534,12 @@ tumbler_registry_update_supported (TumblerRegistry *registry) | ||
| 43 | |||
| 44 | /* abort if there are no thumbnailers */ | ||
| 45 | if (thumbnailers == NULL) | ||
| 46 | - return; | ||
| 47 | + { | ||
| 48 | + /* we need NULL-terminated arrays for the _get_supported() dbus call anyway */ | ||
| 49 | + registry->uri_schemes = g_new0 (gchar *, 1); | ||
| 50 | + registry->mime_types = g_new0 (gchar *, 1); | ||
| 51 | + return; | ||
| 52 | + } | ||
| 53 | |||
| 54 | /* clear visited flag of all thumbnailers */ | ||
| 55 | for (lp = thumbnailers; lp != NULL; lp = lp->next) | ||
| 56 | -- | ||
| 57 | 2.50.0 | ||
diff --git a/meta-xfce/recipes-xfce/tumbler/tumbler_4.20.1.bb b/meta-xfce/recipes-xfce/tumbler/tumbler_4.21.1.bb index 7a01882d57..7ab4b59416 100644 --- a/meta-xfce/recipes-xfce/tumbler/tumbler_4.20.1.bb +++ b/meta-xfce/recipes-xfce/tumbler/tumbler_4.21.1.bb | |||
| @@ -5,23 +5,26 @@ LICENSE = "GPL-2.0-or-later" | |||
| 5 | LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263" | 5 | LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263" |
| 6 | DEPENDS = "xfce4-dev-tools-native libxfce4util" | 6 | DEPENDS = "xfce4-dev-tools-native libxfce4util" |
| 7 | 7 | ||
| 8 | XFCE_COMPRESS_TYPE = "xz" | ||
| 9 | XFCEBASEBUILDCLASS = "meson" | ||
| 10 | GTKDOC_MESON_OPTION = "gtk-doc" | ||
| 11 | |||
| 8 | inherit xfce gtk-doc systemd | 12 | inherit xfce gtk-doc systemd |
| 9 | 13 | ||
| 10 | SRC_URI[sha256sum] = "87b90df8f30144a292d70889e710c8619d8b8803f0e1db3280a4293367a42eae" | 14 | SRC_URI += " file://0001-Handle-cases-where-there-are-no-plugins-gracefully.patch" |
| 15 | SRC_URI[sha256sum] = "0f499f79a2a7ee49726a433584dd8a680d514101b72bd1b003360611ce1dc244" | ||
| 11 | 16 | ||
| 12 | INSANE_SKIP:${PN} = "dev-so" | 17 | INSANE_SKIP:${PN} = "dev-so" |
| 13 | 18 | ||
| 14 | PACKAGECONFIG ??= "" | 19 | PACKAGECONFIG ??= "" |
| 15 | PACKAGECONFIG[cover-thumbnailer] = "--enable-cover-thumbnailer,--disable-cover-thumbnailer,curl gdk-pixbuf" | 20 | PACKAGECONFIG[cover-thumbnailer] = "-Dcover-thumbnailer=enabled,-Dcover-thumbnailer=disabled,curl gdk-pixbuf" |
| 16 | PACKAGECONFIG[desktop-thumbnailer] = "--enable-desktop-thumbnailer,--disable-desktop-thumbnailer,gdk-pixbuf" | 21 | PACKAGECONFIG[desktop-thumbnailer] = "-Ddesktop-thumbnailer=enabled,-Ddesktop-thumbnailer=disabled,gdk-pixbuf" |
| 17 | PACKAGECONFIG[font-thumbnailer] = "--enable-font-thumbnailer,--disable-font-thumbnailer,freetype gdk-pixbuf" | 22 | PACKAGECONFIG[font-thumbnailer] = "-Dfont-thumbnailer=enabled,-Dfont-thumbnailer=disabled,freetype gdk-pixbuf" |
| 18 | PACKAGECONFIG[gstreamer-thumbnailer] = "--enable-gstreamer-thumbnailer,--disable-gstreamer-thumbnailer,gstreamer1.0 gstreamer1.0-plugins-base" | 23 | PACKAGECONFIG[gstreamer-thumbnailer] = "-Dgst-thumbnailer=enabled,-Dgst-thumbnailer=disabled,gstreamer1.0 gstreamer1.0-plugins-base" |
| 19 | PACKAGECONFIG[jpeg-thumbnailer] = "--enable-jpeg-thumbnailer,--disable-jpeg-thumbnailer,gdk-pixbuf" | 24 | PACKAGECONFIG[jpeg-thumbnailer] = "-Djpeg-thumbnailer=enabled,-Djpeg-thumbnailer=disabled,gdk-pixbuf" |
| 20 | PACKAGECONFIG[odf-thumbnailer] = "--enable-odf-thumbnailer,--disable-odf-thumbnailer,gdk-pixbuf libxml2 libgsf" | 25 | PACKAGECONFIG[odf-thumbnailer] = "-Dodf-thumbnailer=enabled,-Dodf-thumbnailer=disabled,gdk-pixbuf libxml2 libgsf" |
| 21 | PACKAGECONFIG[pixbuf-thumbnailer] = "--enable-pixbuf-thumbnailer,--disable-pixbuf-thumbnailer,gdk-pixbuf" | 26 | PACKAGECONFIG[pixbuf-thumbnailer] = "-Dpixbuf-thumbnailer=enabled,-Dpixbuf-thumbnailer=disabled,gdk-pixbuf" |
| 22 | PACKAGECONFIG[poppler-thumbnailer] = "--enable-poppler-thumbnailer,--disable-poppler-thumbnailer,gdk-pixbuf poppler" | 27 | PACKAGECONFIG[poppler-thumbnailer] = "-Dpoppler-thumbnailer=enabled,-Dpoppler-thumbnailer=disabled,gdk-pixbuf poppler" |
| 23 | |||
| 24 | EXTRA_OECONF = "GDBUS_CODEGEN=${STAGING_BINDIR_NATIVE}/gdbus-codegen" | ||
| 25 | 28 | ||
| 26 | do_install:append() { | 29 | do_install:append() { |
| 27 | # Makefile seems to race on creation of symlink. So ensure creation here | 30 | # Makefile seems to race on creation of symlink. So ensure creation here |
