diff options
| author | Michael Opdenacker <michael.opdenacker@bootlin.com> | 2021-08-09 17:48:44 +0200 |
|---|---|---|
| committer | Khem Raj <raj.khem@gmail.com> | 2021-08-09 10:20:30 -0700 |
| commit | 5013bd7b3040e3249ca632f507cffa14ff80e757 (patch) | |
| tree | 0c3c19491f87345308131b8f12c86fcf800dd56b | |
| parent | a4791bf2f37de55dd51971d34ac2252d3cf68f30 (diff) | |
| download | meta-openembedded-5013bd7b3040e3249ca632f507cffa14ff80e757.tar.gz | |
vorbis-tools: update to 1.4.2 (latest in 1.4.x series)
This allows to get rid of 2 patches,
included in this release
Update the gettext patch, still not applied in this version
Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
| -rw-r--r-- | meta-multimedia/recipes-multimedia/vorbis-tools/vorbis-tools/0001-oggenc-Fix-large-alloca-on-bad-AIFF-input.patch | 49 | ||||
| -rw-r--r-- | meta-multimedia/recipes-multimedia/vorbis-tools/vorbis-tools/0004-Fix-format-error-blocking-compilation-with-hardening.patch | 26 | ||||
| -rw-r--r-- | meta-multimedia/recipes-multimedia/vorbis-tools/vorbis-tools/gettext.patch | 32 | ||||
| -rw-r--r-- | meta-multimedia/recipes-multimedia/vorbis-tools/vorbis-tools_1.4.2.bb (renamed from meta-multimedia/recipes-multimedia/vorbis-tools/vorbis-tools_1.4.0.bb) | 6 |
4 files changed, 18 insertions, 95 deletions
diff --git a/meta-multimedia/recipes-multimedia/vorbis-tools/vorbis-tools/0001-oggenc-Fix-large-alloca-on-bad-AIFF-input.patch b/meta-multimedia/recipes-multimedia/vorbis-tools/vorbis-tools/0001-oggenc-Fix-large-alloca-on-bad-AIFF-input.patch deleted file mode 100644 index b623dbf37e..0000000000 --- a/meta-multimedia/recipes-multimedia/vorbis-tools/vorbis-tools/0001-oggenc-Fix-large-alloca-on-bad-AIFF-input.patch +++ /dev/null | |||
| @@ -1,49 +0,0 @@ | |||
| 1 | Upstream-Status: Backport | ||
| 2 | |||
| 3 | Backport patch to fix CVE-2015-6749 from: | ||
| 4 | |||
| 5 | https://trac.xiph.org/ticket/2212 | ||
| 6 | |||
| 7 | Signed-off-by: Kai Kang <kai.kang@windriver.com> | ||
| 8 | --- | ||
| 9 | From 04815d3e1bfae3a6cdfb2c25358a5a72b61299f7 Mon Sep 17 00:00:00 2001 | ||
| 10 | From: Mark Harris <mark.hsj@gmail.com> | ||
| 11 | Date: Sun, 30 Aug 2015 05:54:46 -0700 | ||
| 12 | Subject: [PATCH] oggenc: Fix large alloca on bad AIFF input | ||
| 13 | |||
| 14 | Fixes #2212 | ||
| 15 | --- | ||
| 16 | oggenc/audio.c | 10 +++++----- | ||
| 17 | 1 file changed, 5 insertions(+), 5 deletions(-) | ||
| 18 | |||
| 19 | diff --git a/oggenc/audio.c b/oggenc/audio.c | ||
| 20 | index 477da8c..4921fb9 100644 | ||
| 21 | --- a/oggenc/audio.c | ||
| 22 | +++ b/oggenc/audio.c | ||
| 23 | @@ -245,8 +245,8 @@ static int aiff_permute_matrix[6][6] = | ||
| 24 | int aiff_open(FILE *in, oe_enc_opt *opt, unsigned char *buf, int buflen) | ||
| 25 | { | ||
| 26 | int aifc; /* AIFC or AIFF? */ | ||
| 27 | - unsigned int len; | ||
| 28 | - unsigned char *buffer; | ||
| 29 | + unsigned int len, readlen; | ||
| 30 | + unsigned char buffer[22]; | ||
| 31 | unsigned char buf2[8]; | ||
| 32 | aiff_fmt format; | ||
| 33 | aifffile *aiff = malloc(sizeof(aifffile)); | ||
| 34 | @@ -269,9 +269,9 @@ int aiff_open(FILE *in, oe_enc_opt *opt, unsigned char *buf, int buflen) | ||
| 35 | return 0; /* Weird common chunk */ | ||
| 36 | } | ||
| 37 | |||
| 38 | - buffer = alloca(len); | ||
| 39 | - | ||
| 40 | - if(fread(buffer,1,len,in) < len) | ||
| 41 | + readlen = len < sizeof(buffer) ? len : sizeof(buffer); | ||
| 42 | + if(fread(buffer,1,readlen,in) < readlen || | ||
| 43 | + (len > readlen && !seek_forward(in, len-readlen))) | ||
| 44 | { | ||
| 45 | fprintf(stderr, _("Warning: Unexpected EOF in reading AIFF header\n")); | ||
| 46 | return 0; | ||
| 47 | -- | ||
| 48 | 2.5.0 | ||
| 49 | |||
diff --git a/meta-multimedia/recipes-multimedia/vorbis-tools/vorbis-tools/0004-Fix-format-error-blocking-compilation-with-hardening.patch b/meta-multimedia/recipes-multimedia/vorbis-tools/vorbis-tools/0004-Fix-format-error-blocking-compilation-with-hardening.patch deleted file mode 100644 index 111e98ac1f..0000000000 --- a/meta-multimedia/recipes-multimedia/vorbis-tools/vorbis-tools/0004-Fix-format-error-blocking-compilation-with-hardening.patch +++ /dev/null | |||
| @@ -1,26 +0,0 @@ | |||
| 1 | From: Petter Reinholdtsen <pere@hungry.com> | ||
| 2 | Date: Wed, 22 Oct 2014 13:25:21 +0200 | ||
| 3 | Subject: Fix format error blocking compilation with hardening | ||
| 4 | |||
| 5 | Last-Update: 2014-10-22 | ||
| 6 | Forwarded: no | ||
| 7 | |||
| 8 | Enabling hardening refuses to compile code with sprintf() calls | ||
| 9 | with no formatting string. Adjust the code to work with hardening. | ||
| 10 | --- | ||
| 11 | ogg123/status.c | 2 +- | ||
| 12 | 1 file changed, 1 insertion(+), 1 deletion(-) | ||
| 13 | |||
| 14 | diff --git a/ogg123/status.c b/ogg123/status.c | ||
| 15 | index 92b8ff1..ccec389 100644 | ||
| 16 | --- a/ogg123/status.c | ||
| 17 | +++ b/ogg123/status.c | ||
| 18 | @@ -148,7 +148,7 @@ int print_statistics_line (stat_format_t stats[]) | ||
| 19 | |||
| 20 | switch (stats->type) { | ||
| 21 | case stat_noarg: | ||
| 22 | - len += sprintf(str+len, stats->formatstr); | ||
| 23 | + len += sprintf(str+len, "%s", stats->formatstr); | ||
| 24 | break; | ||
| 25 | case stat_intarg: | ||
| 26 | len += sprintf(str+len, stats->formatstr, stats->arg.intarg); | ||
diff --git a/meta-multimedia/recipes-multimedia/vorbis-tools/vorbis-tools/gettext.patch b/meta-multimedia/recipes-multimedia/vorbis-tools/vorbis-tools/gettext.patch index b61ce7c184..dd03fa9524 100644 --- a/meta-multimedia/recipes-multimedia/vorbis-tools/vorbis-tools/gettext.patch +++ b/meta-multimedia/recipes-multimedia/vorbis-tools/vorbis-tools/gettext.patch | |||
| @@ -2,23 +2,10 @@ Fix build with gettext 0.20.x | |||
| 2 | 2 | ||
| 3 | Upstream-Status: Pending | 3 | Upstream-Status: Pending |
| 4 | Signed-off-by: Khem Raj <raj.khem@gmail.com> | 4 | Signed-off-by: Khem Raj <raj.khem@gmail.com> |
| 5 | 5 | Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com> | |
| 6 | --- a/Makefile.am | ||
| 7 | +++ b/Makefile.am | ||
| 8 | @@ -2,8 +2,8 @@ | ||
| 9 | |||
| 10 | AUTOMAKE_OPTIONS = foreign dist-zip | ||
| 11 | |||
| 12 | -SUBDIRS = po intl include share debian win32 @OPT_SUBDIRS@ | ||
| 13 | -DIST_SUBDIRS = po intl include share debian win32 ogg123 oggenc oggdec ogginfo \ | ||
| 14 | +SUBDIRS = po include share debian win32 @OPT_SUBDIRS@ | ||
| 15 | +DIST_SUBDIRS = po include share debian win32 ogg123 oggenc oggdec ogginfo \ | ||
| 16 | vcut vorbiscomment m4 | ||
| 17 | |||
| 18 | EXTRA_DIST = config.rpath README AUTHORS COPYING CHANGES vorbis-tools.spec config.h mkinstalldirs | ||
| 19 | --- a/configure.ac | 6 | --- a/configure.ac |
| 20 | +++ b/configure.ac | 7 | +++ b/configure.ac |
| 21 | @@ -31,7 +31,7 @@ CFLAGS="$cflags_save" | 8 | @@ -34,7 +34,7 @@ |
| 22 | AC_PROG_LIBTOOL | 9 | AC_PROG_LIBTOOL |
| 23 | 10 | ||
| 24 | ALL_LINGUAS="be cs da en_GB eo es fr hr hu nl pl ro ru sk sv uk vi" | 11 | ALL_LINGUAS="be cs da en_GB eo es fr hr hu nl pl ro ru sk sv uk vi" |
| @@ -27,7 +14,7 @@ Signed-off-by: Khem Raj <raj.khem@gmail.com> | |||
| 27 | 14 | ||
| 28 | dnl -------------------------------------------------- | 15 | dnl -------------------------------------------------- |
| 29 | dnl System checks | 16 | dnl System checks |
| 30 | @@ -383,7 +383,6 @@ AC_OUTPUT([ | 17 | @@ -397,7 +397,6 @@ |
| 31 | Makefile | 18 | Makefile |
| 32 | m4/Makefile | 19 | m4/Makefile |
| 33 | po/Makefile.in | 20 | po/Makefile.in |
| @@ -35,3 +22,16 @@ Signed-off-by: Khem Raj <raj.khem@gmail.com> | |||
| 35 | include/Makefile | 22 | include/Makefile |
| 36 | share/Makefile | 23 | share/Makefile |
| 37 | win32/Makefile | 24 | win32/Makefile |
| 25 | --- a/Makefile.am | ||
| 26 | +++ b/Makefile.am | ||
| 27 | @@ -2,8 +2,8 @@ | ||
| 28 | |||
| 29 | AUTOMAKE_OPTIONS = foreign dist-zip | ||
| 30 | |||
| 31 | -SUBDIRS = po intl include share win32 @OPT_SUBDIRS@ | ||
| 32 | -DIST_SUBDIRS = po intl include share win32 ogg123 oggenc oggdec ogginfo \ | ||
| 33 | +SUBDIRS = po include share win32 @OPT_SUBDIRS@ | ||
| 34 | +DIST_SUBDIRS = po include share win32 ogg123 oggenc oggdec ogginfo \ | ||
| 35 | vcut vorbiscomment m4 | ||
| 36 | |||
| 37 | EXTRA_DIST = config.rpath README AUTHORS COPYING CHANGES | ||
diff --git a/meta-multimedia/recipes-multimedia/vorbis-tools/vorbis-tools_1.4.0.bb b/meta-multimedia/recipes-multimedia/vorbis-tools/vorbis-tools_1.4.2.bb index 89e66528ac..f399bfaa28 100644 --- a/meta-multimedia/recipes-multimedia/vorbis-tools/vorbis-tools_1.4.0.bb +++ b/meta-multimedia/recipes-multimedia/vorbis-tools/vorbis-tools_1.4.2.bb | |||
| @@ -11,13 +11,11 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f" | |||
| 11 | DEPENDS = "libogg libvorbis" | 11 | DEPENDS = "libogg libvorbis" |
| 12 | 12 | ||
| 13 | SRC_URI = "http://downloads.xiph.org/releases/vorbis/${BP}.tar.gz \ | 13 | SRC_URI = "http://downloads.xiph.org/releases/vorbis/${BP}.tar.gz \ |
| 14 | file://0001-oggenc-Fix-large-alloca-on-bad-AIFF-input.patch \ | ||
| 15 | file://0004-Fix-format-error-blocking-compilation-with-hardening.patch \ | ||
| 16 | file://gettext.patch \ | 14 | file://gettext.patch \ |
| 17 | " | 15 | " |
| 18 | 16 | ||
| 19 | SRC_URI[md5sum] = "567e0fb8d321b2cd7124f8208b8b90e6" | 17 | SRC_URI[md5sum] = "998fca293bd4e4bdc2b96fb70f952f4e" |
| 20 | SRC_URI[sha256sum] = "a389395baa43f8e5a796c99daf62397e435a7e73531c9f44d9084055a05d22bc" | 18 | SRC_URI[sha256sum] = "db7774ec2bf2c939b139452183669be84fda5774d6400fc57fde37f77624f0b0" |
| 21 | 19 | ||
| 22 | inherit autotools pkgconfig gettext | 20 | inherit autotools pkgconfig gettext |
| 23 | 21 | ||
