diff options
| author | Yogesh Tyagi <yogesh.tyagi@intel.com> | 2026-05-12 23:14:43 +0800 |
|---|---|---|
| committer | Yogesh Tyagi <yogesh.tyagi@intel.com> | 2026-05-12 23:28:51 +0800 |
| commit | 2a8d44bf7b9faca3935b851107c70754e1cdcae3 (patch) | |
| tree | a6f634dc1468030bd1a10ee20cf1eaa689d6985b /lib | |
| parent | 447287c57ef405c37271178b26db7750c6bdaf1c (diff) | |
| download | meta-intel-2a8d44bf7b9faca3935b851107c70754e1cdcae3.tar.gz | |
libipt: drop pttc nasm patch and runtime QA case
The 0001-pttc-use-nasm-instead-of-yasm.patch local patch reworked
upstream pttc to invoke nasm in place of the unmaintained yasm
assembler. The patch was submitted upstream
(https://github.com/intel/libipt/pull/120) but has not been merged,
and carrying it locally is the only reason meta-intel needs to
diverge from a pristine stable/v2.2 checkout. Drop the patch and
let pttc fall back to upstream's stock yasm-based behaviour.
This matches what Fedora/RHEL already does for the libipt package:
ship libipt without yasm support and let libipt's own CMake skip
the yasm-driven ptt tests automatically when yasm isn't available.
Native nasm support in pttc remains a future upstream enhancement;
when it lands we can revisit and re-add a runtime case that
exercises pttc end-to-end against nasm.
The libipt runtime test (lib/oeqa/runtime/cases/libipt.py) gated
on the 'nasm' package and ran pttc on the shipped sample .ptt
files. With the patch removed pttc invokes yasm at runtime, so the
test would fail on every DUT (yasm is not pulled in as an RDEPENDS
anywhere in meta-intel). The test exercised pttc/ptdump end-to-end,
not the libipt library itself, and library coverage is provided
indirectly by anything that links against libipt2; the runtime case
has no remaining utility once the assembler-substitution patch is
gone.
No change to the recipe's PACKAGES, FILES, or EXTRA_OECMAKE: the
libipt-test sub-package still ships pttc, ptdump, ptseg and the
.ptt sample sources under ${bindir}/libipt for any user that
installs yasm out-of-band and wants to drive pttc manually. This
matches the Fedora libipt RPM behaviour.
Signed-off-by: Yogesh Tyagi <yogesh.tyagi@intel.com>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/oeqa/runtime/cases/libipt.py | 23 |
1 files changed, 0 insertions, 23 deletions
diff --git a/lib/oeqa/runtime/cases/libipt.py b/lib/oeqa/runtime/cases/libipt.py deleted file mode 100644 index dd31a538..00000000 --- a/lib/oeqa/runtime/cases/libipt.py +++ /dev/null | |||
| @@ -1,23 +0,0 @@ | |||
| 1 | from oeqa.runtime.case import OERuntimeTestCase | ||
| 2 | from oeqa.runtime.decorator.package import OEHasPackage | ||
| 3 | from oeqa.core.decorator.depends import OETestDepends | ||
| 4 | |||
| 5 | class LibiptTest(OERuntimeTestCase): | ||
| 6 | libipt_bin_dir = '/usr/bin/libipt/' | ||
| 7 | |||
| 8 | @classmethod | ||
| 9 | def tearDownClass(cls): | ||
| 10 | cls.tc.target.run('rm /tmp/loop-tnt*') | ||
| 11 | |||
| 12 | @OEHasPackage(['libipt', 'libipt2']) | ||
| 13 | @OEHasPackage(['libipt-test']) | ||
| 14 | @OEHasPackage(['nasm']) | ||
| 15 | def test_libipt_can_generate_trace_packet(self): | ||
| 16 | (status, output) = self.target.run('cd /tmp; %spttc %s/tests/loop-tnt.ptt' % | ||
| 17 | (self.libipt_bin_dir, self.libipt_bin_dir)) | ||
| 18 | self.assertEqual(status, 0, msg='status and output: %s and %s' % (status, output)) | ||
| 19 | |||
| 20 | @OETestDepends(['libipt.LibiptTest.test_libipt_can_generate_trace_packet']) | ||
| 21 | def test_libipt_can_perform_trace_packet_dump(self): | ||
| 22 | (status, output) = self.target.run('cd /tmp; %sptdump loop-tnt.pt' % self.libipt_bin_dir) | ||
| 23 | self.assertEqual(status, 0, msg='status and output: %s and %s' % (status, output)) | ||
