| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
| |
kernel-module-split names the split package kernel-module-<module>-
${KERNEL_VERSION}, so INSANE_SKIP:kernel-module-${KERNEL_VERSION} never
matched a package this recipe produces, and ERROR_QA:remove was the
workaround for that. Naming the real package makes the skip apply and
the workaround redundant. On imx8mp-lpddr4-evk a cleansstate rebuild
passes without ERROR_QA:remove, dropping the INSANE_SKIP as a control
fails with buildpaths on the module, and buildhistory is unchanged.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PACKAGES_DYNAMIC += "^kernel-module-.*" is too broad: it makes
jailhouse-imx a candidate runtime provider for every kernel-module-*
virtual package in the layer. Recipes such as iptables RRECOMMENDS
kernel-module-* names (e.g. kernel-module-x-tables); via
do_package_qa[rdeptask] = "do_packagedata" these resolve to a provider,
and because BitBake sorts providers alphabetically jailhouse-imx is
picked ahead of linux-imx. This pulls jailhouse-imx into the task graph
of unrelated recipes and hence into core-image-minimal even when
jailhouse is not installed.
Narrow the pattern to this recipe's own module so the vars.specific lint
finding is still resolved without advertising foreign kernel-module-*
names. After the change kernel-module-x-tables etc. fall back to
linux-imx and 'oe-depends-dot -k jailhouse-imx' returns no path.
Verified on imx8mp-lpddr4-evk (mx8m-nxp-bsp) with bitbake -g
core-image-minimal: the iptables do_package_qa/do_package_write_deb
edges now point at linux-imx.do_packagedata and jailhouse no longer
appears anywhere in task-depends.dot.
Signed-off-by: Zelan Zou <zelan.zou@nxp.com>
|
| |\
| |
| | |
oelint: Resolve vars.specific on dynamic split packages via PACKAGES_DYNAMIC
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
kernel-module-${KERNEL_VERSION} is generated by the kernel-module-split
class (inherit module), so a standalone oelint run cannot see it and
flags INSANE_SKIP:kernel-module-${KERNEL_VERSION} with
oelint.vars.specific.
Declare the package family via PACKAGES_DYNAMIC += "^kernel-module-.*"
so the linter recognises it, replacing the vars.specific part of the
inline suppression with a real declaration. ${KERNEL_VERSION} is
resolved at build time, so the pattern matches on the literal prefix.
The separate oelint.vars.insaneskip suppression on the same line is
kept -- that skip is still required. STRUCTURAL FIX.
Buildhistory-validated output-neutral on imx8mp-lpddr4-evk
(mx8m-nxp-bsp): a baseline vs candidate rebuild with do_package forced
produced a zero buildhistory delta -- the kernel-module-jailhouse-*
package and all jailhouse-imx sub-packages are byte-identical before
and after.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
INSANE_SKIP:kernel-module-${KERNEL_VERSION} targets the out-of-tree
kernel module package created dynamically by the kernel-module-split
class, which this recipe inherits via 'inherit module'. oelint-adv
parses the recipe without that oe-core class on its analyzer path, so it
cannot see the package and reports the assignment as oelint.vars.specific
("set specific to a package not known from PACKAGES").
This is a false positive from missing analyzer context, not a recipe
defect: the INSANE_SKIP is the intended per-package QA skip for the
module package. No structural fix applies, and the rule has no
constant-DB hook for known package names. Extend the existing
# nooelint: oelint.vars.insaneskip directive on this line to also cover
oelint.vars.specific, and add a comment explaining the module-package
provenance.
Suppression-only change (comments and the nooelint annotation only); the
effective BitBake metadata is unchanged, so build and buildhistory
validation were skipped.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
do_install:append copies the NXP DPDK config tree into ${sysconfdir}/dpdk
with plain cp -rf, which oelint.task.nocopy flags because cp inherits
the invoking user's ownership. This is a recursive directory copy that
install(1) cannot replace; add --no-preserve=ownership, the alternative
the rule documents, and keep the -r/-f flags.
Validated with buildhistory: rebuilt dpdk for MACHINE=ls1046ardb with
and without this change; all dpdk* packages are byte-identical (file
lists including the /etc/dpdk config files, PKGSIZE and RDEPENDS
unchanged), because packaging runs under pseudo and records the files as
root-owned regardless.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
do_install:append copies header trees into the sysroot with plain
cp -rf, which oelint.task.nocopy flags because cp inherits the invoking
user's umask/ownership. These are recursive glob copies of header
directories, so install(1) cannot replace them; add --no-preserve=
ownership, the alternative the rule documents, to keep the recursive
copy while dropping the ownership dependency.
Validated with buildhistory: rebuilt odp for MACHINE=ls1046ardb with
and without this change; the odp* packages are byte-identical (file
lists, sizes and RDEPENDS unchanged), because packaging already runs
under pseudo and records the files as root-owned regardless.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
The hypervisor firmware and inmate binaries are linked bare-metal (the
recipe passes LDFLAGS="") and the vendor Makefile bakes build paths into
them, so the ldflags and buildpaths QA checks cannot pass for the runtime,
-dbg and kernel-module packages. The INSANE_SKIP entries are required.
Add an inline # nooelint directive to each and record the semantic reason
the QA checks do not apply. No effective metadata changes: only comments
were added.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Per review, put an empty opening quote and move every URI onto an aligned
continuation line. The space after the opening quote stays, so BitBake
still separates the appended URIs from the base SRC_URI when it joins the
:append with no separator. This satisfies oelint.vars.multilineident
without a nooelint directive.
SRC_URI is whitespace-split, so the fetched sources are unchanged.
Comment-and-whitespace change only.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
oelint.var.filesoverride flags FILES:pyjailhouse. The package is added via
PACKAGE_BEFORE_PN and never otherwise set, so switch it to += : the assignment
is behaviourally identical (verified with bitbake -e before/after on
imx8mp-lpddr4-evk, FILES expansion unchanged) and no longer trips the check.
No functional change.
Tested with jailhouse-imx on imx8mp-lpddr4-evk; buildhistory unchanged.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HOMEPAGE was "http://dpdk.org". The bare apex host no longer serves:
both http://dpdk.org and https://dpdk.org fail to connect, while
https://www.dpdk.org returns 200. Use the canonical https www URL.
Found via oelint.vars.homepageping. The rule is network-dependent, so
the result was cross-checked by hand rather than taken from the scan:
general egress from the scanning host is working (yoctoproject.org,
gstreamer.freedesktop.org and khronos.org all answer 200) and dpdk.org
resolves in DNS, so the failure is the host not serving rather than a
local network restriction.
The other four homepageping findings in the layer are deliberately left
alone: gstreamer1.0-python, gstreamer1.0-rtsp-server and the glslang
downgrade carry the same HOMEPAGE as the openembedded-core recipes they
are copies of, so the stale URL belongs upstream; and pktgen-dpdk's
HOMEPAGE host is the same host its SRC_URI fetches from, which makes it
a fetch question that needs a build to answer, not a metadata edit.
HOMEPAGE is descriptive metadata and is not a buildhistory-tracked
field. Verified with oelint-adv 9.10.1 (recipe now scans clean, nothing
introduced) and bitbake -p (1166 recipes, 0 errors).
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Each of these recipes suppresses a rule on two or more consecutive lines
but states the reason only above the first directive, so every following
one reads as an undocumented exception. A rationale is only discoverable
on the comment line immediately above the directive it justifies.
Add that back-reference at each remaining site:
libpkcs11, secure-obj insaneskip on the -dev package
merge-files insaneskip for the dev-so QA check
ovs-dpdk insaneskip for buildpaths on the main package
imx-atf inconspaces on the two ANNOTATED_NAME appends
libdrm .imx var.order inside the vivante block
ethos-u-driver-stack pythonprefix on the shell do_install
No suppression is added or removed, and no rationale is invented: each
one points at the explanation already written directly above it. With
this, the layer has no inline suppression left without an adjacent
rationale.
Comment-only change, verified with oelint-adv 9.10.1 (no finding
introduced in any of the seven recipes) and bitbake -p (1166 recipes, 0
errors).
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The recipe still tracked lf-6.12.20_2.0.0 while the rest of the layer
moved on to NXP's 6.18 releases, and that mismatch made it unbuildable:
driver/sysfs.c hands a plain "struct bin_attribute *" to the sysfs read
callback, but the kernel made that pointer const in 6.16. NXP guarded
the signature with LINUX_VERSION_CODE on the 6.18 branches, so move to
lf-6.18.20_2.0.0, the release libcamera and the multimedia recipes
already track.
Drop both YOCIMX-9281 patches, which NXP has merged -- each one
reverse-applies cleanly against the new SRCREV. Keep the -march removal
patch: it is oe-specific and hypervisor/arch/arm64/Makefile still sets
-march=armv8-a+nofp upstream.
PV is left alone. It is a hand-set NXP branch marker rather than
anything derived from upstream, which still reports v0.12 in its VERSION
file on both branches; SRCREV is what identifies the new snapshot.
Dropping the deprecated ${SRCPV} from it would change PKGV and so needs
its own validation, which does not belong in this change.
Append to PACKAGE_BEFORE_PN rather than assigning it, so the entry
bash-completion.bbclass contributes survives. Assigning dropped it from
PACKAGES, leaving the jailhouse-completion.bash that tools/Makefile
installs with no package to claim it, and do_package failed on the
unshipped file. The defect goes back to the recipe's introduction in
46a2165f0 ("jailhouse: add imx version") and was simply unreachable
while do_compile still failed.
Also sort DEPENDS alphabetically, per oelint.vars.dependsordered.
DEPENDS is a set, so the order carries no meaning.
Tested with bitbake jailhouse-imx on imx8mq-evk against linux-fslc-imx
6.18.24; module and tools package cleanly.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Set doc strings on the custom functions oelint-adv reports via
'oelint.task.docstrings': the three i.MX boot firmware deploy helpers,
the libubootenv uboot-config fixup handler, the qemu-qoriq wrapper
generator, the testfloat SoftFloat unpack step, the linux-imx device
tree compatibility handler and the imx-mp4-parser QA-skip hook.
imx-mp4-parser reuses the wording already used for the identical hook in
imx-parser, so the two prebuilt-binary recipes read the same.
opencv and libcamera are deliberately left alone. Both recipes carry
their upstream recipe as a marked verbatim block ("meta-openembedded
copy"), and the two functions oelint flags -- do_unpack_extra and
do_package_recalculate_ipa_signatures -- sit inside those blocks, where
meta-openembedded sets no doc string. Annotating them would break the
diff against upstream for no functional gain, so those two findings stay
visible.
bitbake never reads the 'doc' flag when computing task checksums --
bb/data.py build_dependencies() only consults vardeps, vardepvalue,
vardepsexclude, exports, postfuncs, prefuncs, lineno and filename -- so
these additions cannot change a signature or invalidate sstate.
Verified by re-linting each file.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |\
| |
| | |
oelint: Recipe SECTION/DEPENDS metadata and patch Upstream-Status cleanups
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
oelint.file.inappropriatemsg does not recognise the free-form reason
"See above". Use the canonical "oe-specific" token, which accurately
describes the patch: it drops the hardcoded -march so the OE recipe
owns the compilation flags (accommodating poky commit 04eac1f2b6). The
explanatory text above the trailer is retained.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
oelint flagged DEPENDS, PV and SRCREV out of canonical order and
RPROVIDES placed ahead of the fetch group. Reorder the header to
DEPENDS, PROVIDES, PV, SRC_URI, SRCREV and move RPROVIDES:${PN} down to
the runtime-packaging section next to RDEPENDS. Pure reordering, no
functional change.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |/
|
|
|
|
|
|
|
|
| |
oelint flagged SRC_URI placed after PACKAGE_ARCH. Move PACKAGE_ARCH
down to group it with COMPATIBLE_MACHINE at the end of the recipe,
matching the layer's machine-variable convention and keeping the
SRC_URI/SRCREV fetch group next to DEPENDS. Pure reordering, no
functional change.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
| |
Move DEPENDS and EXTRA_OECONF into canonical order (DEPENDS before
SRC_URI, EXTRA_OECONF before PACKAGE_ARCH), clearing oelint's
order.DEPENDS and order.EXTRA_OECONF.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |\
| |
| |
| |
| | |
lucianogdittgen/oelint-cleanup-11-recipe-metadata-7
oelint: Recipe metadata, do_install and split-package FILES cleanups
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Address the oelint findings for the recipe:
- Drop the redundant -f from the recursive copy in the do_install find
-exec ("cp -fr" -> "cp -r"). The destination is freshly created, so
forcing is unnecessary and the recursive form clears task.nocopy.
- The recipe ships no source tree of its own, so keep the shared
common-licenses MIT reference and accept licenseremotefile.
- The package deliberately merges arbitrary prebuilt files anywhere under
the rootfs, so keep FILES:${PN} = "/*" and the dev-so INSANE_SKIP,
accepting filesoverride and insaneskip with an inline # nooelint.
No functional change.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Address the oelint findings for the recipe:
- Add SECTION = "console/network".
- Drop the redundant FILESEXTRAPATHS:prepend. The only local file (the
BIN_LDFLAGS patch) lives in ${THISDIR}/${PN}, which is already part of
the default FILESPATH (${FILE_DIRNAME}/${BPN}), so the override was a
no-op and tripped outofcontext/fileextrapaths in this plain recipe.
- Fold the separate SRC_URI:append patch entry into the main SRC_URI so
it precedes SRCREV (order.SRC_URI).
- Keep the explicit FILES:${PN} (the unversioned libtsn.so is
intentionally shipped in the main package, matching the dev-so skip)
and the INSANE_SKIP, accepting both with an inline # nooelint.
No functional change.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The kernel module recipe inherited only the DESCRIPTION from
secure-obj.inc, so oelint flagged the missing SUMMARY (mandatory) and
SECTION (suggested). Add a module-specific SUMMARY and set
SECTION = "kernel/modules".
No functional change.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Address the oelint findings for the secure-obj recipe and its shared
secure-obj.inc:
- Add SUMMARY and SECTION to the recipe and expand the terse DESCRIPTION
in the include (mandatoryvar.SUMMARY, suggestedvar.SECTION).
- Replace the seven "cp" calls in do_install with "install", using the
appropriate modes (0644 for the TA blob and headers, 0755 for the
shared objects and application binaries). The source trees are flat,
so the globbed forms map directly (task.nocopy).
- Move FILES:${PN} above RDEPENDS (order.FILES), move the include's
"DEPENDS +=" above RDEPENDS, and relocate the include's RDEPENDS to
the end so SRC_URI precedes it (order.DEPENDS, cascaded order.SRC_URI).
- Switch the recipe's INSANE_SKIP:${PN} to "+= dev-deps" so it augments
rather than overwrites the include's value (var.override).
- The canonical "DEPENDS =" in the include and the remaining INSANE_SKIP
settings are intrinsic here, so accept them with inline # nooelint
(dependsappend, insaneskip).
The only remaining finding, vars.specific on ARCH:qoriq-arm, is a
single-file-scan artifact absent from the full-layer baseline and is
left untouched. secure-obj-module's own SUMMARY/SECTION are handled
separately.
No functional change.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |\ \
| | |
| | | |
oelint metadata cleanup: add SUMMARY/DESCRIPTION/SECTION and version recipe filenames
|
| | |/
| |
| |
| |
| |
| |
| | |
Add a DESCRIPTION for the i.MX Jailhouse hypervisor fork
(mandatoryvar.DESCRIPTION). No functional change.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Add SUMMARY and SECTION = "libs" and expand DESCRIPTION into a distinct
fuller sentence (oelint.var.mandatoryvar.SUMMARY,
oelint.var.suggestedvar.SECTION).
Give the 0001 patch Upstream-Status an '[oe-specific]' reason, since it
drops -march/-mcpu that Yocto already passes
(oelint.file.inappropriatemsg), and accept INSANE_SKIP:${PN} = "dev-so"
inline as DPDK ships its .so files in the main runtime package
(oelint.vars.insaneskip).
No functional change.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
OE-core now parses LICENSE as an SPDX expression, so the legacy
"&" and "|" operators and non-SPDX names trigger warnings/errors during
parsing.
- pktgen-dpdk, skmm-ep, kernel-module-ar and skmm-host actually failed
parsing with a QA error (LicenseRef-BSD has no generic license file
since it was dropped from oe-core). Add NO_GENERIC_LICENSE[BSD] entries
pointing at their existing license text file to fix them
- Prefix non-SPDX license names with "LicenseRef-"
- Replace "&" with "AND" and "|" with "OR"
Signed-off-by: Antoine Gouby <antoine.gouby@toradex.com>
|
| |\
| |
| |
| |
| | |
lucianogdittgen/oelint-cleanup-10-recipe-metadata-6
oelint: Class/anon-python docstrings, image and packagegroup metadata
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Address the oelint-adv findings for this recipe:
- Add a SUMMARY and expand the terse DESCRIPTION into a full sentence
(mandatoryvar.SUMMARY, keeping DESCRIPTION longer than SUMMARY).
- Set SECTION = "console/network" to classify the traffic generator
(suggestedvar.SECTION).
- Suppress vars.insaneskip on INSANE_SKIP:${PN} = "ldflags": DPDK's
meson build links the application without propagating the distro
LDFLAGS, so the ldflags QA check cannot pass.
No functional change.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Recipes that include odp.inc but are not named odp fail to find the
patch file added by odp.inc.
```
ERROR: /.../meta-freescale/recipes-extended/odp/odp-counters_git.bb: Unable to get checksum for odp-counters SRC_URI entry 0001-Fix-this-build-error.patch: file could not be found
```
Move the patch file from the recipe-specific directory to the shared
files directory to ensure it can be found by all recipes that include
odp.inc, regardless of recipe name.
Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Add SUMMARY and SECTION (expanding DESCRIPTION so it is no longer
briefer than SUMMARY), and move DEPENDS above SRC_URI/SRCREV into the
canonical variable order.
Rewrite do_install to use 'install' instead of mkdir/cp: 'install -d'
for the target directories and 'install -m' for the library (0755),
headers (0644) and app binaries (0755). This is a mechanical translation
that preserves the same destination paths and file set (the pkcs11.h
removal is unchanged); it was not build-tested as the recipe targets
qoriq-arm64.
The two INSANE_SKIP entries are retained and documented with inline
nooelint suppressions, as the library links against sysroot libraries
and ships its .so in the main package.
No functional change intended; recipe-metadata and install-idiom
cleanup.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In odp.inc, remove the FILESEXTRAPATHS:prepend that added ${THISDIR}/odp:
to the file search path. That directory is ${FILE_DIRNAME}/${BPN}, which
the default FILESPATH already searches, so the entry was redundant and
oelint flags FILESEXTRAPATHS as bbappend-only.
In odp_git.bb, reorder into the canonical oelint variable order:
DEPENDS, PACKAGECONFIG, EXTRA_OECONF, PACKAGE_ARCH, FILES, then RDEPENDS
last. Since odp.inc does not set DEPENDS, the plain assignment is the
canonical definition and is documented with an inline nooelint
suppression for the 'append after include' heuristic.
No functional change; the patch is still found via the default
FILESPATH and variable values are unchanged.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a SUMMARY and SECTION, expand DESCRIPTION so it is no longer briefer
than SUMMARY, and reorder into the canonical oelint variable order: move
SRC_URI/SRCREV up into the version group and RDEPENDS down after
PACKAGE_ARCH (RDEPENDS being the last of the ordered variables).
The two INSANE_SKIP buildpaths entries are retained and documented with
inline nooelint suppressions: the upstream build hardcodes cross
host/CFLAGS paths, so the binaries embed build paths that cannot be
scrubbed.
No functional change; pure recipe-metadata cleanup.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
| |
One continuation line in EXTRA_OEMESON was indented with eight spaces
while the rest of the block uses four. Align it with the surrounding
lines. The variable is a whitespace-separated argument list, so the
value is unchanged.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
| |
Add the missing mandatory SUMMARY.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
| |
Add the missing mandatory SUMMARY and set SECTION.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
| |
Add the missing mandatory DESCRIPTION.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
| |
Add the missing mandatory SUMMARY and HOMEPAGE and set SECTION.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
Order DEPENDS alphabetically per oelint.vars.dependsordered. No
functional change.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
Order DEPENDS alphabetically per oelint.vars.dependsordered. No
functional change.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
Order DEPENDS alphabetically per oelint.vars.dependsordered. No
functional change.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
Order the DEPENDS and RDEPENDS:${PN} entries alphabetically per
oelint.vars.dependsordered. No functional change.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Where several versioned recipes share an .inc that already carries the
common metadata (SUMMARY/DESCRIPTION/LICENSE), set HOMEPAGE there once
instead of duplicating it in each .bb: imx-secure-enclave, secure-obj,
qoriq-atf, and u-boot-fslc-common. Removes nine duplicate assignments;
oelint-adv still resolves HOMEPAGE for every consumer via the include.
Recipes whose include carries no metadata (imx-mkimage) or is shared by
different upstreams (linux-imx.inc, used by both linux-fslc and
linux-imx) keep HOMEPAGE in the .bb.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
| |
Add the mandatory HOMEPAGE to recipes whose upstream repository was not a
plain github/gitlab URL in SRC_URI: those using a source variable or an
included .inc (resolved to the real NXP/Freescale repo), and those hosted
elsewhere (denx, SourceForge, dpdk.org, freedesktop, jhauser). Clears the
oelint-adv oelint.var.mandatoryvar.HOMEPAGE error for these recipes.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the mandatory HOMEPAGE to recipes that were missing it, using each
recipe's own upstream git repository (github.com/gitlab.com) taken from
its SRC_URI. Clears the oelint-adv oelint.var.mandatoryvar.HOMEPAGE
error for these recipes.
Only recipes with a single, unambiguous upstream repo were set
automatically; recipes with multiple repos in SRC_URI (a main source
plus dependency/patch repos) were resolved by hand or left for a
maintainer, to avoid pointing HOMEPAGE at a dependency.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
| |
Bring three shell task bodies to consistent 4-space indentation, per the
Yocto Recipe Style Guide. These functions mixed tab and 8-space
indentation; converting the tabs to spaces earlier left the 8-space
statements out of step with their 4-space siblings.
Whitespace only, no functional change.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Align the continuation lines of multi-line variable assignments, as
suggested by oelint-adv's auto-fix for a single rule
(oelint.vars.multilineident), isolated to one commit.
The auto-fix strips the leading space from a value's first line, which
for a ':append' is a required separator; those five recipes had their
leading space restored by hand, so ':append'/':prepend' concatenation
is unchanged. A few multi-line values (e.g. DESCRIPTION) gain internal
whitespace, which is cosmetic and collapses on display.
Build-tested: parsing all 2948 recipes for an i.MX machine reports
0 errors. A residual set (the restored ':append' recipes, whose
separator space oelint cannot reconcile with its indent preference,
plus opencv/dpdk where oelint's own fix does not satisfy its checker)
is left for per-recipe handling.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Convert leading-tab indentation to spaces in shell task bodies across
the layer. Generated mechanically by oelint-adv's auto-fix for a single
rule (oelint.tabs.notabs), isolated to one commit.
Verified safe: every change is leading indentation of shell/BitBake code
(no mid-line tabs, and none of the affected files contain heredocs where
a tab would be significant), so there is no functional change.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the stray space between an assignment's opening quote and its
line-continuation backslash, and the space before '%' in inline
${@...} expressions. Generated mechanically by oelint-adv's auto-fix
for a single rule (oelint.vars.notneededspace), isolated to one commit.
The affected values are whitespace-separated lists (leading space is
insignificant) and Python format expressions ("%s"% p is equivalent),
so there is no functional change; a re-run of oelint-adv reports the
rule clean.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|