| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
| |
The line continuation already separates the value from the entries below;
PACKAGECONFIG_PLATFORM:imxgpu3d in this same bbappend already opens with "\.
Each override was validated on the machine that selects it, with
do_configure forced and buildhistory unchanged: imxgpu2d on imx6slevk,
imxgpu3d on imx8mm-lpddr4-evk.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
| |
The compatibility symlinks installed by this bbappend ship an unversioned
.so in the runtime -plugins package, so the dev-so QA check does not apply
and the INSANE_SKIP is required. Add an inline # nooelint directive with the
semantic reason. No effective metadata changes.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
oelint.vars.multilineident flagged PACKAGECONFIG_GL:imxgpu2d (qt5) and
PACKAGECONFIG_GRAPHICS:imxgpu2d (qt6). The value used a ' gl' token whose
leading space (a PACKAGECONFIG separator inside the string) made the
first continuation line count as one column too wide.
Per review, move the separator out of the token: use an empty opening
quote so BitBake supplies the leading space, and drop the space inside
the token ('gl'). Every item is now on an aligned 4-space continuation
line, which satisfies the rule without a nooelint directive.
PACKAGECONFIG is whitespace-split, so the resolved config list is
unchanged. Both files are dynamic-layer bbappends whose trigger layer is
not checked out in this tree, so this is argued from the metadata, not
measured with buildhistory.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
oelint.vars.noncoreoverride flags every statement in a bbappend that
carries no MACHINE or DISTRO override suffix, because an unconditional
override of core behaviour fails yocto-check-layer. The check is purely
syntactic: it cannot see that a statement's effective value is already
machine-gated, which is exactly how most of this layer is written.
DRM-REMOVE = "" <- flagged
DRM-REMOVE:imxgpu:mx6-nxp-bsp = "drm-gl drm-gles2"
PACKAGECONFIG:remove = "${DRM-REMOVE}" <- flagged
Neither line can be scoped. A fallback default cannot carry an override
for the machines it is the fallback for, and the dispatch line that
consumes it is a no-op wherever the helper expands empty. Scoping them
anyway would damage correct metadata: weston-init reads HAS_G2D as "elif
${HAS_G2D};" in shell, where an empty value is a syntax error.
Suppress the 58 sites proven inert, each with its own rationale. The
proof is a bitbake -e comparison on MACHINE=qemuarm64 -- a machine this
layer does not own -- with meta-freescale in and out of BBLAYERS. At
every suppressed site SRC_URI, DEPENDS, PACKAGECONFIG, OPENGL_PKGCONFIGS
and REQUIRED_DISTRO_FEATURES are unchanged; eight recipes show no
effective difference at all. The helper variables are defined in the
datastore but every consumer is override-scoped. For the 18
FILESEXTRAPATHS sites there is a stronger result: FILESPATH and
FILESEXTRAPATHS are both in BB_BASEHASH_IGNORE_VARS, so they cannot
reach a task signature.
Two anonymous python blocks are deliberately left unsuppressed and
explained in place instead. For those, oelint anchors the finding to the
line before the block, so a directive placed above only moves the anchor
onto itself: the finding survives and inlinesuppress_na is reported for
the directive. oelint.task.noanonpython anchors the same block to the
'python' line and suppresses correctly, so the two rules disagree about
where the construct starts. Upstream oelint bug candidate.
The rule count goes 76 -> 18 and the layer total 548 -> 491. The 16
findings that remain are not noise: they are measured, genuine
unconditional changes to machines this layer does not own, and are left
open for separate fixes.
This change is comment-only; no non-comment line is added or modified.
Validated with bitbake -p (1166 recipes, 0 errors) and an authoritative
driver rescan showing zero introduced findings in any of the 24 edited
files. The residual override/outofcontext churn in the rescan is the
known shared-metadata scan non-determinism and nets to zero.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
| |
Restore the missing Signed-off-by on 0014-Add-IMX-GPU-support.patch,
attributed to its original author per the file's git history
(Tom Hochstein), resolving oelint.file.patchsignedoff.
No functional change.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
meta-freescale used columnar alignment (multiple spaces padding the
variable name out to a common column) for tables of assignments such as
the fsl-eula-unpack MD5 sums and PACKAGECONFIG[...] entries. The Yocto
Recipe Style Guide and oelint-adv (oelint.vars.spacesassignment) call for
a single space around the assignment operator.
Collapse the padding to a single space on every flagged assignment. The
change is purely whitespace around the operator: variable names, operators
and values (including whitespace inside quoted values) are untouched, as
confirmed by an empty 'git diff -w'.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Convert leading-tab indentation to spaces in shell task bodies across
the layer. Generated mechanically by oelint-adv's auto-fix for a single
rule (oelint.tabs.notabs), isolated to one commit.
Verified safe: every change is leading indentation of shell/BitBake code
(no mid-line tabs, and none of the affected files contain heredocs where
a tab would be significant), so there is no functional change.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the stray space between an assignment's opening quote and its
line-continuation backslash, and the space before '%' in inline
${@...} expressions. Generated mechanically by oelint-adv's auto-fix
for a single rule (oelint.vars.notneededspace), isolated to one commit.
The affected values are whitespace-separated lists (leading space is
insignificant) and Python format expressions ("%s"% p is equivalent),
so there is no functional change; a re-run of oelint-adv reports the
rule clean.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
Use mx9-nxp-bsp override instead of mx95-nxp-bsp to disable
xcomposite-egl and xcomposite-glx for the entire i.MX 9 family.
Signed-off-by: Vitor Soares <vitor.soares@toradex.com>
|
| |
|
|
|
|
| |
Add the relevant configuration for an i.MX 95 SoC.
Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
|
| |
|
|
|
|
| |
Add the relevant configuration for an i.MX 95 SoC.
Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
|
| |
|
|
|
|
|
|
|
|
| |
OE-core enabled the picky QA check on Upstream-Status.
commit b7fb91c797ab ("insane: add patch-status to default ERROR_QA")
Add missing upstream-status respectively fix unknown 'unknown' state.
strict_status_re = re.compile(r"^Upstream-Status: (Pending|Submitted|Denied|Inappropriate|Backport|Inactive-Upstream)( .+)?$", re.MULTILINE)
Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
|
| |
|
|
| |
Signed-off-by: Khem Raj <raj.khem@gmail.com>
|
| |
|
|
|
|
| |
Fix dynamic layer overrides missed by the script.
Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
|
| |
|
|
| |
Signed-off-by: Khem Raj <raj.khem@gmail.com>
|
| |
|
|
|
|
| |
Note the Qt ticket for the pending patch.
Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
|
| |
|
|
|
|
|
| |
QtWayland configuration task fails for xwayland distros.
Just remove the conflicting options.
Signed-off-by: Pierluigi Passaro <pierluigi.p@variscite.com>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
In cases where non imxgpu and non-fsl SOCs are target do_configure results in
ERROR: qtbase-5.15.0+gitAUTOINC+f6fe4bbab7-r0 do_configure: QA Issue: qtbase: in
valid PACKAGECONFIG: ${@bb.utils.contains('DISTRO_FEATURES', [invalid-packagecon
fig]
Therefore having empty value helps in avoiding this case
Signed-off-by: Khem Raj <raj.khem@gmail.com>
|
| |
|
|
|
|
|
| |
Drop patch 0015-Add-eglfs-to-IMX-GPU.patch. It is upstream and
no longer necessary.
Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
|
| |
|
|
|
|
|
|
| |
- 8M Quad has 3D but no 2D, so fix the override for GPU patches
- Add gbm and kms for all i.MX 8 with GPU
- Add vulkan for all i.MX 8 with GPU except 8M Mini
Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
|
| |
|
|
|
|
|
| |
The current version of the patch causes a fuzz because of context
change.
Signed-off-by: antznin <agodard@witekio.com>
|
| |
|
|
|
|
|
|
| |
Using a weak setting, allow distributions to override it and make
customizations if need (use gl, for example).
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Change-Id: Id1ee47764148e07feba86e16cd7d282a37dcf9e9
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 1cf9efd20fd94afdd2f7484b0570c570a21b8b65.
The qtbase configure fail to find any suitable GL library, so it fails
with:
,----
| WARNING: No QPA platform plugin enabled! This will produce a Qt that
| cannot run GUI applications. See "Platform backends" in the output of
| --help.
|
| ERROR: Feature 'opengl-desktop' was enabled, but the pre-condition
| '(config.win32 && !config.winrt && !features.opengles2
| && (config.msvc || libs.opengl))
| || (!config.watchos && !config.win32 && !config.wasm && libs.opengl)' failed.
|
| ERROR: Feature 'eglfs' was enabled, but the pre-condition
| '!config.android && !config.darwin && !config.win32 && !config.wasm
| && features.egl' failed.
`----
Fixed: #378
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NXP dropped native X11 support for i.MX 8(X).
with xcomposite-glx:
qtwayland fails in configure with:
| ERROR: Feature 'xcomposite-glx' was enabled, but the pre-condition 'features.wayland-client && features.opengl && !features.opengles2 && features.xlib && libs.xcomposite && libs.glx' failed.
| ERROR: Feature 'xcomposite-glx' was enabled, but the pre-condition 'features.wayland-server && features.opengl && !features.opengles2 && libs.xcomposite && libs.glx' failed.
with xcomposte-egl:
qtwayland fails during compile starting with:
| .../qwaylandxcompositeeglclientbufferintegration.cpp:140:59: error: cannot convert 'Display*' {aka '_XDisplay*'} to 'EGLNativeDisplayType' {aka 'wl_display*'}
| integration->mEglDisplay = eglGetDisplay(integration->mDisplay);
| ~~~~~~~~~~~~~^~~~~~~~
Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
|
| |
|
|
|
|
|
|
|
| |
* For distros enabling x11 and wayland it breaks X11 images (xfce/lxqt) for ALL
machines
* It is a setting which can be done at runtime. E.g KDE plasma does so.
* Settings like these do NOT belong into BSP layers
Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
|
| |
|
|
|
|
| |
Replace QT_CONFIG_FLAGS with PACKAGECONFIG
Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
|
| |
|
|
| |
Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
|
| |
|
|
|
|
|
| |
- Enable eglfs only for 3D parts and framebuffer backend
- Disable opengl and enable linuxfb for 2D parts with no 3D
Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
|
| |
|
|
|
|
|
| |
Set the correct Qt platform for the graphics backend so the user
isn't required to set it manually.
Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
|
| |
|
|
|
|
|
| |
- Fix a missing space in an append.
- Re-format to reduce leading whitespace.
Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
One of the advantages in using upstream mesa is that we have the freedom to
use gl or gles2 for qtbase. So follow meta-qt5's default here which is
desktop-gl and give other layers a more simple chance to change default if
necessary.
Notes:
* Did performance tests with my images and did not find any performance
issues.
* Some recipes in meta-qt5-extra fail to build when qtbase is build for gles2.
A patch addressing imx was applied [1] - but honestly it is not the way to
go: use meta-qt5's default which is fine.
[1] https://github.com/schnitzeltony/meta-qt5-extra/commit/0972828deb6a9e6a44d7596e6e4817fd74dbb51c
Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
fixes
| ERROR: Feature 'xcomposite-glx' was enabled, but the pre-condition 'features.wayland-client && features.opengl && !features.opengles2 && features.xlib && libs.xcomposite && libs.glx' failed.
|
| ERROR: Feature 'xcomposite-glx' was enabled, but the pre-condition 'features.wayland-server && features.opengl && !features.opengles2 && libs.xcomposite && libs.glx' failed.
FWIW: Have similar for Raspi/VC4 in meta-raspi-light
Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
| |
* it does not apply with meta-qt5 master
* it changes (breaks currently) qtwebkit for all boards when adding
meta-freescale to layers
Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
This allows the users to be able to override it in oe-device-extra.pri.
Signed-off-by: Ming Liu <liu.ming50@gmail.com>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
| |
Add gbm to PACKAGECONFIG_GL_use-mainline-bsp to enable EGLFS GBM QPA backend.
Change-Id: I76d8a3116ebebc4b9383fc575878c5aec666c203
Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was applied on qtbase commit:
commit 9ae028f507a22bd03c861e9d14c2efc4aa2efeda
Author: Marco Martin <mart@kde.org>
Date: Fri Feb 10 15:00:23 2017 +0100
Environment variable enabling the workaround FBO readback bug
On some ARM devices the font glyph generation is broken
Add an environment variable to enable workaround_brokenFBOReadBack
in QOpenGLContext, to fix font rendering on such devices as
Mali and Adreno
Change-Id: I9cc99ecb8b71a35bc369ec9dd11b877016b1179e
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
Change-Id: I0aec7ed2941b22aa2a0ea7638a5523a25c47fbd1
Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
| |
Gain the platform value through pkg-config
and pass it through QMAKE_CFLAGS_EGL.
Signed-off-by: Yuqing Zhu <carol.zhu@nxp.com>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
| |
Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
| |
This configures the Qt to use the OpenGL ES2 and KMS backend for the
'use-mainline-bsp' case. It also includes a fix for the font rendering
issue found when using Etnaviv which were used for Android-based
platforms but now being enabled for all EGL based systems.
Change-Id: Icdfd2a01836a90bcedbe1665ab3a0733ed505eff
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
| |
- List variables in override priority order
- Replace deprecated base_contains
- Remove extraneous whitespace
Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
| |
A build error occurred because eglfs needs to be
configured with the EGL pkg-config.
Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
| |
Changing source should be done during the patch phase, not
the configure stage.
Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
imx-gpu-viv doesn't use libGAL as of v5.
Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
| |
The IMX-GPU driver now provides compiler settings through pkg-config,
so don't set them explicitly.
Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* sympthoms:
* qml applications complain/crash with 'Failed to create OpenGL context...'
* qt5-opengles2-test hangs forever without displaying anything
* analysis:
qtbase's configure complains:
<...>/usr/include/EGL/eglvivante.h:117:16: note: class type '_FBDisplay' is incomplete
and configure ends up with no X11 support:
EGLFS ................ no
EGLFS i.MX6 ........ no
EGLFS i.MX6 Wayland. no
EGLFS EGLDevice .... no
EGLFS GBM .......... no
EGLFS Mali ......... no
EGLFS Raspberry Pi . no
EGLFS X11 .......... no
LinuxFB .............. no
Mir client............ no
XCB .................. yes (system library)
EGL on X ........... no
* background:
'-DEGL_API_FB=1' was introduced in
commit 62c8d8cc6500711464049662489729f208240be8
Author: Martin Jansa <martin.jansa@gmail.com>
Date: Mon Feb 29 18:22:28 2016 +0100
qtbase: Allow to build eglfs with x11 in DISTRO_FEATURES
* even when x11 is in DISTRO_FEATURES someone might configure qtbase
to build with eglfs, that works OK with Qt 5.5.1, because
-DEGL_API_FB=1 is also passed through
mkspecs/devices/linux-imx6-g++/qmake.conf
but with 5.6 and 5.7 it fails when X11 headers are include with their
own Status enum (the same errors like before
https://codereview.qt-project.org/#/c/105116/2)
Adding -DEGL_API_FB=1 like linux-imx6-g++/qmake.conf does is simplest
workaround to prevent imx-gpu-viv from including Xlib from
EGL/eglvivante.h
* comments on original commit (at today's' environment):
* it breaks GL support for X11
* in meta-freescale's qtbase.bbappend eglfs is disabled explicitly when
x11 in DISTRO_FEATURES so it seems that vivante driver does not support
eglfs and x11 at the same build.
Tested: setting 'eglfs' in PACKAGECONFIG builds fine but bare eglfs
support is skipped.
Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
Add missing bracket to if statement.
Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
| |
This enables the use of GLES2 backend for Software Rendering allowing
SoCs without GPU support to use it. Up to now, this includes i.MX6UL
and i.MX7D.
Change-Id: I3011a84198d42744639121394423106fcfc738b3
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
| |
The recipe has been reworked to use the 'imxgpu2d' and 'imxgpu3d'
feature overrides. While on that, the i.MX6SL specific code has been
reworked to used when only 2D GPU support is available.
Change-Id: I8fade08f54bd74e1dfd46b59711f6896c0bc7e6e
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
| |
The base_contains function is deprecated and we ought to use
bb.utils.contains instead.
Change-Id: Ib53b854f79f45ecd75da9f5c07a276465f2675fb
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|