7 files changed, 25 insertions, 1 deletions

diff --git a/classes/fsl-dynamic-packagearch.bbclass b/classes/fsl-dynamic-packagearch.bbclass
index 6cb0c0a9f..228dc005f 100644
--- a/classes/fsl-dynamic-packagearch.bbclass
+++ b/classes/fsl-dynamic-packagearch.bbclass
@@ -25,6 +25,10 @@
 #
 # Copyright 2013-2016 (C) O.S. Systems Software LTDA.
 
+# Parse-time logic is required: PACKAGE_ARCH and PACKAGE_EXTRA_ARCHS are chosen
+# by inspecting PROVIDES/DEPENDS against the SOCARCH filters and the multilib
+# tunes, which cannot be expressed declaratively.
+# nooelint: oelint.task.noanonpython
 python __anonymous () {
     machine_arch_filter = set((d.getVar("MACHINE_ARCH_FILTER") or "").split())
     machine_socarch_filter = set((d.getVar("MACHINE_SOCARCH_FILTER") or "").split())
diff --git a/classes/fsl-eula-unpack.bbclass b/classes/fsl-eula-unpack.bbclass
index ee938a74d..7ac54734f 100644
--- a/classes/fsl-eula-unpack.bbclass
+++ b/classes/fsl-eula-unpack.bbclass
@@ -133,11 +133,14 @@ FSL_EULA_FILE_MD5SUM ?= "${FSL_EULA_FILE_MD5SUM_LA_OPT_NXP_SOFTWARE_LICENSE_V63}
 
 LIC_FILES_CHKSUM_LAYER ?= "file://${FSL_EULA_FILE};md5=${FSL_EULA_FILE_MD5SUM}"
 LIC_FILES_CHKSUM_LAYER[vardepsexclude] += "FSL_EULA_FILE"
+# The EULA text is shipped by the layer (FSL_EULA_FILE), not the recipe source
+# tree, so this reference intentionally points outside the sources.
+# nooelint: oelint.var.licenseremotefile
 LIC_FILES_CHKSUM:append = " ${LIC_FILES_CHKSUM_LAYER}"
 
 LIC_FILES_CHKSUM[vardepsexclude] += "FSL_EULA_FILE"
 
-do_fetch:prepend() {
+python do_fetch:prepend() {
     if "Proprietary" not in d.getVar("LICENSE"):
         bb.fatal("The recipe LICENSE should include Proprietary but is " + d.getVar("LICENSE") + ".")
 }
@@ -164,6 +167,7 @@ python do_unpack() {
     bb.build.exec_func('fsl_bin_do_unpack', d)
 }
 
+fsl_bin_do_unpack[doc] = "Unpack the EULA-gated SRC_URI entries after the EULA has been accepted"
 python fsl_bin_do_unpack() {
     src_uri = (d.getVar('SRC_URI') or "").split()
     if len(src_uri) == 0:
diff --git a/classes/fsl-kernel-localversion.bbclass b/classes/fsl-kernel-localversion.bbclass
index 9b44fe194..c5505d463 100644
--- a/classes/fsl-kernel-localversion.bbclass
+++ b/classes/fsl-kernel-localversion.bbclass
@@ -15,6 +15,7 @@ LOCALVERSION ??= "+fslc"
 # LINUX_VERSION_EXTENSION is used as CONFIG_LOCALVERSION by kernel-yocto class
 LINUX_VERSION_EXTENSION ?= "${@bb.utils.contains('SCMVERSION', 'y', '', '${LOCALVERSION}', d)}"
 
+do_kernel_localversion[doc] = "Append the FSL LOCALVERSION and, when SCMVERSION is set, the git revision to the kernel .config"
 do_kernel_localversion[dirs] += "${S} ${B}"
 do_kernel_localversion() {
 
diff --git a/classes/imx-boot-container.bbclass b/classes/imx-boot-container.bbclass
index 345f71035..71c194d41 100644
--- a/classes/imx-boot-container.bbclass
+++ b/classes/imx-boot-container.bbclass
@@ -27,6 +27,9 @@ inherit use-imx-security-controller-firmware
 
 # Define ATF binary file to be deployed to the U-Boot build folder
 ATF_MACHINE_NAME ?= "bl31-${ATF_PLATFORM}.bin"
+# The append concatenates an "-optee" suffix directly onto the filename, so the
+# missing leading space is intentional (a space would break the name).
+# nooelint: oelint.vars.inconspaces
 ATF_MACHINE_NAME:append = "${@bb.utils.contains('MACHINE_FEATURES', 'optee', '-optee', '', d)}"
 
 OEI_NAME ?= "oei-${OEI_CORE}-*.bin"
@@ -61,6 +64,7 @@ do_resolve_and_populate_binaries[depends] += " \
 
 # Define an additional task that collects binary output from dependent packages
 # and deploys them into the U-Boot build folder
+do_resolve_and_populate_binaries[doc] = "Collect the ATF, DDR, SECO/OEI and optional OP-TEE firmware binaries into the U-Boot build folder for the boot container"
 do_resolve_and_populate_binaries() {
     if [ -n "${UBOOT_CONFIG}" ]; then
         for config in ${UBOOT_MACHINE}; do
diff --git a/classes/kernel-imximage.bbclass b/classes/kernel-imximage.bbclass
index 999840f69..e87e24591 100644
--- a/classes/kernel-imximage.bbclass
+++ b/classes/kernel-imximage.bbclass
@@ -21,10 +21,12 @@ DEPENDS:append = " u-boot-mkimage-native"
 
 IMXIMAGE_ENTRYPOINT ?= "${UBOOT_ENTRYPOINT}"
 
+imx_mkimage[doc] = "Wrap uboot-mkimage to add an i.MX imximage DCD header to a kernel binary"
 imx_mkimage() {
     uboot-mkimage -n $1 -T imximage -e ${IMXIMAGE_ENTRYPOINT} -d $2 $2.imx
 }
 
+gen_imximage[doc] = "Generate DCD-header kernel images for each device tree during do_deploy"
 gen_imximage() {
     if [ -z "${IMXIMAGE_ENTRYPOINT}" ]; then
         bbfatal "IMXIMAGE_ENTRYPOINT must have a valid value"
diff --git a/classes/machine-overrides-extender.bbclass b/classes/machine-overrides-extender.bbclass
index 58cb45b14..2da605f35 100644
--- a/classes/machine-overrides-extender.bbclass
+++ b/classes/machine-overrides-extender.bbclass
@@ -43,6 +43,9 @@ def machine_overrides_extender(d):
 
     return ':'.join(machine_overrides)
 
+# This is a ConfigParsed event handler (addhandler below), not a task, so a
+# task[doc] docstring does not apply.
+# nooelint: oelint.task.docstrings
 python machine_overrides_extender_handler() {
     # Ideally we'd use a separate variable name for this however
     # historically NXP BSPs used this. We save it to a known good name
@@ -56,6 +59,9 @@ python machine_overrides_extender_handler() {
 machine_overrides_extender_handler[eventmask] = "bb.event.ConfigParsed"
 addhandler machine_overrides_extender_handler
 
+# This is a RecipeParsed event handler (addhandler below), not a task, so a
+# task[doc] docstring does not apply.
+# nooelint: oelint.task.docstrings
 python machineoverrides_filtered_out_qa_handler() {
     filtered_out = (d.getVar('MACHINEOVERRIDES_EXTENDER_FILTER_OUT') or "").split()
     qa_error = d.getVar('MACHINEOVERRIDES_FILTERED_OUT_QA_ERROR')
diff --git a/classes/use-imx-security-controller-firmware.bbclass b/classes/use-imx-security-controller-firmware.bbclass
index 6a39bb684..67c44fd44 100644
--- a/classes/use-imx-security-controller-firmware.bbclass
+++ b/classes/use-imx-security-controller-firmware.bbclass
@@ -26,6 +26,9 @@ SECO_FIRMWARE_NAME:mx91-generic-bsp ?= "mx91${IMX_SOC_REV_LOWER}-ahab-container.
 SECO_FIRMWARE_NAME:mx93-generic-bsp ?= "mx93${IMX_SOC_REV_LOWER}-ahab-container.img"
 SECO_FIRMWARE_NAME:mx95-generic-bsp ?= "mx95${IMX_SOC_REV_LOWER}-ahab-container.img"
 
+# Parse-time guard: SoCs that require a SECO firmware must fail parsing early
+# (SkipRecipe) when SECO_FIRMWARE_NAME is undefined, which needs anonymous python.
+# nooelint: oelint.task.noanonpython
 python () {
     if "mx8m-generic-bsp" in d.getVar('MACHINEOVERRIDES').split(":"):
         return # We need to allow the recipes to be parsed for this case