opencv: Correct the patch header metadata

Five of the carried patches used "Inappropriate [i.MX specific]", which
is not one of the recognised reasons, so oelint.file.inappropriatemsg
fired on the recipe.  Use [embedded specific], which oelint accepts and
which this layer already uses elsewhere.  Only the headers change; the
diffs are untouched.

The two HoughLines patches also trip oelint.file.patchsignedoff, and
that one is suppressed rather than fixed.  A Signed-off-by is a
certification the signer makes about their right to submit the code, so
it can be neither invented for the author named in the From: header nor
supplied by whoever happens to carry the patch downstream.  These two
arrived through f95346d4 ("opencv: imx: update the i.mx fork to 4.13.0")
already without one, and their upstream submission could not be located
to recover it.  There is nothing here for this layer to correct, so the
finding is marked as such in place.

The suppression sits on the SRC_URI block and therefore covers every
patch listed in it, not just these two; the comment says so, since a
future patch added there without a sign-off will not be reported either.

0001-Use-Os-to-compile-tinyxml2.cpp.patch is deliberately left alone.
It belongs to the marked "meta-openembedded copy" block of this recipe
and its header is byte-identical to meta-openembedded's own copy, which
still reads "[ OE-Specific ]".  Rewriting it here would only make the
file differ from upstream; that fix belongs in meta-openembedded, so the
finding stays visible.

Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>

6 files changed, 12 insertions, 5 deletions

diff --git a/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv/0101-MGS-6470-ccc-Modify-host-ptr-alignment-size-in-UMAT.patch b/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv/0101-MGS-6470-ccc-Modify-host-ptr-alignment-size-in-UMAT.patch
index 82afd5c72..6b5d092c1 100644
--- a/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv/0101-MGS-6470-ccc-Modify-host-ptr-alignment-size-in-UMAT.patch
+++ b/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv/0101-MGS-6470-ccc-Modify-host-ptr-alignment-size-in-UMAT.patch
@@ -5,7 +5,7 @@ Subject: [PATCH 1/4] MGS-6470 [#ccc] Modify host ptr alignment size in UMAT
 
 change CV_OPENCL_ALIGNMENT_MEM_USE_HOST_PTR from 4 to 64
 
-Upstream-Status: Inappropriate [i.MX specific]
+Upstream-Status: Inappropriate [embedded specific]
 Signed-off-by: Eric Guo <eric.guo@nxp.com>
 ---
  modules/core/src/ocl.cpp | 2 +-
diff --git a/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv/0102-MGS-6470-ccc-Add-configuration-parameter-to-force-en.patch b/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv/0102-MGS-6470-ccc-Add-configuration-parameter-to-force-en.patch
index 50240093c..c19e7d58e 100644
--- a/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv/0102-MGS-6470-ccc-Add-configuration-parameter-to-force-en.patch
+++ b/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv/0102-MGS-6470-ccc-Add-configuration-parameter-to-force-en.patch
@@ -6,7 +6,7 @@ Subject: [PATCH 2/4] MGS-6470 [#ccc] Add configuration parameter to force
 
 USAGE: `set OPENCV_OPENCL_ALIGNMENT_MEM_ALLOC_HOST_PTR=true`
 
-Upstream-Status: Inappropriate [i.MX specific]
+Upstream-Status: Inappropriate [embedded specific]
 Signed-off-by: Eric Guo <eric.guo@nxp.com>
 ---
  modules/core/src/ocl.cpp | 4 +++-
diff --git a/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv/0103-MGS-6470-ccc-Change-configuration-to-enable-hostptr-.patch b/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv/0103-MGS-6470-ccc-Change-configuration-to-enable-hostptr-.patch
index 3b429b383..bd04a463f 100644
--- a/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv/0103-MGS-6470-ccc-Change-configuration-to-enable-hostptr-.patch
+++ b/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv/0103-MGS-6470-ccc-Change-configuration-to-enable-hostptr-.patch
@@ -4,7 +4,7 @@ Date: Thu, 9 Dec 2021 15:25:42 +0800
 Subject: [PATCH 3/4] MGS-6470 [#ccc] Change configuration to enable hostptr in
  OpenCL by default.
 
-Upstream-Status: Inappropriate [i.MX specific]
+Upstream-Status: Inappropriate [embedded specific]
 Signed-off-by: Eric Guo <eric.guo@nxp.com>
 ---
  modules/core/src/ocl.cpp | 2 +-
diff --git a/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv/0104-MGS-8011-ccc-Fix-the-problem-of-syntax-error-at-doub.patch b/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv/0104-MGS-8011-ccc-Fix-the-problem-of-syntax-error-at-doub.patch
index ebca4ce35..cc4e61f8b 100644
--- a/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv/0104-MGS-8011-ccc-Fix-the-problem-of-syntax-error-at-doub.patch
+++ b/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv/0104-MGS-8011-ccc-Fix-the-problem-of-syntax-error-at-doub.patch
@@ -10,7 +10,7 @@ disabled the related ocl function in opencv_test_imgproc to avoid the following
 
 error: syntax error at 'double4'
 
-Upstream-Status: Inappropriate [i.MX specific]
+Upstream-Status: Inappropriate [embedded specific]
 Signed-off-by: jiajia Qian <jiajia.qian@nxp.com>
 ---
  modules/imgproc/src/imgwarp.cpp | 4 ++++
diff --git a/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv/0105-MGS-8318-ccc-Fix-error-implicit-declaration-of-funct.patch b/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv/0105-MGS-8318-ccc-Fix-error-implicit-declaration-of-funct.patch
index d742b9123..f2ac82375 100644
--- a/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv/0105-MGS-8318-ccc-Fix-error-implicit-declaration-of-funct.patch
+++ b/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv/0105-MGS-8318-ccc-Fix-error-implicit-declaration-of-funct.patch
@@ -10,7 +10,7 @@ This feature requires at least OpenCL 2.0 or higher. By default, the C++ C langu
 
 is C++ C 1.2. Therefore, specify OpenCL version to 3.0 in the build-options.
 
-Upstream-Status: Inappropriate [i.MX specific]
+Upstream-Status: Inappropriate [embedded specific]
 Signed-off-by: jiajia Qian <jiajia.qian@nxp.com>
 ---
  modules/video/src/dis_flow.cpp | 2 +-
diff --git a/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv_4.13.0.imx.bb b/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv_4.13.0.imx.bb
index ed11c3bfe..e10048095 100644
--- a/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv_4.13.0.imx.bb
+++ b/dynamic-layers/openembedded-layer/recipes-support/opencv/opencv_4.13.0.imx.bb
@@ -259,6 +259,13 @@ SRC_URI:prepend = "\
     git://github.com/opencv/opencv_contrib.git;destsuffix=${BB_GIT_DEFAULT_DESTSUFFIX}/contrib;name=contrib;branch=4.x;protocol=https;tag=${IMX_BASE_VERSION} "
 
 # i.MX patches
+#
+# 0107 and 0108 carry no Signed-off-by. They came in from upstream review
+# rather than from this layer, and a sign-off is a certification only their
+# author can make, so there is nothing here for us to correct. Note this
+# covers the whole block: a patch added below without a sign-off will not be
+# reported either.
+# nooelint: oelint.file.patchsignedoff
 SRC_URI += "\
     file://0101-MGS-6470-ccc-Modify-host-ptr-alignment-size-in-UMAT.patch \
     file://0102-MGS-6470-ccc-Add-configuration-parameter-to-force-en.patch \