diff options
author | David Pursehouse <david.pursehouse@sonymobile.com> | 2012-10-11 16:44:48 +0900 |
---|---|---|
committer | David Pursehouse <david.pursehouse@sonymobile.com> | 2012-10-22 12:30:14 +0900 |
commit | 5c6eeac8f0350fd6b14cf226ffcff655f1dd9582 (patch) | |
tree | 3225695b9d2a97342a49127717ea5e2bc5935a63 /subcmds/__init__.py | |
parent | e98607248eec2b149d84efe944c12cbef419b82e (diff) | |
download | git-repo-5c6eeac8f0350fd6b14cf226ffcff655f1dd9582.tar.gz |
More coding style cleanup
Fixing more issues found with pylint. Some that were supposed to
have been fixed in the previous sweep (Ie0db839e) but were missed:
C0321: More than one statement on a single line
W0622: Redefining built-in 'name'
And some more:
W0631: Using possibly undefined loop variable 'name'
W0223: Method 'name' is abstract in class 'name' but is not overridden
W0231: __init__ method from base class 'name' is not called
Change-Id: Ie119183708609d6279e973057a385fde864230c3
Diffstat (limited to 'subcmds/__init__.py')
-rw-r--r-- | subcmds/__init__.py | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/subcmds/__init__.py b/subcmds/__init__.py index a2286e78..1fac802e 100644 --- a/subcmds/__init__.py +++ b/subcmds/__init__.py | |||
@@ -15,7 +15,7 @@ | |||
15 | 15 | ||
16 | import os | 16 | import os |
17 | 17 | ||
18 | all = {} | 18 | all_commands = {} |
19 | 19 | ||
20 | my_dir = os.path.dirname(__file__) | 20 | my_dir = os.path.dirname(__file__) |
21 | for py in os.listdir(my_dir): | 21 | for py in os.listdir(my_dir): |
@@ -43,7 +43,7 @@ for py in os.listdir(my_dir): | |||
43 | 43 | ||
44 | name = name.replace('_', '-') | 44 | name = name.replace('_', '-') |
45 | cmd.NAME = name | 45 | cmd.NAME = name |
46 | all[name] = cmd | 46 | all_commands[name] = cmd |
47 | 47 | ||
48 | if 'help' in all: | 48 | if 'help' in all_commands: |
49 | all['help'].commands = all | 49 | all_commands['help'].commands = all_commands |