diff options
| author | Mike Frysinger <vapier@google.com> | 2020-07-22 03:23:20 -0400 |
|---|---|---|
| committer | Mike Frysinger <vapier@google.com> | 2020-07-25 08:31:52 +0000 |
| commit | 80944b538d606a8ee143db85ca9e50305d3c73e4 (patch) | |
| tree | 1f35e59909e8f91366c3812a0c559bfd469960fe | |
| parent | 89f3ae5ae65de412bdde50e6e01ca666a1b7c2bb (diff) | |
| download | git-repo-80944b538d606a8ee143db85ca9e50305d3c73e4.tar.gz | |
upload: exit non-zero when preupload hooks fail
Bug: https://crbug.com/gerrit/13159
Change-Id: Id140b619242c841223c6bc5d4aa0c37a7ce0219d
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/276294
Reviewed-by: Jonathan Nieder <jrn@google.com>
Tested-by: Mike Frysinger <vapier@google.com>
| -rw-r--r-- | subcmds/upload.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/subcmds/upload.py b/subcmds/upload.py index 3dd9fd25..a886af93 100644 --- a/subcmds/upload.py +++ b/subcmds/upload.py | |||
| @@ -596,7 +596,7 @@ Gerrit Code Review: https://www.gerritcodereview.com/ | |||
| 596 | print('\nWARNING: pre-upload hooks failed, but uploading anyways.', | 596 | print('\nWARNING: pre-upload hooks failed, but uploading anyways.', |
| 597 | file=sys.stderr) | 597 | file=sys.stderr) |
| 598 | else: | 598 | else: |
| 599 | return | 599 | return 1 |
| 600 | 600 | ||
| 601 | if opt.reviewers: | 601 | if opt.reviewers: |
| 602 | reviewers = _SplitEmails(opt.reviewers) | 602 | reviewers = _SplitEmails(opt.reviewers) |