summaryrefslogtreecommitdiffstats
path: root/meta/recipes-connectivity/wpa-supplicant/wpa-supplicant/0002-Remove-newlines-from-wpa_supplicant-config-network-o.patch
diff options
context:
space:
mode:
Diffstat (limited to 'meta/recipes-connectivity/wpa-supplicant/wpa-supplicant/0002-Remove-newlines-from-wpa_supplicant-config-network-o.patch')
-rw-r--r--meta/recipes-connectivity/wpa-supplicant/wpa-supplicant/0002-Remove-newlines-from-wpa_supplicant-config-network-o.patch86
1 files changed, 0 insertions, 86 deletions
diff --git a/meta/recipes-connectivity/wpa-supplicant/wpa-supplicant/0002-Remove-newlines-from-wpa_supplicant-config-network-o.patch b/meta/recipes-connectivity/wpa-supplicant/wpa-supplicant/0002-Remove-newlines-from-wpa_supplicant-config-network-o.patch
deleted file mode 100644
index cc7b01ad57..0000000000
--- a/meta/recipes-connectivity/wpa-supplicant/wpa-supplicant/0002-Remove-newlines-from-wpa_supplicant-config-network-o.patch
+++ /dev/null
@@ -1,86 +0,0 @@
1From 0fe5a234240a108b294a87174ad197f6b5cb38e9 Mon Sep 17 00:00:00 2001
2From: Paul Stewart <pstew@google.com>
3Date: Thu, 3 Mar 2016 15:40:19 -0800
4Subject: [PATCH 2/2] Remove newlines from wpa_supplicant config network
5 output
6
7Spurious newlines output while writing the config file can corrupt the
8wpa_supplicant configuration. Avoid writing these for the network block
9parameters. This is a generic filter that cover cases that may not have
10been explicitly addressed with a more specific commit to avoid control
11characters in the psk parameter.
12
13Upstream-Status: Backport
14
15CVE: CVE-2016-4476
16
17Signed-off-by: Paul Stewart <pstew@google.com>
18Signed-off-by: Zhixiong Chi <Zhixiong.Chi.wrs.com>
19---
20 src/utils/common.c | 11 +++++++++++
21 src/utils/common.h | 1 +
22 wpa_supplicant/config.c | 15 +++++++++++++--
23 3 files changed, 25 insertions(+), 2 deletions(-)
24
25diff --git a/src/utils/common.c b/src/utils/common.c
26index 27b7c02..9856463 100644
27--- a/src/utils/common.c
28+++ b/src/utils/common.c
29@@ -709,6 +709,17 @@ int has_ctrl_char(const u8 *data, size_t len)
30 }
31
32
33+int has_newline(const char *str)
34+{
35+ while (*str) {
36+ if (*str == '\n' || *str == '\r')
37+ return 1;
38+ str++;
39+ }
40+ return 0;
41+}
42+
43+
44 size_t merge_byte_arrays(u8 *res, size_t res_len,
45 const u8 *src1, size_t src1_len,
46 const u8 *src2, size_t src2_len)
47diff --git a/src/utils/common.h b/src/utils/common.h
48index a972240..d19927b 100644
49--- a/src/utils/common.h
50+++ b/src/utils/common.h
51@@ -489,6 +489,7 @@ const char * wpa_ssid_txt(const u8 *ssid, size_t ssid_len);
52 char * wpa_config_parse_string(const char *value, size_t *len);
53 int is_hex(const u8 *data, size_t len);
54 int has_ctrl_char(const u8 *data, size_t len);
55+int has_newline(const char *str);
56 size_t merge_byte_arrays(u8 *res, size_t res_len,
57 const u8 *src1, size_t src1_len,
58 const u8 *src2, size_t src2_len);
59diff --git a/wpa_supplicant/config.c b/wpa_supplicant/config.c
60index fdd9643..eb97cd5 100644
61--- a/wpa_supplicant/config.c
62+++ b/wpa_supplicant/config.c
63@@ -2699,8 +2699,19 @@ char * wpa_config_get(struct wpa_ssid *ssid, const char *var)
64
65 for (i = 0; i < NUM_SSID_FIELDS; i++) {
66 const struct parse_data *field = &ssid_fields[i];
67- if (os_strcmp(var, field->name) == 0)
68- return field->writer(field, ssid);
69+ if (os_strcmp(var, field->name) == 0) {
70+ char *ret = field->writer(field, ssid);
71+
72+ if (ret && has_newline(ret)) {
73+ wpa_printf(MSG_ERROR,
74+ "Found newline in value for %s; not returning it",
75+ var);
76+ os_free(ret);
77+ ret = NULL;
78+ }
79+
80+ return ret;
81+ }
82 }
83
84 return NULL;
85--
861.9.1