summaryrefslogtreecommitdiffstats
path: root/meta
diff options
context:
space:
mode:
authorUlf Magnusson <ulfalizer@gmail.com>2016-10-01 04:47:02 +0200
committerRichard Purdie <richard.purdie@linuxfoundation.org>2016-10-04 16:29:04 +0100
commitfadc4fc746c09228c5b52b0e484664e73d9fb87e (patch)
tree84399ecd3970860c347dc9edb91787fb94f39612 /meta
parent823acf80373852cbc5a26807165ffbcc397b0a3d (diff)
downloadpoky-fadc4fc746c09228c5b52b0e484664e73d9fb87e.tar.gz
gtk-immodules-cache.bbclass: Use bb.fatal() instead of raising FuncFailed
This sets a good example and avoids unnecessarily contributing to perceived complexity and cargo culting. Motivating quote below: < kergoth> the *original* intent was for the function/task to error via whatever appropriate means, bb.fatal, whatever, and funcfailed was what you'd catch if you were calling exec_func/exec_task. that is, it's what those functions raise, not what metadata functions should be raising < kergoth> it didn't end up being used that way < kergoth> but there's really never a reason to raise it yourself FuncFailed.__init__ takes a 'name' argument rather than a 'msg' argument, which also shows that the original purpose got lost. (From OE-Core rev: 11a2f932073635f9680470cd69216cecf7ed0c37) Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta')
-rw-r--r--meta/classes/gtk-immodules-cache.bbclass2
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/classes/gtk-immodules-cache.bbclass b/meta/classes/gtk-immodules-cache.bbclass
index 3a4634c4ed..ebbc9dea89 100644
--- a/meta/classes/gtk-immodules-cache.bbclass
+++ b/meta/classes/gtk-immodules-cache.bbclass
@@ -84,6 +84,6 @@ python __anonymous() {
84 gtkimmodules_check = d.getVar('GTKIMMODULES_PACKAGES', False) 84 gtkimmodules_check = d.getVar('GTKIMMODULES_PACKAGES', False)
85 if not gtkimmodules_check: 85 if not gtkimmodules_check:
86 bb_filename = d.getVar('FILE', False) 86 bb_filename = d.getVar('FILE', False)
87 raise bb.build.FuncFailed("ERROR: %s inherits gtk-immodules-cache but doesn't set GTKIMMODULES_PACKAGES" % bb_filename) 87 bb.fatal("ERROR: %s inherits gtk-immodules-cache but doesn't set GTKIMMODULES_PACKAGES" % bb_filename)
88} 88}
89 89