summaryrefslogtreecommitdiffstats
path: root/meta
diff options
context:
space:
mode:
authorRichard Purdie <richard.purdie@linuxfoundation.org>2013-11-07 22:35:07 +0000
committerRichard Purdie <richard.purdie@linuxfoundation.org>2013-11-12 16:00:30 +0000
commit40b3030626d4383873aa7ea62152e79c6ec88f74 (patch)
treee669c8347281848000e37c6c5d281ccef50e0287 /meta
parent442e2e7da5fe5fe7097f8799a479f98d36e60ef3 (diff)
downloadpoky-40b3030626d4383873aa7ea62152e79c6ec88f74.tar.gz
bitbake.conf: Default DISTRO to nodistro
An empty distro value leads to OVERRIDES and FILESOVERRIDES containing "::" entries which causes odd issues such as files being included when they shouldn't be. We could put in anonymous python to guard against empty entries but its messy and setting a default value for DISTRO to something harmless is much easier. This patch adds a weak default and ensures the sanity test doesn't complain about it. DISTRO_VERSION and SDK_VERSION are also updated to match. (From OE-Core rev: b7279f99639774674da806d37d252f388f33055f) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta')
-rw-r--r--meta/classes/sanity.bbclass2
-rw-r--r--meta/conf/bitbake.conf4
-rw-r--r--meta/conf/distro/include/default-distrovars.inc4
3 files changed, 7 insertions, 3 deletions
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index b8e5b02da0..83378b0573 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -599,7 +599,7 @@ def check_sanity_everybuild(status, d):
599 # Check that the DISTRO is valid, if set 599 # Check that the DISTRO is valid, if set
600 # need to take into account DISTRO renaming DISTRO 600 # need to take into account DISTRO renaming DISTRO
601 distro = d.getVar('DISTRO', True) 601 distro = d.getVar('DISTRO', True)
602 if distro: 602 if distro and distro != "nodistro":
603 if not ( check_conf_exists("conf/distro/${DISTRO}.conf", d) or check_conf_exists("conf/distro/include/${DISTRO}.inc", d) ): 603 if not ( check_conf_exists("conf/distro/${DISTRO}.conf", d) or check_conf_exists("conf/distro/include/${DISTRO}.inc", d) ):
604 status.addresult("DISTRO '%s' not found. Please set a valid DISTRO in your local.conf\n" % d.getVar("DISTRO", True)) 604 status.addresult("DISTRO '%s' not found. Please set a valid DISTRO in your local.conf\n" % d.getVar("DISTRO", True))
605 605
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index d7b7a4b46f..ea313adca5 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -656,6 +656,10 @@ AUTO_LIBNAME_PKGS = "${PACKAGES}"
656### Config file processing 656### Config file processing
657### 657###
658 658
659# An empty distro leads to :: entries in OVERRIDES and FILEOVERRIDES which
660# is a bad idea. Setting a dummy value is better than a ton of anonymous python.
661DISTRO ??= "nodistro"
662
659# Overrides are processed left to right, so the ones that are named later take precedence. 663# Overrides are processed left to right, so the ones that are named later take precedence.
660# You generally want them to go from least to most specific. 664# You generally want them to go from least to most specific.
661# 665#
diff --git a/meta/conf/distro/include/default-distrovars.inc b/meta/conf/distro/include/default-distrovars.inc
index d275525000..5ef9c32c39 100644
--- a/meta/conf/distro/include/default-distrovars.inc
+++ b/meta/conf/distro/include/default-distrovars.inc
@@ -43,8 +43,8 @@ NO32LIBS ??= "1"
43 43
44# Default to emitting logfiles if a build fails. 44# Default to emitting logfiles if a build fails.
45BBINCLUDELOGS ??= "yes" 45BBINCLUDELOGS ??= "yes"
46SDK_VERSION ??= "oe-core.0" 46SDK_VERSION ??= "nodistro.0"
47DISTRO_VERSION ??= "oe-core.0" 47DISTRO_VERSION ??= "nodistro.0"
48 48
49# Missing checksums should raise an error 49# Missing checksums should raise an error
50BB_STRICT_CHECKSUM = "1" 50BB_STRICT_CHECKSUM = "1"