summaryrefslogtreecommitdiffstats
path: root/meta
diff options
context:
space:
mode:
authorPeter Bergin <peter@berginkonsult.se>2021-01-29 10:50:54 +0100
committerRichard Purdie <richard.purdie@linuxfoundation.org>2021-02-05 23:35:18 +0000
commit3436674697677cb213f1007358a5a743eac29d75 (patch)
treece283822ef0e04cc26e38f82d72f7d7e1106973d /meta
parent8488b2d64ad7144ca003d12dbe7be00e23ddba60 (diff)
downloadpoky-3436674697677cb213f1007358a5a743eac29d75.tar.gz
buildhistory.bbclass: avoid exception for empty BUILDHISTORY_FEATURES variable
An exception is fired when a BuildStarted event is sent to buildhistory bbclass and the variable BUILDHISTORY_FEATURES is not set. ERROR: Execution of event handler 'buildhistory_eventhandler' failed Traceback (most recent call last): File "<...>/meta/classes/buildhistory.bbclass", line 862, in buildhistory_eventhandler(e=<bb.event.BuildStarted object at 0x7f94c3810250>): python buildhistory_eventhandler() { > if e.data.getVar('BUILDHISTORY_FEATURES').strip(): reset = e.data.getVar("BUILDHISTORY_RESET") AttributeError: 'NoneType' object has no attribute 'strip' This can happen in a multiconfig build where the default configuration use the buildhistory class but not the configuration in mc. It should be a rare case that this happens and it was found in a missconfigured build. (From OE-Core rev: a74e30a4de02c8efd3e7102ba7a4fe06df53cc34) (From OE-Core rev: 83ee03a6f05ff60459dbcc4fcfb78f95bb0b4848) Signed-off-by: Peter Bergin <peter@berginkonsult.se> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 55ead1be58679c3bcb7d1c141672b999d53e90ef) Signed-off-by: Anuj Mittal <anuj.mittal@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta')
-rw-r--r--meta/classes/buildhistory.bbclass2
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/classes/buildhistory.bbclass b/meta/classes/buildhistory.bbclass
index 7d5e3eb8fd..3a6780da34 100644
--- a/meta/classes/buildhistory.bbclass
+++ b/meta/classes/buildhistory.bbclass
@@ -855,7 +855,7 @@ END
855} 855}
856 856
857python buildhistory_eventhandler() { 857python buildhistory_eventhandler() {
858 if e.data.getVar('BUILDHISTORY_FEATURES').strip(): 858 if (e.data.getVar('BUILDHISTORY_FEATURES') or "").strip():
859 reset = e.data.getVar("BUILDHISTORY_RESET") 859 reset = e.data.getVar("BUILDHISTORY_RESET")
860 olddir = e.data.getVar("BUILDHISTORY_OLD_DIR") 860 olddir = e.data.getVar("BUILDHISTORY_OLD_DIR")
861 if isinstance(e, bb.event.BuildStarted): 861 if isinstance(e, bb.event.BuildStarted):