summaryrefslogtreecommitdiffstats
path: root/meta/recipes-multimedia
diff options
context:
space:
mode:
authorJussi Kukkonen <jussi.kukkonen@intel.com>2016-10-04 10:17:28 +0300
committerRichard Purdie <richard.purdie@linuxfoundation.org>2016-10-05 10:10:11 +0100
commitf1f6993c729aee2f7c273b66376cf0b688482450 (patch)
treef5bc7d1aedf888478cd06ddba9c27c6889d4ab04 /meta/recipes-multimedia
parentf63e8d2dcb2eed6592d6f90d154afd319335c5c8 (diff)
downloadpoky-f1f6993c729aee2f7c273b66376cf0b688482450.tar.gz
Revert "gst-player: Disable visualizations"
This reverts oe-core commit b79d1bf49b56a97216fb719ac19e4dd9022f15b4. Now that xf86-video-intel is upgraded, visualizations can be enabled by default. (From OE-Core rev: c0a22a8d3e5d44ae3fba14a52582d39cfc600318) Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/recipes-multimedia')
-rw-r--r--meta/recipes-multimedia/gstreamer/gst-player/0001-Disable-visualizations-by-default.patch36
-rw-r--r--meta/recipes-multimedia/gstreamer/gst-player_git.bb1
2 files changed, 0 insertions, 37 deletions
diff --git a/meta/recipes-multimedia/gstreamer/gst-player/0001-Disable-visualizations-by-default.patch b/meta/recipes-multimedia/gstreamer/gst-player/0001-Disable-visualizations-by-default.patch
deleted file mode 100644
index dabdcea345..0000000000
--- a/meta/recipes-multimedia/gstreamer/gst-player/0001-Disable-visualizations-by-default.patch
+++ /dev/null
@@ -1,36 +0,0 @@
1From 93e1838f8b8704e4d7d71965f61bee931377b080 Mon Sep 17 00:00:00 2001
2From: Jussi Kukkonen <jussi.kukkonen@intel.com>
3Date: Thu, 22 Sep 2016 19:26:40 +0300
4Subject: [PATCH] Disable visualizations by default
5
6As documented in [YOCTO #10041] visualizations trigger a bug in
7xvimagesink on some hardware, which prevents playback in the
8mediaplayer. Disable visualizations until the xv issue is solved
9to enable playback QA.
10
11Upstream-Status: Inappropriate [workaround]
12Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
13Signed-off-by: Maxin B. John <maxin.john@intel.com>
14---
15 gtk/gtk-play.c | 5 ++---
16 1 file changed, 2 insertions(+), 3 deletions(-)
17
18diff --git a/gtk/gtk-play.c b/gtk/gtk-play.c
19index 8ae0fea..322e599 100644
20--- a/gtk/gtk-play.c
21+++ b/gtk/gtk-play.c
22@@ -1751,9 +1751,8 @@ gtk_play_constructor (GType type, guint n_construct_params,
23 g_signal_connect (self->player, "volume-changed",
24 G_CALLBACK (player_volume_changed_cb), self);
25
26- /* enable visualization (by default playbin uses goom) */
27- /* if visualization is enabled then use the first element */
28- gst_player_set_visualization_enabled (self->player, TRUE);
29+ /* Disable visualization by default */
30+ gst_player_set_visualization_enabled (self->player, FALSE);
31
32 g_signal_connect (G_OBJECT (self), "show", G_CALLBACK (show_cb), NULL);
33
34--
352.4.0
36
diff --git a/meta/recipes-multimedia/gstreamer/gst-player_git.bb b/meta/recipes-multimedia/gstreamer/gst-player_git.bb
index 51f3544599..2a4c9dcfbf 100644
--- a/meta/recipes-multimedia/gstreamer/gst-player_git.bb
+++ b/meta/recipes-multimedia/gstreamer/gst-player_git.bb
@@ -9,7 +9,6 @@ SRC_URI = "git://github.com/sdroege/gst-player.git \
9 file://Fix-pause-play.patch;apply=0 \ 9 file://Fix-pause-play.patch;apply=0 \
10 file://Add-error-signal-emission-for-missing-plugins.patch;apply=0 \ 10 file://Add-error-signal-emission-for-missing-plugins.patch;apply=0 \
11 file://0001-gtk-play-provide-similar-behaviour-for-quit-and-clos.patch \ 11 file://0001-gtk-play-provide-similar-behaviour-for-quit-and-clos.patch \
12 file://0001-Disable-visualizations-by-default.patch \
13 file://gst-player.desktop" 12 file://gst-player.desktop"
14 13
15SRCREV = "ea90e63c1064503f9ba5d59aa4ca604f13ca5def" 14SRCREV = "ea90e63c1064503f9ba5d59aa4ca604f13ca5def"