summaryrefslogtreecommitdiffstats
path: root/meta/recipes-multimedia/gstreamer/gst-player
diff options
context:
space:
mode:
authorMaxin B. John <maxin.john@intel.com>2016-09-25 21:40:05 +0300
committerRichard Purdie <richard.purdie@linuxfoundation.org>2016-09-28 10:16:03 +0100
commit850ded308cd55df6722725c4f8356178ee2ef3ad (patch)
tree1b82064a3642488ca9e7ebddef8fc95f7e267b7d /meta/recipes-multimedia/gstreamer/gst-player
parent013fff4639c7f333eca350ca6b6c013296d9598f (diff)
downloadpoky-850ded308cd55df6722725c4f8356178ee2ef3ad.tar.gz
gst-player: Disable visualizations
On some machines, visualizations in gst-player trigger a bug in xvimagesink. Till we have a proper fix, disable the visualization rather than downgrading the xvimagesink. Fixes [YOCTO #10041] (From OE-Core rev: b79d1bf49b56a97216fb719ac19e4dd9022f15b4) Signed-off-by: Maxin B. John <maxin.john@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/recipes-multimedia/gstreamer/gst-player')
-rw-r--r--meta/recipes-multimedia/gstreamer/gst-player/0001-Disable-visualizations-by-default.patch36
1 files changed, 36 insertions, 0 deletions
diff --git a/meta/recipes-multimedia/gstreamer/gst-player/0001-Disable-visualizations-by-default.patch b/meta/recipes-multimedia/gstreamer/gst-player/0001-Disable-visualizations-by-default.patch
new file mode 100644
index 0000000000..dabdcea345
--- /dev/null
+++ b/meta/recipes-multimedia/gstreamer/gst-player/0001-Disable-visualizations-by-default.patch
@@ -0,0 +1,36 @@
1From 93e1838f8b8704e4d7d71965f61bee931377b080 Mon Sep 17 00:00:00 2001
2From: Jussi Kukkonen <jussi.kukkonen@intel.com>
3Date: Thu, 22 Sep 2016 19:26:40 +0300
4Subject: [PATCH] Disable visualizations by default
5
6As documented in [YOCTO #10041] visualizations trigger a bug in
7xvimagesink on some hardware, which prevents playback in the
8mediaplayer. Disable visualizations until the xv issue is solved
9to enable playback QA.
10
11Upstream-Status: Inappropriate [workaround]
12Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
13Signed-off-by: Maxin B. John <maxin.john@intel.com>
14---
15 gtk/gtk-play.c | 5 ++---
16 1 file changed, 2 insertions(+), 3 deletions(-)
17
18diff --git a/gtk/gtk-play.c b/gtk/gtk-play.c
19index 8ae0fea..322e599 100644
20--- a/gtk/gtk-play.c
21+++ b/gtk/gtk-play.c
22@@ -1751,9 +1751,8 @@ gtk_play_constructor (GType type, guint n_construct_params,
23 g_signal_connect (self->player, "volume-changed",
24 G_CALLBACK (player_volume_changed_cb), self);
25
26- /* enable visualization (by default playbin uses goom) */
27- /* if visualization is enabled then use the first element */
28- gst_player_set_visualization_enabled (self->player, TRUE);
29+ /* Disable visualization by default */
30+ gst_player_set_visualization_enabled (self->player, FALSE);
31
32 g_signal_connect (G_OBJECT (self), "show", G_CALLBACK (show_cb), NULL);
33
34--
352.4.0
36