summaryrefslogtreecommitdiffstats
path: root/meta/recipes-devtools/go/go-1.9
diff options
context:
space:
mode:
authorHongxu Jia <hongxu.jia@windriver.com>2018-10-29 16:21:15 +0800
committerRichard Purdie <richard.purdie@linuxfoundation.org>2018-11-14 11:14:39 +0000
commit88ac8e533438532ff6cad3285cdd16479e70642d (patch)
tree82f7a723bee4a9281731970032d7cb0b671f4f1f /meta/recipes-devtools/go/go-1.9
parent07999325f94a60546212d37ffc9f4de7a3943214 (diff)
downloadpoky-88ac8e533438532ff6cad3285cdd16479e70642d.tar.gz
go 1.9/1.11: fix textrel qa warning for non mips arch
While building go itself, the go build system does not support to set `-buildmode=pie' from environment. Add GOBUILDMODE to support it which make PIE executables the default build mode, as PIE executables are required as of Yocto But mips doesn't support -buildmode=pie, so skip the QA checking for mips and its variants (From OE-Core rev: d11cb2ea0abfca4a5958ff4647f22a5b203113e5) Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/recipes-devtools/go/go-1.9')
-rw-r--r--meta/recipes-devtools/go/go-1.9/0011-use-GOBUILDMODE-to-set-buildmode.patch40
1 files changed, 40 insertions, 0 deletions
diff --git a/meta/recipes-devtools/go/go-1.9/0011-use-GOBUILDMODE-to-set-buildmode.patch b/meta/recipes-devtools/go/go-1.9/0011-use-GOBUILDMODE-to-set-buildmode.patch
new file mode 100644
index 0000000000..da93dc5c14
--- /dev/null
+++ b/meta/recipes-devtools/go/go-1.9/0011-use-GOBUILDMODE-to-set-buildmode.patch
@@ -0,0 +1,40 @@
1From b928fafab1d9425aae9341806bd2f6178ba1da1f Mon Sep 17 00:00:00 2001
2From: Hongxu Jia <hongxu.jia@windriver.com>
3Date: Fri, 26 Oct 2018 16:32:50 +0800
4Subject: [PATCH] use GOBUILDMODE to set buildmode
5
6While building go itself, the go build system does not support
7to set `-buildmode=pie' from environment.
8
9Add GOBUILDMODE to support it which make PIE executables the default
10build mode, as PIE executables are required as of Yocto
11
12Refers: https://groups.google.com/forum/#!topic/golang-dev/gRCe5URKewI
13Upstream-Status: Denied [upstream choose antoher solution: `17a256b
14cmd/go: -buildmode=pie for android/arm']
15
16Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
17---
18 src/cmd/go/internal/work/build.go | 6 +++++-
19 1 file changed, 5 insertions(+), 1 deletion(-)
20
21diff --git a/src/cmd/go/internal/work/build.go b/src/cmd/go/internal/work/build.go
22index b276de5..1683e7e 100644
23--- a/src/cmd/go/internal/work/build.go
24+++ b/src/cmd/go/internal/work/build.go
25@@ -211,7 +211,11 @@ func AddBuildFlags(cmd *base.Command) {
26
27 cmd.Flag.Var((*base.StringsFlag)(&buildAsmflags), "asmflags", "")
28 cmd.Flag.Var(buildCompiler{}, "compiler", "")
29- cmd.Flag.StringVar(&cfg.BuildBuildmode, "buildmode", "default", "")
30+ if bm := os.Getenv("GOBUILDMODE"); bm != "" {
31+ cmd.Flag.StringVar(&cfg.BuildBuildmode, "buildmode", bm, "")
32+ } else {
33+ cmd.Flag.StringVar(&cfg.BuildBuildmode, "buildmode", "default", "")
34+ }
35 cmd.Flag.Var((*base.StringsFlag)(&buildGcflags), "gcflags", "")
36 cmd.Flag.Var((*base.StringsFlag)(&buildGccgoflags), "gccgoflags", "")
37 cmd.Flag.StringVar(&cfg.BuildContext.InstallSuffix, "installsuffix", "", "")
38--
392.7.4
40