summaryrefslogtreecommitdiffstats
path: root/meta/recipes-core/initscripts/initscripts-1.0/populate-volatile.sh
diff options
context:
space:
mode:
authorMatthias Schiffer <matthias.schiffer@ew.tq-group.com>2021-07-21 16:10:15 +0200
committerRichard Purdie <richard.purdie@linuxfoundation.org>2021-07-24 16:33:46 +0100
commit2b45c7253fde3edf97e73e433f4d73989997a87a (patch)
treef67b36a9370fdd6d864bdf78236065f93c928edf /meta/recipes-core/initscripts/initscripts-1.0/populate-volatile.sh
parent9448e5f17dc5fd3646b6412f547300a4753521b3 (diff)
downloadpoky-2b45c7253fde3edf97e73e433f4d73989997a87a.tar.gz
initscripts: populate-volatile.sh: run create_file synchronously
The behavior of running create_file in the background was introduced in d44816bedade ("initscripts: Populate volatile from existing file") without further explanation. Besides its questionable benefit, this causes actual issues: - Not all create_file processes may have finished by the time the initscript exits (or when it moves /etc/volatile.cache.build !) - By making the order of commands nondeterminstic, it could hide dependency issues where it was attempted to create files before their containing directories (From OE-Core rev: 1a4ddb0d3f1289e0b67b6eba9be58374d3d7a80b) Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/recipes-core/initscripts/initscripts-1.0/populate-volatile.sh')
-rwxr-xr-xmeta/recipes-core/initscripts/initscripts-1.0/populate-volatile.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/recipes-core/initscripts/initscripts-1.0/populate-volatile.sh b/meta/recipes-core/initscripts/initscripts-1.0/populate-volatile.sh
index f8b42c6893..b56b72f833 100755
--- a/meta/recipes-core/initscripts/initscripts-1.0/populate-volatile.sh
+++ b/meta/recipes-core/initscripts/initscripts-1.0/populate-volatile.sh
@@ -201,7 +201,7 @@ apply_cfgfile() {
201 "f") [ "${VERBOSE}" != "no" ] && echo "Creating file -${TNAME}-." 201 "f") [ "${VERBOSE}" != "no" ] && echo "Creating file -${TNAME}-."
202 TSOURCE="$TLTARGET" 202 TSOURCE="$TLTARGET"
203 [ "${TSOURCE}" = "none" ] && TSOURCE="" 203 [ "${TSOURCE}" = "none" ] && TSOURCE=""
204 create_file "${TNAME}" "${TSOURCE}" & 204 create_file "${TNAME}" "${TSOURCE}"
205 ;; 205 ;;
206 "d") [ "${VERBOSE}" != "no" ] && echo "Creating directory -${TNAME}-." 206 "d") [ "${VERBOSE}" != "no" ] && echo "Creating directory -${TNAME}-."
207 mk_dir "${TNAME}" 207 mk_dir "${TNAME}"