summaryrefslogtreecommitdiffstats
path: root/meta/recipes-core/glibc/glibc
diff options
context:
space:
mode:
authorKhem Raj <raj.khem@gmail.com>2021-12-01 22:19:33 -0800
committerRichard Purdie <richard.purdie@linuxfoundation.org>2021-12-03 23:37:16 +0000
commitb1984dd2f5096fca7b7a8b93a45143825b168bda (patch)
tree94ec1caabf7ee74975e503413c3973e939d76312 /meta/recipes-core/glibc/glibc
parent5c8c4dd925bbb9d29014ffd717ffe69ebb3553e3 (diff)
downloadpoky-b1984dd2f5096fca7b7a8b93a45143825b168bda.tar.gz
glibc: Drop patch to support/workaround prelinked apps on armv5
The usecase explained in bug #1443 works fine now a days on qemuarmv5, tested by using lltng-ust and explicitly linking in liburcu-bp.so as well, since its no more a direct dependency of liblttng-ust.so.1 Given that usecase works, unbolt this fix now. (From OE-Core rev: 088cf642e4a58fd50f93b22b4fdf5a2f25e1ed53) Signed-off-by: Khem Raj <raj.khem@gmail.com> Cc: Mark Hatle <mark.hatle@kernel.crashing.org> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/recipes-core/glibc/glibc')
-rw-r--r--meta/recipes-core/glibc/glibc/0012-Quote-from-bug-1443-which-explains-what-the-patch-do.patch58
1 files changed, 0 insertions, 58 deletions
diff --git a/meta/recipes-core/glibc/glibc/0012-Quote-from-bug-1443-which-explains-what-the-patch-do.patch b/meta/recipes-core/glibc/glibc/0012-Quote-from-bug-1443-which-explains-what-the-patch-do.patch
deleted file mode 100644
index 07d4411c61..0000000000
--- a/meta/recipes-core/glibc/glibc/0012-Quote-from-bug-1443-which-explains-what-the-patch-do.patch
+++ /dev/null
@@ -1,58 +0,0 @@
1From add514edf4299d1bf540d85d0aa0bd5fe0d46b78 Mon Sep 17 00:00:00 2001
2From: Khem Raj <raj.khem@gmail.com>
3Date: Wed, 18 Mar 2015 00:20:09 +0000
4Subject: [PATCH] Quote from bug 1443 which explains what the patch does :
5
6 We build some random program and link it with -lust. When we run it,
7 it dies with a SIGSEGV before reaching main().
8
9 Libust.so depends on liburcu-bp.so from the usermode-rcu package.
10 Although libust.so is not prelinked, liburcu-bp.so IS prelinked; this
11 is critical.
12
13 Libust.so uses a TLS / __thread variable that is defined in liburcu-
14 bp.so. There are special ARM-specific relocation types that allow two
15 shared libraries to share thread-specific data. This is critical too.
16
17 One more critical issue: although liburcu-bp.so is prelinked, we can't
18 load it at its prelinked address, because we also link against
19 librt.so, and librt.so uses that address.
20
21 The dynamic linker is forced to relink liburcu-bp.so at a different
22 address. In the course of relinking, it processes the special ARM
23 relocation record mentioned above. The prelinker has already filled
24 in the information, which is a short offset into a table of thread-
25 specific data that is allocated per-thread for each library that uses
26 TLS. Because the normal behavior of a relocation is to add the symbol
27 value to an addend stored at the address being relocated, we end up
28 adding the short offset to itself, doubling it.
29
30 Now we have an awkward situation. The libust.so library doesn't know
31 about the addend, so its TLS data for this element is correct. The
32 liburcu-bp.so library has a different offset for the element. When we
33 go to initialize the element for the first time in liburcu-bp.so, we
34 write the address of the result at the doubled (broken) offset.
35 Later, when we refer to the address from libust.so, we check the value
36 at the correct offset, but it's NULL, so we eat hot SIGSEGV.
37
38Upstream-Status: Pending
39
40Signed-off-by: Andrei Dinu <andrei.adrianx.dinu@intel.com>
41Signed-off-by: Khem Raj <raj.khem@gmail.com>
42---
43 sysdeps/arm/dl-machine.h | 2 +-
44 1 file changed, 1 insertion(+), 1 deletion(-)
45
46diff --git a/sysdeps/arm/dl-machine.h b/sysdeps/arm/dl-machine.h
47index ff5e09e207..d68bfe5cbe 100644
48--- a/sysdeps/arm/dl-machine.h
49+++ b/sysdeps/arm/dl-machine.h
50@@ -510,7 +510,7 @@ elf_machine_rel (struct link_map *map, const Elf32_Rel *reloc,
51
52 case R_ARM_TLS_DTPOFF32:
53 if (sym != NULL)
54- *reloc_addr += sym->st_value;
55+ *reloc_addr = sym->st_value;
56 break;
57
58 case R_ARM_TLS_TPOFF32: