diff options
author | Trevor Gamblin <tgamblin@baylibre.com> | 2023-10-12 09:24:58 -0400 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2023-10-13 11:53:06 +0100 |
commit | 2fdabc368a52a9bf60f76f33e92b94de843688a8 (patch) | |
tree | 1a9ab2e980cc66a656692bf4b450dd0b3156d6a0 /meta/lib/patchtest/tests/test_python_pylint.py | |
parent | 575b00dca5a9ae15b0eec7c8eea3c415c2a37bc1 (diff) | |
download | poky-2fdabc368a52a9bf60f76f33e92b94de843688a8.tar.gz |
patchtest: improve test issue messages
The patchtest tests provide vague feedback to the user, and many of them
also provide redundant 'fix' strings that could easily be incorporated
into the issue messages themselves. Simplify them so that it is more
clear what the errors are and how they can be addressed. No
recommendation is given when the issue string adequately conveys the
issue, e.g. with a missing "LICENSE" entry in a newly-created recipe.
(From OE-Core rev: 0bfb3614244ec7aa79b6424bc63f9f2bccdabe98)
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/lib/patchtest/tests/test_python_pylint.py')
-rw-r--r-- | meta/lib/patchtest/tests/test_python_pylint.py | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/meta/lib/patchtest/tests/test_python_pylint.py b/meta/lib/patchtest/tests/test_python_pylint.py index ea8efb7c2a..907bd9eef4 100644 --- a/meta/lib/patchtest/tests/test_python_pylint.py +++ b/meta/lib/patchtest/tests/test_python_pylint.py | |||
@@ -56,6 +56,5 @@ class PyLint(base.Base): | |||
56 | 56 | ||
57 | for issue in self.pylint_test: | 57 | for issue in self.pylint_test: |
58 | if self.pylint_test[issue] not in self.pylint_pretest.values(): | 58 | if self.pylint_test[issue] not in self.pylint_pretest.values(): |
59 | self.fail('Errors in your Python code were encountered', | 59 | self.fail('Errors in your Python code were encountered. Please check your code with a linter and resubmit', |
60 | 'Correct the lines introduced by your patch', | ||
61 | data=[('Output', 'Please, fix the listed issues:'), ('', issue + ' ' + self.pylint_test[issue])]) | 60 | data=[('Output', 'Please, fix the listed issues:'), ('', issue + ' ' + self.pylint_test[issue])]) |