summaryrefslogtreecommitdiffstats
path: root/meta/lib/oeqa
diff options
context:
space:
mode:
authorAlexander Kanavin <alex.kanavin@gmail.com>2020-08-27 12:59:32 +0200
committerRichard Purdie <richard.purdie@linuxfoundation.org>2020-08-28 07:08:37 +0100
commitb0bee2b736f03294bc97c13f9c9c92782458114a (patch)
tree559b181e6a6eacf3338937a0e6d3974d58df0942 /meta/lib/oeqa
parent2f7f9bc0f1bfc22b2b252cd394a69facba60b5ca (diff)
downloadpoky-b0bee2b736f03294bc97c13f9c9c92782458114a.tar.gz
oeqa/multilib: rework to use readelf from the host
It is difficult and error-prone to ensure binutils gets installed into target images where this test may run; on the other hand readelf is always present on the host, as it is a part of HOSTTOOLS. (From OE-Core rev: b7f62b28acb0efc9e9bf0126bd2425dcca012fd1) Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/lib/oeqa')
-rw-r--r--meta/lib/oeqa/runtime/cases/multilib.py9
1 files changed, 6 insertions, 3 deletions
diff --git a/meta/lib/oeqa/runtime/cases/multilib.py b/meta/lib/oeqa/runtime/cases/multilib.py
index 62e662b01c..56aed62eea 100644
--- a/meta/lib/oeqa/runtime/cases/multilib.py
+++ b/meta/lib/oeqa/runtime/cases/multilib.py
@@ -7,6 +7,8 @@ from oeqa.core.decorator.depends import OETestDepends
7from oeqa.core.decorator.data import skipIfNotInDataVar 7from oeqa.core.decorator.data import skipIfNotInDataVar
8from oeqa.runtime.decorator.package import OEHasPackage 8from oeqa.runtime.decorator.package import OEHasPackage
9 9
10import subprocess
11
10class MultilibTest(OERuntimeTestCase): 12class MultilibTest(OERuntimeTestCase):
11 13
12 def archtest(self, binary, arch): 14 def archtest(self, binary, arch):
@@ -14,8 +16,10 @@ class MultilibTest(OERuntimeTestCase):
14 Check that ``binary`` has the ELF class ``arch`` (e.g. ELF32/ELF64). 16 Check that ``binary`` has the ELF class ``arch`` (e.g. ELF32/ELF64).
15 """ 17 """
16 18
17 status, output = self.target.run('readelf -h %s' % binary) 19 dest = "{}/test_binary".format(self.td.get('T', ''))
18 self.assertEqual(status, 0, 'Failed to readelf %s' % binary) 20 self.target.copyFrom(binary, dest)
21 output = subprocess.check_output("readelf -h {}".format(dest), shell=True).decode()
22 os.remove(dest)
19 23
20 l = [l.split()[1] for l in output.split('\n') if "Class:" in l] 24 l = [l.split()[1] for l in output.split('\n') if "Class:" in l]
21 if l: 25 if l:
@@ -29,7 +33,6 @@ class MultilibTest(OERuntimeTestCase):
29 @skipIfNotInDataVar('MULTILIBS', 'multilib:lib32', 33 @skipIfNotInDataVar('MULTILIBS', 'multilib:lib32',
30 "This isn't a multilib:lib32 image") 34 "This isn't a multilib:lib32 image")
31 @OETestDepends(['ssh.SSHTest.test_ssh']) 35 @OETestDepends(['ssh.SSHTest.test_ssh'])
32 @OEHasPackage(['binutils'])
33 @OEHasPackage(['lib32-libc6']) 36 @OEHasPackage(['lib32-libc6'])
34 def test_check_multilib_libc(self): 37 def test_check_multilib_libc(self):
35 """ 38 """