summaryrefslogtreecommitdiffstats
path: root/meta/lib/oe/sstatesig.py
diff options
context:
space:
mode:
authorJoshua Watt <jpewhacker@gmail.com>2022-01-14 11:12:22 -0600
committerRichard Purdie <richard.purdie@linuxfoundation.org>2022-01-17 11:49:11 +0000
commit85b520587c127d39386d9c32f8cdf5cf70c42eeb (patch)
treef3a6e10e69ae3216ff71ae9d44fcd1904821509e /meta/lib/oe/sstatesig.py
parent02f87fc04ee982cd7ccd3690d0aee29cc5fa7e4e (diff)
downloadpoky-85b520587c127d39386d9c32f8cdf5cf70c42eeb.tar.gz
classes/native: Propagate dependencies to outhash
Native task outputs are directly run on the build system during the build after being built. Even if the output of a native recipe doesn't change, a change in one of its dependencies may cause a change in the output it generates (e.g. rpm output depends on the output of its dependent zstd library). This can cause poor interactions with hash equivalence, since this recipe's output-changing dependency is "hidden" and downstream tasks only see that this recipe has the same outhash and therefore is equivalent. This can result in different output in different cases and issues with reproducible builds in parcular (e.g. rpm compression changes for the same content). To resolve this, unhide the output-changing dependency by adding it's unihash to this tasks outhash calculation. Unfortunately, we don't know specifically know which dependencies are output-changing, so we have to add all of them. [YOCTO #14685] (From OE-Core rev: d6c7b9f4f0e61fa6546d3644e27abe3e96f597e2) Signed-off-by: Joshua Watt <JPEWhacker@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/lib/oe/sstatesig.py')
-rw-r--r--meta/lib/oe/sstatesig.py10
1 files changed, 7 insertions, 3 deletions
diff --git a/meta/lib/oe/sstatesig.py b/meta/lib/oe/sstatesig.py
index 038404e377..abcd96231e 100644
--- a/meta/lib/oe/sstatesig.py
+++ b/meta/lib/oe/sstatesig.py
@@ -491,7 +491,8 @@ def OEOuthashBasic(path, sigfile, task, d):
491 if task == "package": 491 if task == "package":
492 include_timestamps = True 492 include_timestamps = True
493 include_root = False 493 include_root = False
494 extra_content = d.getVar('HASHEQUIV_HASH_VERSION') 494 hash_version = d.getVar('HASHEQUIV_HASH_VERSION')
495 extra_sigdata = d.getVar("HASHEQUIV_EXTRA_SIGDATA")
495 496
496 filemaps = {} 497 filemaps = {}
497 for m in (d.getVar('SSTATE_HASHEQUIV_FILEMAP') or '').split(): 498 for m in (d.getVar('SSTATE_HASHEQUIV_FILEMAP') or '').split():
@@ -506,8 +507,11 @@ def OEOuthashBasic(path, sigfile, task, d):
506 basepath = os.path.normpath(path) 507 basepath = os.path.normpath(path)
507 508
508 update_hash("OEOuthashBasic\n") 509 update_hash("OEOuthashBasic\n")
509 if extra_content: 510 if hash_version:
510 update_hash(extra_content + "\n") 511 update_hash(hash_version + "\n")
512
513 if extra_sigdata:
514 update_hash(extra_sigdata + "\n")
511 515
512 # It is only currently useful to get equivalent hashes for things that 516 # It is only currently useful to get equivalent hashes for things that
513 # can be restored from sstate. Since the sstate object is named using 517 # can be restored from sstate. Since the sstate object is named using