summaryrefslogtreecommitdiffstats
path: root/meta/classes
diff options
context:
space:
mode:
authorRichard Purdie <richard.purdie@linuxfoundation.org>2016-05-09 14:09:37 +0100
committerRichard Purdie <richard.purdie@linuxfoundation.org>2016-05-17 21:29:30 +0100
commit9e01e2ee5c9558f13b8cf07ef18a2b70ece91675 (patch)
treed261ac59f8427cbd4ef83840c71815c116d85256 /meta/classes
parentf000d117532cdd4053ee3b3d9ee0c00a13da41ec (diff)
downloadpoky-9e01e2ee5c9558f13b8cf07ef18a2b70ece91675.tar.gz
image: Fix IMAGE_FEATURES determinism issue
remain_features uses a dict which means the order is not deterministic. This can lead to the task hash changing depending on the state of the memory at parse time. This is particularly noticeable under python v3. Since the dict is helpful in constructing the data, pass the data through sort() so the order is always deterministic. (From OE-Core rev: b08344e28dd33e3af5596007b11185d04fce255e) (From OE-Core rev: 6443cdfc963045ff305779f5d2326b1d588c6efe) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Armin Kuster <akuster808@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/classes')
-rw-r--r--meta/classes/image.bbclass2
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 8bfd24193e..acaa9ec947 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -166,7 +166,7 @@ python () {
166 if temp: 166 if temp:
167 bb.fatal("%s contains conflicting IMAGE_FEATURES %s %s" % (d.getVar('PN', True), feature, ' '.join(list(temp)))) 167 bb.fatal("%s contains conflicting IMAGE_FEATURES %s %s" % (d.getVar('PN', True), feature, ' '.join(list(temp))))
168 168
169 d.setVar('IMAGE_FEATURES', ' '.join(list(remain_features))) 169 d.setVar('IMAGE_FEATURES', ' '.join(sorted(list(remain_features))))
170 170
171 check_image_features(d) 171 check_image_features(d)
172 initramfs_image = d.getVar('INITRAMFS_IMAGE', True) or "" 172 initramfs_image = d.getVar('INITRAMFS_IMAGE', True) or ""