summaryrefslogtreecommitdiffstats
path: root/meta/classes
diff options
context:
space:
mode:
authorRichard Purdie <richard.purdie@linuxfoundation.org>2023-09-07 12:57:36 +0100
committerRichard Purdie <richard.purdie@linuxfoundation.org>2023-09-09 22:14:41 +0100
commit6fd8af0d30e555da55e5ca954009f32a84ced4a6 (patch)
treea8f0f66819459f548a9631161adc366bdc0da908 /meta/classes
parent32c98e6a8cd60aa5d2e60ab7b573ec6abae85ed4 (diff)
downloadpoky-6fd8af0d30e555da55e5ca954009f32a84ced4a6.tar.gz
classes: Drop ';' delimiter from ROOTFS/IMAGE*COMMAND variables
Originally these were shell functions but they have long since been processed by bb.build.exec_func(). Since we no longer need shell syntax, we can drop the ';' delimiters and just use a space separated string. This cleans up the variable and quietly removes any stray ';' that do happen to still make it in. (From OE-Core rev: c3365dfd9ddd7fbe70b62e0f11166e57a8ca6f73) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/classes')
-rw-r--r--meta/classes/buildhistory.bbclass26
-rw-r--r--meta/classes/create-spdx-2.2.bbclass6
-rw-r--r--meta/classes/cve-check.bbclass2
-rw-r--r--meta/classes/extrausers.bbclass2
-rw-r--r--meta/classes/image-buildinfo.bbclass4
5 files changed, 20 insertions, 20 deletions
diff --git a/meta/classes/buildhistory.bbclass b/meta/classes/buildhistory.bbclass
index 395f594278..fd53e92402 100644
--- a/meta/classes/buildhistory.bbclass
+++ b/meta/classes/buildhistory.bbclass
@@ -691,28 +691,28 @@ python buildhistory_get_extra_sdkinfo() {
691 691
692# By using ROOTFS_POSTUNINSTALL_COMMAND we get in after uninstallation of 692# By using ROOTFS_POSTUNINSTALL_COMMAND we get in after uninstallation of
693# unneeded packages but before the removal of packaging files 693# unneeded packages but before the removal of packaging files
694ROOTFS_POSTUNINSTALL_COMMAND += "buildhistory_list_installed_image ;" 694ROOTFS_POSTUNINSTALL_COMMAND += "buildhistory_list_installed_image"
695ROOTFS_POSTUNINSTALL_COMMAND += "buildhistory_get_image_installed ;" 695ROOTFS_POSTUNINSTALL_COMMAND += "buildhistory_get_image_installed"
696ROOTFS_POSTUNINSTALL_COMMAND[vardepvalueexclude] .= "| buildhistory_list_installed_image ;| buildhistory_get_image_installed ;" 696ROOTFS_POSTUNINSTALL_COMMAND[vardepvalueexclude] .= "| buildhistory_list_installed_image| buildhistory_get_image_installed"
697ROOTFS_POSTUNINSTALL_COMMAND[vardepsexclude] += "buildhistory_list_installed_image buildhistory_get_image_installed" 697ROOTFS_POSTUNINSTALL_COMMAND[vardepsexclude] += "buildhistory_list_installed_image buildhistory_get_image_installed"
698 698
699IMAGE_POSTPROCESS_COMMAND += "buildhistory_get_imageinfo ;" 699IMAGE_POSTPROCESS_COMMAND += "buildhistory_get_imageinfo"
700IMAGE_POSTPROCESS_COMMAND[vardepvalueexclude] .= "| buildhistory_get_imageinfo ;" 700IMAGE_POSTPROCESS_COMMAND[vardepvalueexclude] .= "| buildhistory_get_imageinfo"
701IMAGE_POSTPROCESS_COMMAND[vardepsexclude] += "buildhistory_get_imageinfo" 701IMAGE_POSTPROCESS_COMMAND[vardepsexclude] += "buildhistory_get_imageinfo"
702 702
703# We want these to be the last run so that we get called after complementary package installation 703# We want these to be the last run so that we get called after complementary package installation
704POPULATE_SDK_POST_TARGET_COMMAND:append = " buildhistory_list_installed_sdk_target;" 704POPULATE_SDK_POST_TARGET_COMMAND:append = " buildhistory_list_installed_sdk_target"
705POPULATE_SDK_POST_TARGET_COMMAND:append = " buildhistory_get_sdk_installed_target;" 705POPULATE_SDK_POST_TARGET_COMMAND:append = " buildhistory_get_sdk_installed_target"
706POPULATE_SDK_POST_TARGET_COMMAND[vardepvalueexclude] .= "| buildhistory_list_installed_sdk_target;| buildhistory_get_sdk_installed_target;" 706POPULATE_SDK_POST_TARGET_COMMAND[vardepvalueexclude] .= "| buildhistory_list_installed_sdk_target| buildhistory_get_sdk_installed_target"
707POPULATE_SDK_POST_TARGET_COMMAND[vardepsexclude] += "buildhistory_list_installed_sdk_target buildhistory_get_sdk_installed_target" 707POPULATE_SDK_POST_TARGET_COMMAND[vardepsexclude] += "buildhistory_list_installed_sdk_target buildhistory_get_sdk_installed_target"
708 708
709POPULATE_SDK_POST_HOST_COMMAND:append = " buildhistory_list_installed_sdk_host;" 709POPULATE_SDK_POST_HOST_COMMAND:append = " buildhistory_list_installed_sdk_host"
710POPULATE_SDK_POST_HOST_COMMAND:append = " buildhistory_get_sdk_installed_host;" 710POPULATE_SDK_POST_HOST_COMMAND:append = " buildhistory_get_sdk_installed_host"
711POPULATE_SDK_POST_HOST_COMMAND[vardepvalueexclude] .= "| buildhistory_list_installed_sdk_host;| buildhistory_get_sdk_installed_host;" 711POPULATE_SDK_POST_HOST_COMMAND[vardepvalueexclude] .= "| buildhistory_list_installed_sdk_host| buildhistory_get_sdk_installed_host"
712POPULATE_SDK_POST_HOST_COMMAND[vardepsexclude] += "buildhistory_list_installed_sdk_host buildhistory_get_sdk_installed_host" 712POPULATE_SDK_POST_HOST_COMMAND[vardepsexclude] += "buildhistory_list_installed_sdk_host buildhistory_get_sdk_installed_host"
713 713
714SDK_POSTPROCESS_COMMAND:append = " buildhistory_get_sdkinfo ; buildhistory_get_extra_sdkinfo; " 714SDK_POSTPROCESS_COMMAND:append = " buildhistory_get_sdkinfo buildhistory_get_extra_sdkinfo"
715SDK_POSTPROCESS_COMMAND[vardepvalueexclude] .= "| buildhistory_get_sdkinfo ; buildhistory_get_extra_sdkinfo; " 715SDK_POSTPROCESS_COMMAND[vardepvalueexclude] .= "| buildhistory_get_sdkinfo buildhistory_get_extra_sdkinfo"
716SDK_POSTPROCESS_COMMAND[vardepsexclude] += "buildhistory_get_sdkinfo buildhistory_get_extra_sdkinfo" 716SDK_POSTPROCESS_COMMAND[vardepsexclude] += "buildhistory_get_sdkinfo buildhistory_get_extra_sdkinfo"
717 717
718python buildhistory_write_sigs() { 718python buildhistory_write_sigs() {
diff --git a/meta/classes/create-spdx-2.2.bbclass b/meta/classes/create-spdx-2.2.bbclass
index 844b674f6f..aed1a94132 100644
--- a/meta/classes/create-spdx-2.2.bbclass
+++ b/meta/classes/create-spdx-2.2.bbclass
@@ -930,12 +930,12 @@ spdx_get_src[vardepsexclude] += "STAGING_KERNEL_DIR"
930do_rootfs[recrdeptask] += "do_create_spdx do_create_runtime_spdx" 930do_rootfs[recrdeptask] += "do_create_spdx do_create_runtime_spdx"
931do_rootfs[cleandirs] += "${SPDXIMAGEWORK}" 931do_rootfs[cleandirs] += "${SPDXIMAGEWORK}"
932 932
933ROOTFS_POSTUNINSTALL_COMMAND =+ "image_combine_spdx ; " 933ROOTFS_POSTUNINSTALL_COMMAND =+ "image_combine_spdx"
934 934
935do_populate_sdk[recrdeptask] += "do_create_spdx do_create_runtime_spdx" 935do_populate_sdk[recrdeptask] += "do_create_spdx do_create_runtime_spdx"
936do_populate_sdk[cleandirs] += "${SPDXSDKWORK}" 936do_populate_sdk[cleandirs] += "${SPDXSDKWORK}"
937POPULATE_SDK_POST_HOST_COMMAND:append:task-populate-sdk = " sdk_host_combine_spdx; " 937POPULATE_SDK_POST_HOST_COMMAND:append:task-populate-sdk = " sdk_host_combine_spdx"
938POPULATE_SDK_POST_TARGET_COMMAND:append:task-populate-sdk = " sdk_target_combine_spdx; " 938POPULATE_SDK_POST_TARGET_COMMAND:append:task-populate-sdk = " sdk_target_combine_spdx"
939 939
940python image_combine_spdx() { 940python image_combine_spdx() {
941 import os 941 import os
diff --git a/meta/classes/cve-check.bbclass b/meta/classes/cve-check.bbclass
index c1f1ea0fd6..55ae298024 100644
--- a/meta/classes/cve-check.bbclass
+++ b/meta/classes/cve-check.bbclass
@@ -286,7 +286,7 @@ python cve_check_write_rootfs_manifest () {
286 bb.plain("Image CVE JSON report stored in: %s" % manifest_name) 286 bb.plain("Image CVE JSON report stored in: %s" % manifest_name)
287} 287}
288 288
289ROOTFS_POSTPROCESS_COMMAND:prepend = "${@'cve_check_write_rootfs_manifest; ' if d.getVar('CVE_CHECK_CREATE_MANIFEST') == '1' else ''}" 289ROOTFS_POSTPROCESS_COMMAND:prepend = "${@'cve_check_write_rootfs_manifest ' if d.getVar('CVE_CHECK_CREATE_MANIFEST') == '1' else ''}"
290do_rootfs[recrdeptask] += "${@'do_cve_check' if d.getVar('CVE_CHECK_CREATE_MANIFEST') == '1' else ''}" 290do_rootfs[recrdeptask] += "${@'do_cve_check' if d.getVar('CVE_CHECK_CREATE_MANIFEST') == '1' else ''}"
291do_populate_sdk[recrdeptask] += "${@'do_cve_check' if d.getVar('CVE_CHECK_CREATE_MANIFEST') == '1' else ''}" 291do_populate_sdk[recrdeptask] += "${@'do_cve_check' if d.getVar('CVE_CHECK_CREATE_MANIFEST') == '1' else ''}"
292 292
diff --git a/meta/classes/extrausers.bbclass b/meta/classes/extrausers.bbclass
index 94576b8872..c825c06df9 100644
--- a/meta/classes/extrausers.bbclass
+++ b/meta/classes/extrausers.bbclass
@@ -23,7 +23,7 @@ inherit useradd_base
23PACKAGE_INSTALL:append = " ${@['', 'base-passwd shadow'][bool(d.getVar('EXTRA_USERS_PARAMS'))]}" 23PACKAGE_INSTALL:append = " ${@['', 'base-passwd shadow'][bool(d.getVar('EXTRA_USERS_PARAMS'))]}"
24 24
25# Image level user / group settings 25# Image level user / group settings
26ROOTFS_POSTPROCESS_COMMAND:append = " set_user_group;" 26ROOTFS_POSTPROCESS_COMMAND:append = " set_user_group"
27 27
28# Image level user / group settings 28# Image level user / group settings
29set_user_group () { 29set_user_group () {
diff --git a/meta/classes/image-buildinfo.bbclass b/meta/classes/image-buildinfo.bbclass
index 206cc9d57d..b83ce650ad 100644
--- a/meta/classes/image-buildinfo.bbclass
+++ b/meta/classes/image-buildinfo.bbclass
@@ -76,6 +76,6 @@ python buildinfo_sdk () {
76 bb.build.exec_func("buildinfo", d) 76 bb.build.exec_func("buildinfo", d)
77} 77}
78 78
79IMAGE_PREPROCESS_COMMAND += "buildinfo_image;" 79IMAGE_PREPROCESS_COMMAND += "buildinfo_image"
80POPULATE_SDK_PRE_TARGET_COMMAND += "buildinfo_sdk;" 80POPULATE_SDK_PRE_TARGET_COMMAND += "buildinfo_sdk"
81 81