summaryrefslogtreecommitdiffstats
path: root/documentation/contributor-guide
diff options
context:
space:
mode:
authorMichael Opdenacker <michael.opdenacker@bootlin.com>2023-08-09 11:39:35 +0200
committerRichard Purdie <richard.purdie@linuxfoundation.org>2023-08-30 15:54:59 +0100
commit80d1c907e6b32f717eef9cd00733f582864e2e91 (patch)
treeb3982295c1b63b2fd2310dc35e5b4ab5e1eb5672 /documentation/contributor-guide
parent63c0a2cc7710af4961d23f029187805de921aecc (diff)
downloadpoky-80d1c907e6b32f717eef9cd00733f582864e2e91.tar.gz
contributor-guide: add section about why we use mailing lists
(From yocto-docs rev: dda13405221102b66b0e08bee3004d0ce1c0c000) Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'documentation/contributor-guide')
-rw-r--r--documentation/contributor-guide/submit-change.rst50
1 files changed, 45 insertions, 5 deletions
diff --git a/documentation/contributor-guide/submit-change.rst b/documentation/contributor-guide/submit-change.rst
index 2555767102..1327b2854c 100644
--- a/documentation/contributor-guide/submit-change.rst
+++ b/documentation/contributor-guide/submit-change.rst
@@ -8,14 +8,54 @@ Because the system is extremely configurable and flexible, we recognize
8that developers will want to extend, configure or optimize it for their 8that developers will want to extend, configure or optimize it for their
9specific uses. 9specific uses.
10 10
11.. _ref-why-mailing-lists:
12
13Contributing through mailing lists --- Why not using web-based workflows?
14=========================================================================
15
16Both Yocto Project and OpenEmbedded have many key components that are
17maintained by patches being submitted on mailing lists. We appreciate this
18approach does look a little old fashioned when other workflows are available
19through web technology such as GitHub, GitLab and others. Since we are often
20asked this question, we’ve decided to document the reasons for using mailing
21lists.
22
23One significant factor is that we value peer review. When a change is proposed
24to many of the core pieces of the project, it helps to have many eyes of review
25go over them. Whilst there is ultimately one maintainer who needs to make the
26final call on accepting or rejecting a patch, the review is made by many eyes
27and the exact people reviewing it are likely unknown to the maintainer. It is
28often the surprise reviewer that catches the most interesting issues!
29
30This is in contrast to the "GitHub" style workflow where either just a
31maintainer makes that review, or review is specifically requested from
32nominated people. We believe there is significant value added to the codebase
33by this peer review and that moving away from mailing lists would be to the
34detriment of our code.
35
36We also need to acknowledge that many of our developers are used to this
37mailing list workflow and have worked with it for years, with tools and
38processes built around it. Changing away from this would result in a loss
39of key people from the project, which would again be to its detriment.
40
41The projects are acutely aware that potential new contributors find the
42mailing list approach off-putting and would prefer a web-based GUI.
43Since we don’t believe that can work for us, the project is aiming to ensure
44`patchwork <https://patchwork.yoctoproject.org/>`__ is available to help track
45patch status and also looking at how tooling can provide more feedback to users
46about patch status. We are looking at tools such as ``patchtest`` to
47test user contributions before they hit the mailing lists and also at better
48documenting how to use such workflows since we recognise that whilst this was
49common knowledge a decade ago, it might not be as familiar now.
50
11Finding a Suitable Mailing List 51Finding a Suitable Mailing List
12=============================== 52===============================
13 53
14The Yocto Project uses a mailing list and a patch-based workflow that is 54The Yocto Project and OpenEmbedded use a mailing list and a patch-based
15similar to the Linux kernel but contains important differences. In 55workflow that is similar to the Linux kernel but contains important
16general, there is a mailing list through which you can submit patches. You 56differences. In general, there is a mailing list through which you can submit
17should send patches to the appropriate mailing list so that they can be 57patches. You should send patches to the appropriate mailing list so that they
18reviewed and merged by the appropriate maintainer. The specific mailing 58can be reviewed and merged by the appropriate maintainer. The specific mailing
19list you need to use depends on the location of the code you are 59list you need to use depends on the location of the code you are
20changing. Each component (e.g. layer) should have a ``README`` file that 60changing. Each component (e.g. layer) should have a ``README`` file that
21indicates where to send the changes and which process to follow. 61indicates where to send the changes and which process to follow.