summaryrefslogtreecommitdiffstats
path: root/bitbake/lib/bb/ui/knotty.py
diff options
context:
space:
mode:
authorRichard Purdie <richard.purdie@linuxfoundation.org>2022-03-06 13:29:58 +0000
committerRichard Purdie <richard.purdie@linuxfoundation.org>2022-03-06 17:38:30 +0000
commite95fedc49c50eb374e4cec2c1283e9096f8d0880 (patch)
treeb856a8a22f0371239fcf1ee5371f365d3bdf914e /bitbake/lib/bb/ui/knotty.py
parentc9b71a9817703e6a70b85fbc07d50c783901ba25 (diff)
downloadpoky-e95fedc49c50eb374e4cec2c1283e9096f8d0880.tar.gz
bitbake: knotty: Improve setscene task display
There is general agreement the current display of the total setscene and executed full tasks is confusing. Fixing it is tricky to be clear to new users whilst not wasting screen real estate for experienced users and not compromisng features like the progress bar. As a compromise, move the setscene total to the previous line making the status display a two line summary for interactive terminals. This makes it clear what two of the numbers represent (setscene task) whilst separating this out from the other items. Also tweak the non-interactive output to use a comma as a separator, the use of the forward slash was a poor choice. (Bitbake rev: 8055ec360507e6a678ee5c4018ec1ab7f5a9cce5) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake/lib/bb/ui/knotty.py')
-rw-r--r--bitbake/lib/bb/ui/knotty.py6
1 files changed, 3 insertions, 3 deletions
diff --git a/bitbake/lib/bb/ui/knotty.py b/bitbake/lib/bb/ui/knotty.py
index 1bcdc0023a..b02e59c1fe 100644
--- a/bitbake/lib/bb/ui/knotty.py
+++ b/bitbake/lib/bb/ui/knotty.py
@@ -276,11 +276,11 @@ class TerminalFilter(object):
276 print(content) 276 print(content)
277 else: 277 else:
278 if self.quiet: 278 if self.quiet:
279 content = "Running tasks (%s of %s/%s of %s)" % (self.helper.setscene_current, self.helper.setscene_total, self.helper.tasknumber_current, self.helper.tasknumber_total) 279 content = "Running tasks (%s of %s, %s of %s)" % (self.helper.setscene_current, self.helper.setscene_total, self.helper.tasknumber_current, self.helper.tasknumber_total)
280 elif not len(activetasks): 280 elif not len(activetasks):
281 content = "No currently running tasks (%s of %s/%s of %s)" % (self.helper.setscene_current, self.helper.setscene_total, self.helper.tasknumber_current, self.helper.tasknumber_total) 281 content = "Setscene tasks: %s of %s\nNo currently running tasks (%s of %s)" % (self.helper.setscene_current, self.helper.setscene_total, self.helper.tasknumber_current, self.helper.tasknumber_total)
282 else: 282 else:
283 content = "Currently %2s running tasks (%s of %s/%s of %s)" % (len(activetasks), self.helper.setscene_current, self.helper.setscene_total, self.helper.tasknumber_current, self.helper.tasknumber_total) 283 content = "Setscene tasks: %s of %s\nCurrently %2s running tasks (%s of %s)" % (self.helper.setscene_current, self.helper.setscene_total, len(activetasks), self.helper.tasknumber_current, self.helper.tasknumber_total)
284 maxtask = self.helper.tasknumber_total 284 maxtask = self.helper.tasknumber_total
285 if not self.main_progress or self.main_progress.maxval != maxtask: 285 if not self.main_progress or self.main_progress.maxval != maxtask:
286 widgets = [' ', progressbar.Percentage(), ' ', progressbar.Bar()] 286 widgets = [' ', progressbar.Percentage(), ' ', progressbar.Bar()]