summaryrefslogtreecommitdiffstats
path: root/bitbake/lib/bb/tests
diff options
context:
space:
mode:
authorMikko Rapeli <mikko.rapeli@bmw.de>2017-06-01 18:51:33 +0300
committerRichard Purdie <richard.purdie@linuxfoundation.org>2017-11-05 22:37:29 +0000
commit449062508890e369ec7a124a1b9ce9ba7dd90ba7 (patch)
tree2b08feeb8fdc0790ce95c895d20c9653d7f58626 /bitbake/lib/bb/tests
parenta475795953822573264891bce459a91cc7d99201 (diff)
downloadpoky-449062508890e369ec7a124a1b9ce9ba7dd90ba7.tar.gz
bitbake: bitbake: Fix return value checks from subprocess.call()'s
Python function subprocess.call() returns the return value of the executed process. If return values are not checked, errors may go unnoticed and bad things can happen. Change all callers of subprocess.call() which do not check for the return value to use subprocess.check_call() which raises CalledProcessError if the subprocess returns with non-zero value. https://docs.python.org/2/library/subprocess.html#using-the-subprocess-module All users of the function were found with: $ git grep "subprocess\.call" | \ egrep -v 'if.*subprocess\.call|=\ +subprocess\.call|return.*subprocess\.call' Tested similar patch on top of yocto jethro. Only compile tested core-image-minimal on poky master branch. (Bitbake rev: aac956a0950c05bf58af1885474cd89bb9c8fbd1) Signed-off-by: Mikko Rapeli <mikko.rapeli@bmw.de> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake/lib/bb/tests')
0 files changed, 0 insertions, 0 deletions