summaryrefslogtreecommitdiffstats
path: root/bitbake/lib/bb/fetch2/git.py
diff options
context:
space:
mode:
authorYu Ke <ke.yu@intel.com>2010-12-27 09:31:38 +0800
committerRichard Purdie <richard.purdie@linuxfoundation.org>2011-01-10 20:24:33 +0000
commit1589a1172f9432aed1cc9ce006f68cddf3073774 (patch)
tree48616149e847a09c87668f6342b64dce15f4f57f /bitbake/lib/bb/fetch2/git.py
parent550c3bd82115b4bdb8235da53cfc18b1dc39ad96 (diff)
downloadpoky-1589a1172f9432aed1cc9ce006f68cddf3073774.tar.gz
Fetcher: break the "SRCREVINACTION" deadlock
Current fetcher has annoying "SRCREVINACTION" deadlock, which occurs when SRCREV=${AUTOREV}=@bb.fetch.get_srcrev(): get_srcrev()->setup_localpath()->srcrev_internal_helper() ->evaluate SRCREV->get_srcrev() current fetcher resolve the deadlock by introducing a "SRCREVINACTION" condition check. Althoguh it works, it is indeed not clean. This patch use antoehr idea to break the deadlock: break the dependency among SRCREV and get_srcrev(), i.e. assign a specific keyword "AUTOINC" to AUTOREV. when Fetcher meet this keyword, it will check and set the latest revision to urldata.revision. get_srcrev later can use the urldata.revision for value evaluation(SRCPV etc). In this case, SRCREV no longer depends on get_srcrev, and there is not deadlock anymore. Signed-off-by: Yu Ke <ke.yu@intel.com>
Diffstat (limited to 'bitbake/lib/bb/fetch2/git.py')
-rw-r--r--bitbake/lib/bb/fetch2/git.py8
1 files changed, 1 insertions, 7 deletions
diff --git a/bitbake/lib/bb/fetch2/git.py b/bitbake/lib/bb/fetch2/git.py
index 58ed1f4108..c62145770f 100644
--- a/bitbake/lib/bb/fetch2/git.py
+++ b/bitbake/lib/bb/fetch2/git.py
@@ -62,13 +62,7 @@ class Git(Fetch):
62 ud.basecmd = data.getVar("FETCHCMD_git", d, True) or "git" 62 ud.basecmd = data.getVar("FETCHCMD_git", d, True) or "git"
63 63
64 def localpath(self, url, ud, d): 64 def localpath(self, url, ud, d):
65 65 ud.tag = ud.revision
66 tag = Fetch.srcrev_internal_helper(ud, d)
67 if tag is True:
68 ud.tag = self.latest_revision(url, ud, d)
69 elif tag:
70 ud.tag = tag
71
72 if not ud.tag or ud.tag == "master": 66 if not ud.tag or ud.tag == "master":
73 ud.tag = self.latest_revision(url, ud, d) 67 ud.tag = self.latest_revision(url, ud, d)
74 68